Re: svn commit: r965709 - in /httpd/httpd/trunk: CHANGES server/request.c

2010-07-20 Thread Ruediger Pluem
On 07/20/2010 03:34 AM, n...@apache.org wrote: Author: niq Date: Tue Jul 20 01:34:39 2010 New Revision: 965709 URL: http://svn.apache.org/viewvc?rev=965709view=rev Log: Don't risk segfault in authz if r-user is not set PR 42995 Modified: httpd/httpd/trunk/CHANGES

Re: svn commit: r965408 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_config.h modules/core/mod_so.c server/config.c

2010-07-20 Thread Ruediger Pluem
On 07/19/2010 12:06 PM, s...@apache.org wrote: Author: sf Date: Mon Jul 19 10:06:15 2010 New Revision: 965408 URL: http://svn.apache.org/viewvc?rev=965408view=rev Log: Add ap_find_module_short_name() to quickly get the module short name (i.e. symbol name with trailing _module removed)

Re: svn commit: r965709 - in /httpd/httpd/trunk: CHANGES server/request.c

2010-07-20 Thread Nick Kew
On 20 Jul 2010, at 07:43, Ruediger Pluem wrote: Is this needed any longer? Shouldn't authz be expected to handle r-user == NULL after Stefans recent changes? Hadn't considered that. An extra check here can't hurt, can it? -- Nick Kew

Re: svn commit: r930125 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_balancer.c

2010-07-20 Thread Daniel Ruggeri
On 7/16/2010 10:37 AM, Jeff Trawick wrote: On Fri, Jul 16, 2010 at 11:27 AM, William A. Rowe Jr. wr...@rowe-clan.net wrote: On 7/16/2010 9:35 AM, William A. Rowe Jr. wrote: On 7/16/2010 6:47 AM, Jeff Trawick wrote: We may as well leave it at erroronstatus I agree with Eric

Adding sub second timestamps and request end time to mod_log_config

2010-07-20 Thread Rainer Jung
There's a patch at http://people.apache.org/~rjung/patches/httpd-trunk-adding-milliseconds-and-microseconds-to-the-access-log.patch that adds configurable logging of sub second timestamp resolutions and request end timestamps to the access log (all via %{...}t). Any objections against adding

Re: Error log format configuration syntax

2010-07-20 Thread Rainer Jung
On 20.07.2010 00:39, Stefan Fritsch wrote: Hi, I have been working on making the error log format configurable. It's more or less working now, but I could use some feed-back about the config syntax. The difficulty is that many tokens only produce output in some situations (e.g. no remote IP in

Re: svn commit: r965709 - in /httpd/httpd/trunk: CHANGES server/request.c

2010-07-20 Thread Stefan Fritsch
On Tuesday 20 July 2010, Nick Kew wrote: On 20 Jul 2010, at 07:43, Ruediger Pluem wrote: Is this needed any longer? Shouldn't authz be expected to handle r-user == NULL after Stefans recent changes? I have reverted the change that the auth_checker hook is also called with r-user == NULL.

Re: svn commit: r965408 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_config.h modules/core/mod_so.c server/config.c

2010-07-20 Thread Stefan Fritsch
On Tuesday 20 July 2010, Ruediger Pluem wrote: On 07/19/2010 12:06 PM, s...@apache.org wrote: Author: sf Date: Mon Jul 19 10:06:15 2010 New Revision: 965408 URL: http://svn.apache.org/viewvc?rev=965408view=rev Log: Add ap_find_module_short_name() to quickly get the module short

Re: Error log format configuration syntax

2010-07-20 Thread Stefan Fritsch
On Tue, 20 Jul 2010, Rainer Jung wrote: message and behind the message. I guess you can get rid of the latter split by assigning a format specifier also to the log message, like '%M' or similar, and then ErrorLogFormat [%{u}t] [%l] [pid %P%{:tid }T] %F: %{}{: }E%{[client }{] }a %M %{}{,

rolling 2.2.16 tomorrow

2010-07-20 Thread Paul Querna
Hi, I'll start the tagging + voting on 2.2.16 tomorrow unless everyone starts screaming.. Thanks, Paul

Re: rolling 2.2.16 tomorrow

2010-07-20 Thread Stefan Fritsch
On Tuesday 20 July 2010, Paul Querna wrote: I'll start the tagging + voting on 2.2.16 tomorrow unless everyone starts screaming.. Is this the right point of time? There are still quite a few backport proposals in STATUS. Personally, I would prefer to concentrate on 2.3.7 right now and do

Re: Adding sub second timestamps and request end time to mod_log_config

2010-07-20 Thread Stefan Fritsch
On Tuesday 20 July 2010, Rainer Jung wrote: There's a patch at http://people.apache.org/~rjung/patches/httpd-trunk-adding-millisec onds-and-microseconds-to-the-access-log.patch that adds configurable logging of sub second timestamp resolutions and request end timestamps to the access log

mod_proxy_http, ProxyTimeout and apr_socket_timeout_set

2010-07-20 Thread Neal Richter
Hi all, Basic question on the ProxyTimeout for mod_proxy_http. Is it: - first byte? - last byte? My guess is that it's a first byte timeout based upon this: /** * Setup socket timeout for the specified socket * @param sock The socket to set up. * @param t Value for the timeout.

Re: svn commit: r966060 - /httpd/httpd/branches/2.2.x/STATUS

2010-07-20 Thread Jeff Trawick
On Wed, Jul 21, 2010 at 6:01 AM, n...@apache.org wrote: Author: niq Date: Wed Jul 21 00:31:07 2010 New Revision: 966060 URL: http://svn.apache.org/viewvc?rev=966060view=rev Log: Propose backport. This one-line patch fixes a bug introduced since 2.2.15, so it would be a particularly good

Re: mod_proxy_http, ProxyTimeout and apr_socket_timeout_set

2010-07-20 Thread Jeff Trawick
On Wed, Jul 21, 2010 at 2:41 AM, Neal Richter nrich...@gmail.com wrote: Hi all,  Basic question on the ProxyTimeout for mod_proxy_http.   Is it:    - first byte?    - last byte? any byte (i.e., any time proxy attempts I/O, the request fails if it can't send/receive a single byte within this

Re: mod_proxy_http, ProxyTimeout and apr_socket_timeout_set

2010-07-20 Thread Neal Richter
OK thanks.. making sure it would not timeout an ongoing download. We had an issue with a truncated javascript file being served then cached by Akamai. The JS is generated by a backend process that Apache proxies to. I don't think Apache is the problem there.. Thanks - Neal On Tue, Jul 20,

Re: svn commit: r965408 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_config.h modules/core/mod_so.c server/config.c

2010-07-20 Thread Ruediger Pluem
On 07/20/2010 08:43 PM, Stefan Fritsch wrote: On Tuesday 20 July 2010, Ruediger Pluem wrote: On 07/19/2010 12:06 PM, s...@apache.org wrote: + +ap_module_short_names[m-module_index] = strdup(sym_name); Why not using pools here instead of malloc / free? Because it didn't work.

Re: svn commit: r966060 - /httpd/httpd/branches/2.2.x/STATUS

2010-07-20 Thread Ruediger Pluem
On 07/21/2010 05:06 AM, Jeff Trawick wrote: On Wed, Jul 21, 2010 at 6:01 AM, wrote: Author: niq Date: Wed Jul 21 00:31:07 2010 New Revision: 966060 URL: http://svn.apache.org/viewvc?rev=966060view=rev Log: Propose backport. This one-line patch fixes a bug introduced since 2.2.15, so