thread safety and mpm-prefork

2013-06-11 Thread Alex Bligh
I've written a module which I believe to be thread-safe but appears to be doing something which I have put down to a lack of thread safety in pool management (somewhere). Before I tear my hair out here, my module is running with apache 2.2.22 and mpm-prefork on Ubuntu. Do the thread primatives

Re: thread safety and mpm-prefork

2013-06-11 Thread Sorin Manolache
On 2013-06-11 21:20, Alex Bligh wrote: I've written a module which I believe to be thread-safe but appears to be doing something which I have put down to a lack of thread safety in pool management (somewhere). Before I tear my hair out here, my module is running with apache 2.2.22 and

Re: thread safety and mpm-prefork

2013-06-11 Thread Alex Bligh
Sorin, On 11 Jun 2013, at 21:57, Sorin Manolache wrote: The threadallocatormutex is created from a child of the request pool. The request pool and its child-pools are destroyed when the request terminates. Do you use the threadpool/threadallocator/threadallocatormutex afterwards? Nope.

Re: thread safety and mpm-prefork

2013-06-11 Thread Alex Bligh
On 11 Jun 2013, at 23:06, Sorin Manolache wrote: I'm sorry, I ran out of ideas. I suppose that the operations of the two threads on the bucket brigade are protected by mutexes... Yep. I create my own output bucket brigade too. I *presume* this uses the allocator mutex to manipulate the

Re: svn commit: r1491466 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/proxy/proxy_util.c

2013-06-11 Thread Christophe JAILLET
Le 10/06/2013 16:28, minf...@apache.org a écrit : Modified: httpd/httpd/branches/2.4.x/CHANGES URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/CHANGES?rev=1491466r1=1491465r2=1491466view=diff == ---

Re: svn commit: r1491466 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/proxy/proxy_util.c

2013-06-11 Thread Jeff Trawick
On Tue, Jun 11, 2013 at 7:08 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Le 10/06/2013 16:28, minf...@apache.org a écrit : Modified: httpd/httpd/branches/2.4.x/**CHANGES URL: http://svn.apache.org/viewvc/**httpd/httpd/branches/2.4.x/**

Re: svn commit: r1491466 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/proxy/proxy_util.c

2013-06-11 Thread Graham Leggett
On 11 Jun 2013, at 1:08 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: + *) proxy_util: NULL terminate the right buffer in 'send_http_connect'. + [Christophe Jaillet] + *) mod_remoteip: close file in error path. [Christophe Jaillet] *) mod_lua: Sync 2.4 branch with

Re: svn commit: r1491466 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/proxy/proxy_util.c

2013-06-11 Thread Christophe JAILLET
Le 11/06/2013 13:21, Graham Leggett a écrit : On 11 Jun 2013, at 1:08 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: + *) proxy_util: NULL terminate the right buffer in 'send_http_connect'. + [Christophe Jaillet] + *) mod_remoteip: close file in error path. [Christophe

Re: svn commit: r1491466 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS modules/proxy/proxy_util.c

2013-06-11 Thread Jim Jagielski
STATUS is for userland and user-view changes... enhancements, bug-fixes, etc that the end-user will likely want to be aware of. On Jun 11, 2013, at 7:08 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Le 10/06/2013 16:28, minf...@apache.org a écrit : Modified:

Re: svn commit: r1491612 - /httpd/httpd/branches/2.4.x/STATUS

2013-06-11 Thread André Malo
* s...@apache.org wrote: Author: sf Date: Mon Jun 10 21:41:07 2013 New Revision: 1491612 URL: http://svn.apache.org/r1491612 Log: comment Modified: httpd/httpd/branches/2.4.x/STATUS Modified: httpd/httpd/branches/2.4.x/STATUS URL:

[Result][Vote] Switch mod_lua in 2.4 to CTR

2013-06-11 Thread Rainer Jung
I call the vote closed. Results are: +1: covener, fuankg, humbedooh, rjung, sf +0: - -1: - So mod_lua is now CTR in 2.4. Regards, Rainer