[PATCH] mod_http2, mod_proxy_http2: fix CMake support

2016-05-12 Thread Evgeny Kotkov
I noticed a few issues in CMakeLists.txt that currently prevent building mod_http2 and mod_proxy_http2 — that is, missing includes and library references. The attached patch should fix them. Regards, Evgeny Kotkov Fix CMake support for mod_http2 and mod_proxy_http2. Index: CMakeLists.txt ==

[PATCH] mod_proxy_http2: fix theoretically possible segfault when parsing URL

2016-05-12 Thread Evgeny Kotkov
This patch fixes a theoretically possible segfault in mod_proxy_http2. Please see the open_stream() function in h2_proxy_session.c:598. If the call to apr_uri_parse() fails, some of the apr_uri_t's fields may be set to NULL, and this would cause a segfault in the following lines: authority =

[PATCH] mod_rewrite: support proxying via mod_proxy_http2

2016-05-12 Thread Evgeny Kotkov
I noticed that it's currently impossible to use mod_proxy_http2 in conjunction with mod_rewrite's [P] request proxying: RewriteEngine On RewriteRule ^/foo h2c://hostname/bar [P] mod_proxy_http2 registers on h2:// and h2c:// proxy URLs [1], however, mod_rewrite needs an update to handl

Re: svn commit: r1742822 - /httpd/httpd/trunk/modules/http/http_core.c

2016-05-12 Thread William A Rowe Jr
On Sun, May 8, 2016 at 8:53 AM, wrote: > Author: rjung > Date: Sun May 8 13:53:37 2016 > New Revision: 1742822 > > URL: http://svn.apache.org/viewvc?rev=1742822&view=rev > Log: > Fix yet another case where we clobber the > server-status request info when a timeout happens. > > Modified: > ht

Re: [PATCH] mod_http2, mod_proxy_http2: fix CMake support

2016-05-12 Thread Jacob Champion
On 05/12/2016 07:31 AM, Evgeny Kotkov wrote: @@ -451,11 +452,11 @@ SET(mod_proxy_wstunnel_extra_libsmod_proxy) SET(mod_proxy_http2_requires NGHTTP2_FOUND) SET(mod_proxy_http2_extra_defines ssize_t=long) -SET(mod_proxy_http2_extra_libs ${NGHTTP2_LIBRARI

Re: [PATCH] mod_http2, mod_proxy_http2: fix CMake support

2016-05-12 Thread Stefan Eissing
Thanks Evgeny. Applied in trunk as r1743512. To Jacob: mod_http2 should not be necessary as only OPTIONAL functions are used from it. mod_proxy_http2 is designed to work without mod_http2 being loaded (although it makes more sense if it is). -Stefan > Am 12.05.2016 um 16:54 schrieb Jacob Champ

Re: [PATCH] mod_proxy_http2: fix theoretically possible segfault when parsing URL

2016-05-12 Thread Stefan Eissing
Evgeny, both patches look fine. Thanks! Applied in r1743517. Cheers, Stefan > Am 12.05.2016 um 16:33 schrieb Evgeny Kotkov : > > This patch fixes a theoretically possible segfault in mod_proxy_http2. > > Please see the open_stream() function in h2_proxy_session.c:598. If the > call to apr_u

Re: [PATCH] mod_rewrite: support proxying via mod_proxy_http2

2016-05-12 Thread Stefan Eissing
Hmm, can someone with more brains than me on mod_rewrite look at the first patch if we want to add handling for h2: and h2c: uri schemes here or if there is a better way? Thanks. -Stefan > Am 12.05.2016 um 16:34 schrieb Evgeny Kotkov : > > I noticed that it's currently impossible to use mod_pr

mod_proxy_hcheck backport

2016-05-12 Thread Jim Jagielski
Looking, begging, pleading for tests and votes :)

Re: Broken link on Apache.org

2016-05-12 Thread David Nalley
Hi Jerry, Thanks for your report. I've forwarded this on to the Apache httpd project who is responsible for maintaining that specific website. Thanks, --David On Thu, May 12, 2016 at 6:16 PM, Jerry Lucas wrote: > Hello Webmaster, > > > > I found a broken link on the web page at > http://httpd.

Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion & Christophe JAILLET
Hi all, mod_proxy_http2 does not compile because of changes made in mod_hhtp2: - h2_ihash_is_empty vs h2_ihash_empty - h2_request_create vs h2_req_create - modified header files - ... If not fixed in the mean time, I'll give a look at it tonight. Do we need to go thru the formal v

Re: End of the road of 2.2.x maintenance?

2016-05-12 Thread Kurt Newman
I’m guessing this e-mail is primarily focused on the dev side of things. However, from a distributing side, cPanel’s migration from 2.2 to 2.4 for our customers was, for the most part, a non-eventful blip. This isn’t meant to be a boasting seminar, but more of an appreciation for the great migr

Re: svn commit: r1743577 [1/2] - in /httpd/httpd/branches/2.4.x: docs/manual/mod/mod_proxy_http2.xml modules/http2/NWGNUproxyht2 modules/http2/h2_proxy_session.c modules/http2/h2_proxy_session.h modul

2016-05-12 Thread Marion & Christophe JAILLET
Hi, there are 2 valid issues spotted by smatch in debug logging message: modules/http2/h2_proxy_session.c:339 on_data_chunk_recv() error: we previously assumed 'stream' could be null (see line 338) modules/http2/h2_proxy_session.c:425 stream_data_read() error: we previously assumed 'st