Re: Mistaken attributions?

2017-12-15 Thread Jim Jagielski
> On Dec 15, 2017, at 11:26 AM, William A Rowe Jr wrote: > > Actually remoteip isn't a showstopper... I find it demotivating and against > the spirit of httpd development, but am NOT vetoing it, and was showing an > example of proper form when attribution is desired. > >

Re: Mistaken attributions?

2017-12-15 Thread William A Rowe Jr
Actually remoteip isn't a showstopper... I find it demotivating and against the spirit of httpd development, but am NOT vetoing it, and was showing an example of proper form when attribution is desired. mod_h2 is a showstopper. It is missing an ASF copyright statement altogether. On Dec 15,

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Jim Jagielski
> On Dec 15, 2017, at 7:06 AM, Jim Jagielski wrote: > > >> On Dec 13, 2017, at 2:49 PM, Ruediger Pluem wrote: >> >> >> >> On 12/13/2017 04:27 PM, Steffen wrote: >>> I know, for example: >>> >>> util_expr_scan.c >> >> At least this one includes

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Steffen
Also the .dsp did not work here (Gregg ?) It is building when I add one of the following two in mod_proxy_uwsgi.c: it builds with: #define uint8_t unsigned __int8 or it builds when: #include "stdint.h" Attached stdint.h Do not know how to test. On Wednesday 13/12/2017 at 20:49,

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Steffen
It is building when I add one of the following two in mod_proxy_uwsgi.c: it builds with: #define uint8_t unsigned __int8 or it builds when: #include "stdint.h" stdint.h attached. Attached stdint.h Do not know how to test. On Wednesday 13/12/2017 at 20:49, Ruediger Pluem wrote: On

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Jim Jagielski
> On Dec 13, 2017, at 2:49 PM, Ruediger Pluem wrote: > > > > On 12/13/2017 04:27 PM, Steffen wrote: >> I know, for example: >> >> util_expr_scan.c > > At least this one includes inttypes.h which seems according to the comments > is only available on C99. > Should we

Re: mod_proxy_uwsgi build errors

2017-12-15 Thread Jim Jagielski
Who is using C99?? > On Dec 13, 2017, at 2:07 PM, William A Rowe Jr wrote: > > C99 is promiscuous. > > I thought we were holding to C89 on the 2.4 branch? > > On Dec 13, 2017 09:23, "Jim Jagielski" > wrote: > We use uint8_t

Re: 2.4.x STATUS needs you!

2017-12-15 Thread Jim Jagielski
> On Dec 14, 2017, at 11:31 AM, William A Rowe Jr wrote: > > It is good to see you share my concern about unreleased code for > a change. I share it all the time... That's why I work on getting back ports into 2.4.x as diligently as I do.

Re: Mistaken attributions?

2017-12-15 Thread Gillis J. de Nijs
>From what I understand, it should be something like: /* Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file

Re: Mistaken attributions?

2017-12-15 Thread Graham Leggett
On 14 Dec 2017, at 8:43 PM, William A Rowe Jr wrote: > So without diving into why one or another form is more correct, > the ASF's global license header guidance is absolute. > > mod_remoteip is an example of getting it 'right' by many > definitions of 'right' across the