Re: [VOTE] Release httpd-2.4.32

2018-03-12 Thread Eric Covener
On Fri, Mar 9, 2018 at 9:49 PM, Daniel Ruggeri wrote: > Hi, all; > >Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > > > I would like to call a VOTE over the next few days to release this candidate >

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Yann Ylavic
On Mon, Mar 12, 2018 at 4:50 PM, Eric Covener wrote: > On Mon, Mar 12, 2018 at 11:37 AM, Yann Ylavic wrote: >> On Mon, Mar 12, 2018 at 3:09 PM, Eric Covener wrote: >>> On Mon, Mar 12, 2018 at 9:42 AM, Rainer Jung

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Eric Covener
On Mon, Mar 12, 2018 at 11:37 AM, Yann Ylavic wrote: > On Mon, Mar 12, 2018 at 3:09 PM, Eric Covener wrote: >> On Mon, Mar 12, 2018 at 9:42 AM, Rainer Jung wrote: >>> Hi Steffen, hi list, >>> >>> Am 12.03.2018 um 14:07 schrieb

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Yann Ylavic
On Mon, Mar 12, 2018 at 3:09 PM, Eric Covener wrote: > On Mon, Mar 12, 2018 at 9:42 AM, Rainer Jung wrote: >> Hi Steffen, hi list, >> >> Am 12.03.2018 um 14:07 schrieb Steffen: >>> >>> I think it should released with 2.4.32 (+) . >>> >>> Endly solved

Re: svn commit: r1826543 - /httpd/httpd/branches/2.4.x/modules/http/http_request.c

2018-03-12 Thread Yann Ylavic
On Mon, Mar 12, 2018 at 3:17 PM, Eric Covener wrote: > On Mon, Mar 12, 2018 at 9:39 AM, Rainer Jung wrote: >> >> Am 12.03.2018 um 13:24 schrieb yla...@apache.org: >>> >>> ==

Re: svn commit: r1826543 - /httpd/httpd/branches/2.4.x/modules/http/http_request.c

2018-03-12 Thread Eric Covener
On Mon, Mar 12, 2018 at 9:39 AM, Rainer Jung wrote: > Hi Yann, > > > Am 12.03.2018 um 13:24 schrieb yla...@apache.org: >> >> Author: ylavic >> Date: Mon Mar 12 12:24:27 2018 >> New Revision: 1826543 >> >> URL: http://svn.apache.org/viewvc?rev=1826543=rev >> Log: >> Fix

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Eric Covener
On Mon, Mar 12, 2018 at 9:42 AM, Rainer Jung wrote: > Hi Steffen, hi list, > > Am 12.03.2018 um 14:07 schrieb Steffen: >> >> I think it should released with 2.4.32 (+) . >> >> Endly solved a pain with all that crashes. > > > thanks for reminding us of that problem. > >

Re: [VOTE] Release httpd-2.4.32

2018-03-12 Thread Steffen
Daniel, I see no Jansson in you libary list, you did not build/tested mod_md ? For your info, not relevant : Here we use newer versions with 2.4.32 for: Brotli 1.0.3 libxml2 2.9.8 nghttp2 1.31.0 On Saturday 10/03/2018 at 05:08, Daniel Ruggeri wrote: On 2018/03/10 02:49:15, "Daniel

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Steffen
It is not a logging only change, it solves crashes in libapr1.dll (was not safe to use r / r->pool in the event of a timeout ) I plan to ship AL build 2.4.32 with this fix. On Monday 12/03/2018 at 14:42, Rainer Jung wrote: Hi Steffen, hi list, Am 12.03.2018 um 14:07 schrieb Steffen: I

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Rainer Jung
Hi Steffen, hi list, Am 12.03.2018 um 14:07 schrieb Steffen: I think it should released with 2.4.32 (+) . Endly  solved  a pain with  all that crashes. thanks for reminding us of that problem. Since it is a logging only change for INFO log level and our default log level is WARN, plus as

Re: svn commit: r1826543 - /httpd/httpd/branches/2.4.x/modules/http/http_request.c

2018-03-12 Thread Rainer Jung
Hi Yann, Am 12.03.2018 um 13:24 schrieb yla...@apache.org: Author: ylavic Date: Mon Mar 12 12:24:27 2018 New Revision: 1826543 URL: http://svn.apache.org/viewvc?rev=1826543=rev Log: Fix timeout logging in ap_process_request(). We can't use 'r' after ap_process_request_after_handler(), the

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Steffen
I think it should released with 2.4.32 (+) . Endly solved a pain with all that crashes. On Monday 12/03/2018 at 13:33, Yann Ylavic wrote: On Mon, Mar 12, 2018 at 1:03 PM, Yann Ylavic wrote: The fix could be something like this: Index:

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Yann Ylavic
On Mon, Mar 12, 2018 at 1:03 PM, Yann Ylavic wrote: > > The fix could be something like this: > > Index: modules/http/http_request.c > === > --- modules/http/http_request.c(revision 1826315) > +++

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Steffen
Thanks I have the feeling that you catched some which solves a lot of reported crashes since 2.4.17. Running now with 2.4.32, now waiting is we have still crashes. Only rebuild libhttpd.dll with request.c : * It is still safe to use r / r->pool here as the eor bucket

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Yann Ylavic
On Mon, Mar 12, 2018 at 12:53 PM, Yann Ylavic wrote: > > Can you still reproduce with this patch: > > Index: modules/http/http_request.c > === > --- modules/http/http_request.c(revision 1826315) > +++

Re: mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Yann Ylavic
Hi Steffen, On Mon, Mar 12, 2018 at 11:52 AM, Steffen wrote: > > A way back in 2015 I pointed this error before here: > > http://apache-http-server.18135.x6.nabble.com/2-4-17-dev-crash-libapr-1-dll-tt5024061.html#none > > > Quote from Yann there: > > Answer from a

Re: [VOTE] Release httpd-2.4.32

2018-03-12 Thread Yann Ylavic
On Sat, Mar 10, 2018 at 3:49 AM, Daniel Ruggeri wrote: > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.32: > +1: It's not just good, it's good enough! All fine (no regression) on up to date Debian's 9 (64bit), 8 (64bit) and

Re: Vote 2.4.32 and mod_md no valid Certificate Agreement directive

2018-03-12 Thread Eric Covener
On Mon, Mar 12, 2018 at 6:33 AM, Stefan Eissing wrote: > >> Am 12.03.2018 um 11:23 schrieb Daniel Gruno : >> >> Would it be possible to just have a link that always points to the >> _current_ agreement, much like our docs have a /current/

mod_security Chrash in 2.9.2 libapr1.dll

2018-03-12 Thread Steffen
A way back in 2015 I pointed this error before here: http://apache-http-server.18135.x6.nabble.com/2-4-17-dev-crash-libapr-1-dll-tt5024061.html#none Quote from Yann there: Answer from a Apache-dev: puzzled about how node->next (ie. pool->active->next->next) can be NULL, this is supposed to

Re: Vote 2.4.32 and mod_md no valid Certificate Agreement directive

2018-03-12 Thread Stefan Eissing
> Am 12.03.2018 um 11:23 schrieb Daniel Gruno : > > Would it be possible to just have a link that always points to the > _current_ agreement, much like our docs have a /current/ directory that > always fetches you the current 2.4 docs? More a question for Let's Encrypt

Re: Vote 2.4.32 and mod_md no valid Certificate Agreement directive

2018-03-12 Thread Daniel Gruno
Would it be possible to just have a link that always points to the _current_ agreement, much like our docs have a /current/ directory that always fetches you the current 2.4 docs? On 03/12/2018 11:03 AM, Stefan Eissing wrote: > > >> Am 12.03.2018 um 10:39 schrieb Luca Toscano

Re: [VOTE] Release httpd-2.4.32

2018-03-12 Thread Joe Orton
On Fri, Mar 09, 2018 at 08:49:15PM -0600, Daniel Ruggeri wrote: > Hi, all; > >Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as

Re: Vote 2.4.32 and mod_md no valid Certificate Agreement directive

2018-03-12 Thread Stefan Eissing
> Am 12.03.2018 um 10:39 schrieb Luca Toscano : > > Hi Stefan! > > 2018-03-12 10:29 GMT+01:00 Stefan Eissing : > The recommended URL in our docs is wrong. The wrong one was introduced in > r1820464. > Supposedly as a fix to PR 35622. The

Re: Vote 2.4.32 and mod_md no valid Certificate Agreement directive

2018-03-12 Thread Luca Toscano
Hi Stefan! 2018-03-12 10:29 GMT+01:00 Stefan Eissing : > The recommended URL in our docs is wrong. The wrong one was introduced in > r1820464. > Supposedly as a fix to PR 35622. The proposed patch in the PR 35622 however > carries the correct URL. Not sure how that

Re: Vote 2.4.32 and mod_md no valid Certificate Agreement directive

2018-03-12 Thread Stefan Eissing
The recommended URL in our docs is wrong. The wrong one was introduced in r1820464. Supposedly as a fix to PR 35622. The proposed patch in the PR 35622 however carries the correct URL. Not sure how that happened. It should be changed in the docs. However: The *really* correct URL, however, is