Re: [VOTE] Release httpd-2.4.54-rc2 as httpd-2.4.54

2022-06-04 Thread Noel Butler
On 05/06/2022 06:21, Eric Covener wrote: On Sat, Jun 4, 2022 at 4:17 PM John Doe wrote: Hi, Eric's fix did not fix because I'm building with APR 1.7.0. In apr.hw 1.7.0 there is /* If we have a TCP implementation that can be "corked", what flag * do we use? */ #define APR_TCP_NOPUSH_FLAG

Re: [VOTE] Release httpd-2.4.54-rc2 as httpd-2.4.54

2022-06-04 Thread Eric Covener
On Sat, Jun 4, 2022 at 4:17 PM John Doe wrote: > > Hi, > Eric's fix did not fix because I'm building with APR 1.7.0. > > In apr.hw 1.7.0 there is > /* If we have a TCP implementation that can be "corked", what flag > * do we use? > */ > #define APR_TCP_NOPUSH_FLAG @apr_tcp_nopush_flag@ > >

Re: [VOTE] Release httpd-2.4.54-rc2 as httpd-2.4.54

2022-06-04 Thread John Doe
Hi, Eric's fix did not fix because I'm building with APR 1.7.0. In apr.hw 1.7.0 there is /* If we have a TCP implementation that can be "corked", what flag * do we use? */ #define APR_TCP_NOPUSH_FLAG @apr_tcp_nopush_flag@ /* Is the TCP_NODELAY socket option inherited from listening socket

Re: [VOTE] Release httpd-2.4.54-rc2 as httpd-2.4.54

2022-06-04 Thread Eric Covener
On Sat, Jun 4, 2022 at 8:59 AM Stefan Eissing wrote: > > Hi all, > > next attempt at 2.5.54. Thanks everyone for participating! > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few day

[VOTE] Release httpd-2.4.54-rc2 as httpd-2.4.54

2022-06-04 Thread Stefan Eissing
Hi all, next attempt at 2.5.54. Thanks everyone for participating! Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.54-rc2 as 2.4.54: [ ] +1

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread Stefan Eissing
This vote is cancelled due to build problems under Windows. I'll create a rc2 candidate and post that for voting soon. Thanks everyone. > Am 03.06.2022 um 16:57 schrieb Stefan Eissing : > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread Stefan Eissing
> Am 04.06.2022 um 14:08 schrieb Eric Covener : > > 2.4.x ready to reroll Nice! Thanks Eric. Will roll an rc2 in a few minutes. Cheers, Stefan > > On Sat, Jun 4, 2022 at 7:36 AM Eric Covener wrote: >> >> On Sat, Jun 4, 2022 at 7:11 AM Stefan Eissing wrote: >>> >>> How is the definition

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread Eric Covener
2.4.x ready to reroll On Sat, Jun 4, 2022 at 7:36 AM Eric Covener wrote: > > On Sat, Jun 4, 2022 at 7:11 AM Stefan Eissing wrote: > > > > How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my > > macOS it is: > > > > #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH > > > > It m

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread Eric Covener
On Sat, Jun 4, 2022 at 7:11 AM Stefan Eissing wrote: > > How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my > macOS it is: > > #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH > > It maybe that the added lines > > #if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__) > > needs a chec

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread Steffen
No apr.h in httpd/include. In APR yes, but not the line you mention. I am going out of town now. Monday again. Maybe Gregg can chime in. > Op 4 jun. 2022 om 13:18 heeft Stefan Eissing het > volgende geschreven: > > How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? O

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread Stefan Eissing
How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my macOS it is: #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH It maybe that the added lines #if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__) needs a check for Windows too? > Am 04.06.2022 um 12:49 schrieb SteffenAL : > > r1

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread SteffenAL

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread SteffenAL

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread Stefan Eissing
> Am 04.06.2022 um 11:23 schrieb SteffenAL : > > -1 > > Does not build : > > Error C2018 C:\VC16\Win32\httpd-2.4\server\core_filters.c > 638 unknown character '0x40' Hmm, 0x40 would be ‘@‘ and on line 638 there is none. Could you find out more what the offending cod

Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54

2022-06-04 Thread SteffenAL
-1 Does not build : Error C2018 C:\VC16\Win32\httpd-2.4\server\core_filters.c 638 unknown character '0x40' On Friday 03/06/2022 at 16:57, Stefan Eissing wrote: Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/ht