Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Yann Ylavic
On Wed, Jun 19, 2024 at 4:34 PM Yann Ylavic wrote: > > On Wed, Jun 19, 2024 at 4:23 PM Joe Orton wrote: > > > > On Wed, Jun 19, 2024 at 03:41:06PM +0200, Yann Ylavic wrote: > > > Done in PR 454, will update STATUS too. > > > > In the path where keep_addr_alive and keep_conn_alive are both false,

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Yann Ylavic
On Wed, Jun 19, 2024 at 4:23 PM Joe Orton wrote: > > On Wed, Jun 19, 2024 at 03:41:06PM +0200, Yann Ylavic wrote: > > Done in PR 454, will update STATUS too. > > In the path where keep_addr_alive and keep_conn_alive are both false, > conn_cleanup(conn) is run, which sets conn->address = NULL, and

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Joe Orton
On Wed, Jun 19, 2024 at 03:41:06PM +0200, Yann Ylavic wrote: > Done in PR 454, will update STATUS too. In the path where keep_addr_alive and keep_conn_alive are both false, conn_cleanup(conn) is run, which sets conn->address = NULL, and then running proxy_address_cleanup() leads to a NULL

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Yann Ylavic
On Wed, Jun 19, 2024 at 2:52 PM Joe Orton wrote: > > On Wed, Jun 19, 2024 at 02:04:20PM +0200, Yann Ylavic wrote: > > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote: > > > As far as I read the code it does not. > > > > > >

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Yann Ylavic
On Wed, Jun 19, 2024 at 2:49 PM Ruediger Pluem wrote: > > On 6/19/24 2:04 PM, Yann Ylavic wrote: > > > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote: > >> > >> As far as I read the code it does not. > >> > >>

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Joe Orton
On Wed, Jun 19, 2024 at 02:04:20PM +0200, Yann Ylavic wrote: > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote: > > As far as I read the code it does not. > > > > https://github.com/apache/apr/blob/b0a08c76ceacc2308d7cf1d5a7bb3c9b4665a432/network_io/unix/sockets.c#L423-L433 > > > > We copy

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Ruediger Pluem
On 6/19/24 2:04 PM, Yann Ylavic wrote: > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote: >> >> On 6/19/24 12:00 PM, Yann Ylavic wrote: >>> On Wed, Jun 19, 2024 at 9:07 AM Ruediger Pluem wrote: On 6/18/24 4:20 PM, yla...@apache.org wrote: > > +/* Release the

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Yann Ylavic
On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote: > > On 6/19/24 12:00 PM, Yann Ylavic wrote: > > On Wed, Jun 19, 2024 at 9:07 AM Ruediger Pluem wrote: > >> > >> On 6/18/24 4:20 PM, yla...@apache.org wrote: > >>> > >>> +/* Release the old conn address */ > >>> +if

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Ruediger Pluem
On 6/19/24 12:00 PM, Yann Ylavic wrote: > On Wed, Jun 19, 2024 at 9:07 AM Ruediger Pluem wrote: >> >> On 6/18/24 4:20 PM, yla...@apache.org wrote: >>> >>> +/* Release the old conn address */ >>> +if (conn->address) { >>> +/* conn->address->addr cannot be

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Yann Ylavic
On Wed, Jun 19, 2024 at 9:07 AM Ruediger Pluem wrote: > > On 6/18/24 4:20 PM, yla...@apache.org wrote: > > > > +/* Release the old conn address */ > > +if (conn->address) { > > +/* conn->address->addr cannot be released while it's used > > by > > +

Re: svn commit: r1918412 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2024-06-19 Thread Ruediger Pluem
On 6/18/24 4:20 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Jun 18 14:20:06 2024 > New Revision: 1918412 > > URL: http://svn.apache.org/viewvc?rev=1918412=rev > Log: > mod_proxy: Keep connection alive on addressTTL expiry if the DNS didn't > change. > > *