Re: [PATCH]: Counting I/O with FLUSH and OFN (no MMN bump)

2002-10-25 Thread Bojan Smojver
On Fri, 2002-10-25 at 17:01, Brian Pane wrote: > Tested and committed. Thanks! Thanks. Bojan

Re: [PATCH]: Counting I/O with FLUSH and OFN (no MMN bump)

2002-10-24 Thread Brian Pane
On Thu, 2002-10-24 at 19:48, Bojan Smojver wrote: > Brian, Bill, > > This is what I meant by my previous comment about core_pre_connection v. > core_post_config and the optional function fetching. I have tested this and it > worked even after a graceful restart and when I killed all child processe

Re: [PATCH]: Counting I/O with FLUSH and OFN (no MMN bump)

2002-10-24 Thread Bojan Smojver
Brian, Bill, This is what I meant by my previous comment about core_pre_connection v. core_post_config and the optional function fetching. I have tested this and it worked even after a graceful restart and when I killed all child processes manually. I'm using prefork on Linux. This patch should b

Re: [PATCH]: Counting I/O with FLUSH and OFN (no MMN bump)

2002-10-24 Thread Bojan Smojver
Very cool. Thanks. Bojan On Fri, 2002-10-25 at 08:28, Brian Pane wrote: > Bojan Smojver wrote: > > >This should really work now and it should not cause major dramas > >compatibility wise. Let me know what you think. > > > > > > Thanks, I'll take a look at this tonight unless anyone else > get

Re: [PATCH]: Counting I/O with FLUSH and OFN (no MMN bump)

2002-10-24 Thread Brian Pane
Bojan Smojver wrote: This should really work now and it should not cause major dramas compatibility wise. Let me know what you think. Thanks, I'll take a look at this tonight unless anyone else gets to it first. Brian

Re: [PATCH]: Counting I/O with FLUSH and OFN (no MMN bump)

2002-10-24 Thread Bojan Smojver
Just two extra spaces so it's looks nicer... Bojan On Fri, 2002-10-25 at 08:11, Bojan Smojver wrote: > This should really work now and it should not cause major dramas > compatibility wise. Let me know what you think. diff -ruN httpd-2.0-vanilla/include/http_core.h httpd-2.0/include/http_core.h

[PATCH]: Counting I/O with FLUSH and OFN (no MMN bump)

2002-10-24 Thread Bojan Smojver
This should really work now and it should not cause major dramas compatibility wise. Let me know what you think. Bojan diff -ruN httpd-2.0-vanilla/include/http_core.h httpd-2.0/include/http_core.h --- httpd-2.0-vanilla/include/http_core.h Tue Oct 15 03:42:45 2002 +++ httpd-2.0/include/http_core.h

Re: [PATCH] Counting I/O with FLUSH w/o MMN bump

2002-10-22 Thread Bojan Smojver
Quoting Bojan Smojver <[EMAIL PROTECTED]>: > The apr_socket_t *csd is the first field of the core_conn_conf > structure, so old modules that pick it up as a single pointer should > still find the thing in exactly the same place. Unless the new alignment > (which should be the same as before) or so

Re: [PATCH] Counting I/O with FLUSH w/o MMN bump

2002-10-22 Thread Bojan Smojver
On Tue, 2002-10-22 at 17:50, Bojan Smojver wrote: > Although the subject claims no MMN bump and the patch doesn't have one, I'm not > sure if that's at all realistic. Just one clarification on the "realistic" business... The apr_socket_t *csd is the first field of the core_conn_conf structure, so

[PATCH] Counting I/O with FLUSH w/o MMN bump

2002-10-22 Thread Bojan Smojver
Although the subject claims no MMN bump and the patch doesn't have one, I'm not sure if that's at all realistic. The patch does compile and it does work, so at least something is good about it :-) Give it a whirl, tell me what you think and where do we go from here... Bojan diff -ur httpd-2.0-van

Re: [PATCH]: Counting I/O with FLUSH

2002-10-21 Thread Bojan Smojver
Quoting Brian Pane <[EMAIL PROTECTED]>: > >The core would also have to know about logio_config_t, which doesn't also > >doesn't make sense. I would rather have it the other way around. > > > > I agree--better to add a struct in the core and make mod_logio > depend on that than to require the core

Re: [PATCH]: Counting I/O with FLUSH

2002-10-21 Thread Bojan Smojver
Quoting Brian Pane <[EMAIL PROTECTED]>: > As for the MMN bump, IMHO it would be better to code the > patch in a way that doesn't require it (if I remember correctly, > you had an alternate solution involving a module-specific > structure instead of new fields in conn_rec). That would > make it ea

Re: [PATCH]: Counting I/O with FLUSH

2002-10-21 Thread Brian Pane
On Sun, 2002-10-20 at 14:24, Bojan Smojver wrote: > Sorry to be a pest (no, not really :-)... > > Would this patch have more chance if it didn't involve an MMN bump? If > so, let me know and I'll rework it... >From your description of the patch, I'm +1 on the concept (though I haven't had time to

Re: [PATCH]: Counting I/O with FLUSH

2002-10-21 Thread Bojan Smojver
Thanks Brian. I appreciate your input. Bojan On Tue, 2002-10-22 at 04:11, Brian Pane wrote: > >I'll rework the patch to include the structure structure in core.c rather then > >one in mod_logio.c. Does that sound OK? > > > > Sounds good to me > > >The core would also have to know about logio_c

Re: [PATCH]: Counting I/O with FLUSH

2002-10-21 Thread Brian Pane
Bojan Smojver wrote: Quoting Brian Pane <[EMAIL PROTECTED]>: As for the MMN bump, IMHO it would be better to code the patch in a way that doesn't require it (if I remember correctly, you had an alternate solution involving a module-specific structure instead of new fields in conn_rec). That

Re: [PATCH]: Counting I/O with FLUSH

2002-10-20 Thread Bojan Smojver
Sorry to be a pest (no, not really :-)... Would this patch have more chance if it didn't involve an MMN bump? If so, let me know and I'll rework it... Bojan

Re: [PATCH]: Counting I/O with FLUSH

2002-10-16 Thread Bojan Smojver
Quoting Bojan Smojver <[EMAIL PROTECTED]>: > I'm using Mozilla 1.0.1, which support pipelining Damn Mozilla... It didn't actually pipeline the requests :-( So, I switched to telnet and discovered that there is a MAJOR difference in results with and without the FLUSH filter (which is kinda the p

Re: [PATCH]: Counting I/O with FLUSH

2002-10-16 Thread Bojan Smojver
I'm doing some testing with and without this new filter that replaces EOS with FLUSH. Here is the test HTML file: - ... - First, the bad news - I'm using Mozilla 1.0.1, which support pipelining, but I can't make Apache send

[PATCH]: Counting I/O with FLUSH

2002-10-16 Thread Bojan Smojver
OK, this is my first "official" attempt at this. The basic idea is to replace the EOS bucket at the end of the brigade with a FLUSH bucket, so that each request is flushed down the pipe. I'm guessing this will completely break pipelining if mod_logio is enabled, but, as someone mentioned, this is