Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Cliff Woolley
On Tue, 4 Sep 2001, Justin Erenkrantz wrote: > All uppercase. 6 of one, half-dozen of the other. -- justin I'll take the 6. I like this a whole lot better. Thanks, Justin. :) --Cliff -- Cliff Woolley [EMAIL PROTECTED] Ch

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Greg Stein
On Tue, Sep 04, 2001 at 12:08:36PM -0700, Justin Erenkrantz wrote: > Both Cliff and OtherBill sent me emails complaining about the > change to strcasecmp in some places to support Brian Pane's > new hash code in util_filter.c. (Never mind that a lot of > the code already did strcasecmp...) IMO,

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Justin Erenkrantz
All uppercase. 6 of one, half-dozen of the other. -- justin Index: ./modules/experimental/mod_charset_lite.c === RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_charset_lite.c,v retrieving revision 1.51 diff -u -r1.51 mod_ch

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Brian Pane
Ryan Bloom wrote: >On Tuesday 04 September 2001 15:26, Brian Pane wrote: > >>Justin Erenkrantz wrote: >> >>>Both Cliff and OtherBill sent me emails complaining about the >>>change to strcasecmp in some places to support Brian Pane's >>>new hash code in util_filter.c. (Never mind that a lot of >>

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Ryan Bloom
On Tuesday 04 September 2001 15:26, Brian Pane wrote: > Justin Erenkrantz wrote: > >Both Cliff and OtherBill sent me emails complaining about the > >change to strcasecmp in some places to support Brian Pane's > >new hash code in util_filter.c. (Never mind that a lot of > >the code already did str

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Ryan Bloom
On Tuesday 04 September 2001 12:08, Justin Erenkrantz wrote: Wouldn't this be a much cleaner patch if we went to upper case instead of lower-case? I realize that is a detail, but currently, most of the filters are registered as upper case, so we would have fewer places to modify. Ryan > Both C

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Brian Pane
Justin Erenkrantz wrote: >Both Cliff and OtherBill sent me emails complaining about the >change to strcasecmp in some places to support Brian Pane's >new hash code in util_filter.c. (Never mind that a lot of >the code already did strcasecmp...) > >This patch makes the filter name lowercase for

[PATCH] Make filter names lowercase

2001-09-04 Thread Justin Erenkrantz
Both Cliff and OtherBill sent me emails complaining about the change to strcasecmp in some places to support Brian Pane's new hash code in util_filter.c. (Never mind that a lot of the code already did strcasecmp...) This patch makes the filter name lowercase for the searches and lets us use str