From: "Ian Holsman" <[EMAIL PROTECTED]>
Sent: Thursday, September 06, 2001 9:36 AM
> On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote:
> >
> > The map_to_storage hook should be an optimization that I want to use, not
> > a requirement that I HAVE to use.
> >
>
> you don't need to use it. look at
On Thursday 06 September 2001 11:54, Bill Stoddard wrote:
> > On Thursday 06 September 2001 09:36, Ian Holsman wrote:
> > > On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote:
> > > > > > I have some big problems with the way that location walk and
> > > > > > directory walk work now, BTW, because if I
> On Thursday 06 September 2001 09:36, Ian Holsman wrote:
> > On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote:
> > > > > I have some big problems with the way that location walk and
> > > > > directory walk work now, BTW, because if I write a module that
> > > > > doesn't get pages from the filesys
On Wed, 2001-09-05 at 19:11, Justin Erenkrantz wrote:
> On Wed, Sep 05, 2001 at 06:46:45PM -0700, Brian Pane wrote:
> > Justin Erenkrantz wrote:
> > [...]
getting back to the original patch
to find_start_sequence.
does anyone have any comments on this?
I'm seeing lower CPU utilization when using
On Thursday 06 September 2001 09:36, Ian Holsman wrote:
> On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote:
> > > > I have some big problems with the way that location walk and
> > > > directory walk work now, BTW, because if I write a module that
> > > > doesn't get pages from the filesystem, I have
On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote:
>
> > > I have some big problems with the way that location walk and directory
> > > walk work now, BTW, because if I write a module that doesn't get pages
> > > from the filesystem, I have to catch those in the map_to_storage hook,
> > > or the serv
Ryan Bloom wrote:
>>>I have some big problems with the way that location walk and directory
>>>walk work now, BTW, because if I write a module that doesn't get pages
>>>from the filesystem, I have to catch those in the map_to_storage hook,
>>>or the server will 500.
>>>
>>Hmm... I'd have thought
On Thu, 6 Sep 2001, Ryan Bloom wrote:
> > Hmm... I'd have thought that was the whole point of the map_to_storage
> > hook, if its name were any indication...
>
> It is, but if I am just putting together a quick module, to solve a
> problem and it generates the page itself, all I should have to
> > I have some big problems with the way that location walk and directory
> > walk work now, BTW, because if I write a module that doesn't get pages
> > from the filesystem, I have to catch those in the map_to_storage hook,
> > or the server will 500.
>
> Hmm... I'd have thought that was the who
On Thu, 6 Sep 2001, Ryan Bloom wrote:
> I actually hit this same seg fault in mod_jk late last night. If
> mod_include is changed to fix this, then we are most likely doing it
> wrong, and I will veto that.
My point exactly.
> The first step is to set r->uri to NULL if it is INTERNALLY GENERAT
On Wednesday 05 September 2001 20:24, Cliff Woolley wrote:
> On Wed, 5 Sep 2001, john sachs wrote:
> > i applied this patch and the mod_include test fails in the same spot
> > as it has been. content file has:
> >
> > 'include file' with relative path to file not in same path as the file
> > you
On Wed, 5 Sep 2001, john sachs wrote:
> i applied this patch and the mod_include test fails in the same spot
> as it has been. content file has:
>
> 'include file' with relative path to file not in same path as the file
> you are requesting.
Yep. This patch has no effect on that. It's probabl
On Wed, Sep 05, 2001 at 06:42:10PM -0700, john sachs wrote:
> i applied this patch and the mod_include test fails in the same spot as it has been.
> content file has:
>
>
> 'include file' with relative path to file not in same path as the file you are
>requesting.
Well, in my defense, my patch
Justin Erenkrantz wrote:
[...]
>Actually, I think the conditional should be:
>
>while (p <= he)
>
>Thoughts? We're scanning R->L, so p points to the end of the string.
>It is possible to have "
john sachs wrote:
> i applied this patch and the mod_include test fails in the same spot as it has been.
> content file has:
> +
Hi John.
This patch was not intended to fix this problem,
it was intended to speed up the 'finding' of the '"
or "<
On Wed, Sep 05, 2001 at 07:15:13PM -0700, Justin Erenkrantz wrote:
> Actually, I think the conditional should be:
>
> while (p <= he)
>
> Thoughts? We're scanning R->L, so p points to the end of the string.
> It is possible to have "
On Wed, Sep 05, 2001 at 07:11:37PM -0700, Justin Erenkrantz wrote:
> On Wed, Sep 05, 2001 at 06:46:45PM -0700, Brian Pane wrote:
> > Justin Erenkrantz wrote:
> > [...]
> >
> > >+/* Implements the BNDM search algorithm (as described above).
> > >+ *
> > >+ * n - the pattern to search for
> > >+ *
On Wed, Sep 05, 2001 at 06:46:45PM -0700, Brian Pane wrote:
> Justin Erenkrantz wrote:
> [...]
>
> >+/* Implements the BNDM search algorithm (as described above).
> >+ *
> >+ * n - the pattern to search for
> >+ * nl - length of the pattern to search for
> >+ * h - the string to look in
> >+ *
Justin Erenkrantz wrote:
[...]
>+/* Implements the BNDM search algorithm (as described above).
>+ *
>+ * n - the pattern to search for
>+ * nl - length of the pattern to search for
>+ * h - the string to look in
>+ * hl - length of the string to look for
>+ * t - precompiled bndm structure aga
i applied this patch and the mod_include test fails in the same spot as it has been.
content file has:
'include file' with relative path to file not in same path as the file you are
requesting.
causes segv. here is stacktrace:
#0 0x80c4056 in ap_getparents (
name=0x816a840 "INTERNALLY G
Okay, I've cleaned this up and I think it is ready for commit.
However, I'd really like some eyes on this. =-)
In Ian and Brian's testing, this does seem to make mod_include
faster. I can't guarantee that there aren't any bugs here,
but I've tested it with what I have and looked at the code a
21 matches
Mail list logo
