Another one. Can we get a vote?
Sorry to be a pest, just don't want these to be forgotten.
Brian Akins wrote:
Here's a new patch that changes the option name to CacheVaryOverride and
does some of the stuff Justin recommened.
[EMAIL PROTECTED] wrote:
What sort of testing did you do in those few hours?
That's why I posted it, to get some more input.
If I could play devil's advocate for a moment... my concern would be that
you haven't considered certain scenarios that won't work with this patch.
Most of the
Here's a new patch that changes the option name to CacheVaryOverride and
does some of the stuff Justin recommened.
--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies
diff -ru httpd-trunk.orig/modules/cache/cache_storage.c
httpd-trunk.new/modules/cache/cache_storage.c
---
This patch allows one to override the values of some headers so that they
vary to the same value.
Config Example:
#all lines that have gzip set one variable
SetEnvIf Accept-Encoding gzip gzip=1
#browsers that have problems with gzip
BrowserMatch MSIE [1-3] gzip=0
BrowserMatch MSIE [1-5].*Mac
Akins, Brian wrote:
This patch allows one to override the values of some headers so that they
vary to the same value.
CacheOverrideHeader Accept-Encoding gzip
CacheOverrideHeader User-Agent gzip
Very useful looking. I suggest CacheVaryOverride as a much more clear
and precise name.
--On August 17, 2005 3:01:03 PM -0400 Akins, Brian
[EMAIL PROTECTED] wrote:
This patch allows one to override the values of some headers so that they
vary to the same value.
Config Example:
# all lines that have gzip set one variable
SetEnvIf Accept-Encoding gzip gzip=1
# browsers that have
Justin Erenkrantz wrote:
The concept is fine. (And as Joshua pointed out 'CacheVaryOverride'
would be a better name.)
I'm not attatched to the name. So that sounds good to me.
A few issues with the implementation (modulo style nits)...
This was all done in a few hours today, including
In a message dated 8/17/2005 2:01:41 PM Central Daylight Time,
[EMAIL PROTECTED] writes:
CacheOverrideHeader Accept-Encoding gzip CacheOverrideHeader User-Agent gzip
This would allow all browsers that send "Accept-Encoding: gzip" and do not match the BrowserMatches to be mapped to the same
