On Wed, Mar 16, 2016 at 3:58 AM, Stefan Eissing <
stefan.eiss...@greenbytes.de> wrote:
> Hmm, I can tell you for certain that modules encountering HTTP/2
> connections
> in 2.4 do not find the filters as they may expect.
>
Right, that's by design. Existing protocol modules assume a particular
st
On 16 Mar 2016, at 5:57 AM, William A Rowe Jr wrote:
> My concern is that this can't and shouldn't change on 2.4.x.
>
> I love the concept and it is correct, however there are enough modules relying
> on the fact that they must remove the http protocol filters that changing the
> default behavio
On Tue, 2016-03-15 at 22:57 -0500, William A Rowe Jr wrote:
> My concern is that this can't and shouldn't change on 2.4.x.
> Thoughts?
If someone is independently using a different protocol,
or has just tweaked HTTP handling for their own reasons,
they could be using hacks/workarounds this'll bre
Hmm, I can tell you for certain that modules encountering HTTP/2 connections
in 2.4 do not find the filters as they may expect.
So far, I have not heard of any breakage related to this. Which is not to say
it does not exist.
AFAIK the patch will only affect connections where ap_get_protocol() re
On 03/16/2016 04:57 AM, William A Rowe Jr wrote:
> My concern is that this can't and shouldn't change on 2.4.x.
>
> I love the concept and it is correct, however there are enough modules relying
> on the fact that they must remove the http protocol filters that changing the
> default behavior is
My concern is that this can't and shouldn't change on 2.4.x.
I love the concept and it is correct, however there are enough modules
relying
on the fact that they must remove the http protocol filters that changing
the
default behavior is effectively breaking binary ABI.
Thoughts?
Cheers,
Bill
Hi all,
The following patch fixes the problem where the HTTP1 filters are added on non
HTTP1 requests.
The filters are now only added if ap_get_protocol() returns AP_PROTOCOL_HTTP1.
Regards,
Graham
--
Index: modules/http/http_core.c
=
