Re: 1.3.24-dev new warning...

2002-03-20 Thread Chuck Murcko
There are two other places in mod_proxy the MIN macro gets used. Shouldn't those get cast to the desired return type as well? This one's a time_t: proxy_cache.c line 1175 maxage = MIN(maxage_req, maxage_cresp); and this one's a size_t: proxy_util.c line 734 strncpy(valbuf, list, MIN(p-list, s

Re: 1.3.24-dev new warning...

2002-03-20 Thread Chuck Murcko
OK, I'll fix and commit this tonight. Chuck On Friday, April 19, 2002, at 02:07 PM, William A. Rowe, Jr. wrote: > At 10:03 AM 3/19/2002, you wrote: >> At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: >> >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) >> > : warning C4018: '<' : s

Re: 1.3.24-dev new warning...

2002-03-19 Thread Jim Jagielski
I thought the problem was the type mismatch between the args of the MIN (one unsigned, the other not). William A. Rowe, Jr. wrote: > > At 10:03 AM 3/19/2002, you wrote: > >At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: > > >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) > > > :

Re: 1.3.24-dev new warning...

2002-03-19 Thread Greg Marr
At 01:07 PM 04/19/2002, William A. Rowe, Jr. wrote: >At 10:03 AM 3/19/2002, you wrote: >>At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: >> >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) >> > : warning C4018: '<' : signed/unsigned mismatch >> > >> >n = ap_bread(f, buf,

Re: 1.3.24-dev new warning...

2002-03-19 Thread William A. Rowe, Jr.
At 10:03 AM 3/19/2002, you wrote: >At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: > >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) > > : warning C4018: '<' : signed/unsigned mismatch > > > >n = ap_bread(f, buf, MIN(buf_size, len - total_bytes_rcvd)); > >I had posted a

Re: 1.3.24-dev new warning...

2002-03-19 Thread Jim Jagielski
At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) > : warning C4018: '<' : signed/unsigned mismatch > >n = ap_bread(f, buf, MIN(buf_size, len - total_bytes_rcvd)); > >Whoever is hacking in proxy, feel free to correct. > >[Th

Re: 1.3.24-dev new warning...

2002-03-08 Thread Jim Jagielski
At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) > : warning C4018: '<' : signed/unsigned mismatch > >n = ap_bread(f, buf, MIN(buf_size, len - total_bytes_rcvd)); > >Whoever is hacking in proxy, feel free to correct. > >[Th

Re: 1.3.24-dev new warning...

2002-03-08 Thread Jim Jagielski
At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote: >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) > : warning C4018: '<' : signed/unsigned mismatch > >n = ap_bread(f, buf, MIN(buf_size, len - total_bytes_rcvd)); > >Whoever is hacking in proxy, feel free to correct. > >[Th

1.3.24-dev new warning...

2002-03-07 Thread William A. Rowe, Jr.
C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565) : warning C4018: '<' : signed/unsigned mismatch n = ap_bread(f, buf, MIN(buf_size, len - total_bytes_rcvd)); Whoever is hacking in proxy, feel free to correct. [The only other emits according to win32 are FD_SET obscurity.]