patch for trunk:
Index: htdbm.c
===
--- htdbm.c(revision 526861)
+++ htdbm.c(working copy)
@@ -69,7 +69,7 @@
#define ALG_APMD5 1
#define ALG_APSHA 2
-#if APR_HAVE_CRYPT_H
+#if (!(defined(WIN32) || defined(TPF) ||
On 4/9/07, David Jones [EMAIL PROTECTED] wrote:
patch for trunk:
thanks; committed
I'll propose for backport to 2.2.x shortly.
On 3/23/07, David Jones [EMAIL PROTECTED] wrote:
ok here's the simple patch at the 2.0.x level that just checks platforms for
htdbm.c
Can you post a post to htdbm.c at trunk?
On 4/4/07, Jeff Trawick [EMAIL PROTECTED] wrote:
On 3/23/07, David Jones [EMAIL PROTECTED] wrote:
ok here's the simple patch at the 2.0.x level that just checks platforms for
htdbm.c
Can you post a post to htdbm.c at trunk?
whoops, make that Can you post a PATCH...
ok here's the simple patch at the 2.0.x level that just checks platforms for
htdbm.c
Also appended is the semi-related patch for htpasswd.c that adds TPF to the
platforms checked in 2 cases where its missed, which seems like an
oversight.
David Jones wrote:
ok here's the simple patch at the 2.0.x level that just checks platforms
for htdbm.c
Also appended is the semi-related patch for htpasswd.c that adds TPF to
the platforms checked in 2 cases where its missed, which seems like an
oversight.
+1
Re: Jeff's last note, yes httpd does call crypt() directly,
Any other questions that need discussion / resolution?
David Jones
--
[EMAIL PROTECTED]
On 3/16/07, Jeff Trawick [EMAIL PROTECTED] wrote:
On 3/16/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
Jeff Trawick wrote:
APR
httpd does not ;-)
htdbm/htpasswd et al do.
Bill
[httpd-2.2]$ grep -r crypt modules/aaa/*
[httpd-2.2]$ grep -r apr_password modules/aaa/*
modules/aaa/mod_auth_basic.c:#include apr_md5.h/* for
apr_password_validate */
modules/aaa/mod_authn_dbd.c:rv =
On 3/20/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
httpd does not ;-)
httpd the project (vs. apr, apr-util), not httpd the program (vs.
htdbm, htpasswd)
as in In httpd, we don't call crypt(), we call APR...
Jeff Trawick wrote:
On 3/20/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
httpd does not ;-)
httpd the project (vs. apr, apr-util), not httpd the program (vs.
htdbm, htpasswd)
as in In httpd, we don't call crypt(), we call APR...
So... what I suggest is;
1. use the same test from
William A. Rowe, Jr. wrote:
Jeff Trawick wrote:
On 3/20/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
httpd does not ;-)
httpd the project (vs. apr, apr-util), not httpd the program (vs.
htdbm, htpasswd)
as in In httpd, we don't call crypt(), we call APR...
So... what I suggest is;
Nope - it won't. Where does z/OS define the crypt() prototype?
The correct patch is to ask APR_HAS_CRYPT (which we need to provide
by patching apr, if we don't already.)
If APR didn't detect crypt, adding crypt() style p/w's to htdbm,
htpasswd etc will still be a noop.
Bill
David Jones wrote:
On 3/16/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
Nope - it won't. Where does z/OS define the crypt() prototype?
unistd.h is the common place, z/OS or not.
http://www.opengroup.org/onlinepubs/007908799/xsh/crypt.html
Apparently crypt_r() is often defined in crypt.h but not in
Jeff Trawick wrote:
APR doesn't pretend to figure out for APR apps exactly what the system
provides, though there is currently a spotty set of APR_HAS_foo.
Meanwhile, httpd goes and searches on its own for things APR doesn't
tell anyone about. I'm curious about other opinions on whether
On 3/16/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
Jeff Trawick wrote:
APR doesn't pretend to figure out for APR apps exactly what the system
provides, though there is currently a spotty set of APR_HAS_foo.
Meanwhile, httpd goes and searches on its own for things APR doesn't
tell
15 matches
Mail list logo
