On 05.06.2010 21:44, Rainer Jung wrote:
During the build I also noticed, that mod_lua has two lines, where it
doesn't use APLOG_MARK but instead directly passes two file/line args
along.
Patch along the lines of the mod_ssl solution:
On Saturday 05 June 2010, Rainer Jung wrote:
It doesn't compile, two small problems, both in
include/http_config.h:
During the build I also noticed, that mod_lua has two lines, where
it doesn't use APLOG_MARK but instead directly passes two
file/line args along.
Thanks. It seems I haven't
On 04.06.2010 23:57, Stefan Fritsch wrote:
On Friday 04 June 2010, Stefan Fritsch wrote:
which are either pure bug fixes or pretty trivial. I will create a
new patch series without these soon, hopefully tomorrow.
The next iteration is at
http://people.apache.org/~sf/per-module-loglevel-v5/
On Wed, Jun 02, 2010 at 10:42:44PM +0200, Stefan Fritsch wrote:
The patch is at
http://people.apache.org/~sf/per-module-loglevel-v4/ ,
This looks good to me. Kudos for taking on such a task. It's kind of
hard to review the individual patches with fixes-on-fixes separated out,
or the
-Original Message-
From: Joe Orton
Sent: Freitag, 4. Juni 2010 13:29
To: dev@httpd.apache.org
Subject: Re: Per-module / per-dir loglevel configuration version 4
On Wed, Jun 02, 2010 at 10:42:44PM +0200, Stefan Fritsch wrote:
The patch is at
http://people.apache.org
On Fri, Jun 04, 2010 at 01:40:42PM +0200, Plüm, Rüdiger, VF-Group wrote:
memset(l-module_levels, val, total_modules +
DYNAMIC_MODULE_LIMIT);
Hm, module_levels is int[] and memset works byte wise.
Doh. Sorry, yes, ignore me there.
On Friday 04 June 2010, William A. Rowe Jr. wrote:
This seems to be a very good solution, and the fact that their are
no constructor-time calls to initialize this should avoid any
platform quirks.
My only question is; are we assured to have the same module_index
reassigned on each
On 6/4/2010 4:47 PM, Stefan Fritsch wrote:
Since we are only initializing a pointer into the module struct, it
really does not matter if the module_index changes or not. If the
module is not reloaded, the address of the module struct stays the
same. If the module is reloaded, the pointer
On Friday 04 June 2010, Stefan Fritsch wrote:
which are either pure bug fixes or pretty trivial. I will create a
new patch series without these soon, hopefully tomorrow.
The next iteration is at
http://people.apache.org/~sf/per-module-loglevel-v5/
I have included Rainer's and Joe's
On Wednesday 02 June 2010, Stefan Fritsch wrote:
I have updated my patch to the latest trunk and to use the variant
where the module for logging is selected with APLOG_USE_MODULE and
AP_DECLARE_MODULE macros:
APLOG_USE_MODULE(foo)
expands to
extern module AP_MODULE_DECLARE_DATA
On Thu, Jun 3, 2010 at 12:49 PM, Stefan Fritsch s...@sfritsch.de wrote:
On Wednesday 02 June 2010, Stefan Fritsch wrote:
I have updated my patch to the latest trunk and to use the variant
where the module for logging is selected with APLOG_USE_MODULE and
AP_DECLARE_MODULE macros:
On 03.06.2010 20:09, Jeff Trawick wrote:
On Thu, Jun 3, 2010 at 12:49 PM, Stefan Fritsch s...@sfritsch.de wrote:
This means, if some source file does not initialize aplog_module_index
with APLOG_USE_MODULE, logging will simply default to the global
loglevel. This works because static
On 02.06.2010 22:42, Stefan Fritsch wrote:
I have updated my patch to the latest trunk and to use the variant
where the module for logging is selected with APLOG_USE_MODULE and
AP_DECLARE_MODULE macros:
...
Multi-file modules have to use APLOG_USE_MODULE in the other
files.
The patch is at
On 6/3/2010 4:49 PM, Rainer Jung wrote:
Indentation in modules/proxy/mod_proxy.h whenever ap_log_error is
replaced by ap_log_rerror (argument indentation)
Can we start pre-committing some of these pieces which are simply bug fixes,
e.g. correcting the loglevel scope?
It will save on review
On Thursday 03 June 2010, Rainer Jung wrote:
The patch is at
http://people.apache.org/~sf/per-module-loglevel-v4/ ,
both as one file and as a series split into more or less logical
chunks. Comments are very welcome. Also, it would be nice if
someone could try it with a
On Friday 04 June 2010, William A. Rowe Jr. wrote:
On 6/3/2010 4:49 PM, Rainer Jung wrote:
Indentation in modules/proxy/mod_proxy.h whenever ap_log_error is
replaced by ap_log_rerror (argument indentation)
Can we start pre-committing some of these pieces which are simply
bug fixes, e.g.
On Thu, Jun 3, 2010 at 7:27 PM, Stefan Fritsch s...@sfritsch.de wrote:
which are either pure bug fixes or pretty trivial. I will create a new
patch series without these soon, hopefully tomorrow.
Appreciate your commitment to getting this in!
--
Eric Covener
cove...@gmail.com
On Thu, Jun 3, 2010 at 7:51 PM, Eric Covener cove...@gmail.com wrote:
On Thu, Jun 3, 2010 at 7:27 PM, Stefan Fritsch s...@sfritsch.de wrote:
which are either pure bug fixes or pretty trivial. I will create a new
patch series without these soon, hopefully tomorrow.
Appreciate your
On 6/3/2010 7:10 PM, Jeff Trawick wrote:
On Thu, Jun 3, 2010 at 7:51 PM, Eric Covener cove...@gmail.com
mailto:cove...@gmail.com wrote:
On Thu, Jun 3, 2010 at 7:27 PM, Stefan Fritsch s...@sfritsch.de
mailto:s...@sfritsch.de wrote:
which are either pure bug fixes or pretty
On 6/3/2010 11:49 AM, Stefan Fritsch wrote:
I have added two additional patches (filenames 10*) to fix a segfault.
In addition, I now have this in http_log.h:
#define APLOG_NO_MODULE -1
static int * const aplog_module_index;
#define APLOG_MODULE_INDEX \
Hi,
I have updated my patch to the latest trunk and to use the variant
where the module for logging is selected with APLOG_USE_MODULE and
AP_DECLARE_MODULE macros:
APLOG_USE_MODULE(foo)
expands to
extern module AP_MODULE_DECLARE_DATA foo_module;
static int * const
On Sunday 16 May 2010, Stefan Fritsch wrote:
On Saturday 15 May 2010, William A. Rowe Jr. wrote:
On 5/15/2010 8:03 AM, Stefan Fritsch wrote:
Yes, I think that's ok. In any case I would like to hide the
mod_foo.c from the user as far as possible and use the name of
the module struct
On Saturday 15 May 2010, William A. Rowe Jr. wrote:
On 5/15/2010 8:03 AM, Stefan Fritsch wrote:
Yes, I think that's ok. In any case I would like to hide the
mod_foo.c from the user as far as possible and use the name of
the module struct (minus the trailing _module). The LogLevel
On Friday 14 May 2010, Jeff Trawick wrote:
For selection by module, does the facility need to be more
granular than simply using the canonical source file name --
the name of the file that declares the module struct?
I am not sure what you mean. Somehow it must be clear what module
is
On 5/15/2010 8:03 AM, Stefan Fritsch wrote:
On Friday 14 May 2010, Jeff Trawick wrote:
For selection by module, does the facility need to be more
granular than simply using the canonical source file name --
the name of the file that declares the module struct?
I am not sure what you mean.
On Wed, May 5, 2010 at 3:28 PM, Stefan Fritsch s...@sfritsch.de wrote:
On Saturday 01 May 2010, Jeff Trawick wrote:
I would like to see some buy-in for the API changes. I don't have
any other concerns about committing. (Logging is such a part of
main-line that many more people will see the
On Saturday 01 May 2010, Jeff Trawick wrote:
I would like to see some buy-in for the API changes. I don't have
any other concerns about committing. (Logging is such a part of
main-line that many more people will see the changes in action
while working on other issues, giving ample
On Monday 12 April 2010, Jeff Trawick wrote:
attached are some compile fixes
Thanks Jeff, I will include those fixes in the next round of patches.
It seems I should enable more modules when doing my testing.
How to proceed with these patches? From the people who have looked at
them already,
On Sat, May 1, 2010 at 7:48 AM, Stefan Fritsch s...@sfritsch.de wrote:
On Monday 12 April 2010, Jeff Trawick wrote:
attached are some compile fixes
Thanks Jeff, I will include those fixes in the next round of patches.
It seems I should enable more modules when doing my testing.
How to
On Sun, Apr 11, 2010 at 7:16 AM, Stefan Fritsch s...@sfritsch.de wrote:
http://people.apache.org/~sf/per-module-loglevel-v3/
...
or the complete patch:
per-module-loglevel-v3.patch
attached are some compile fixes
(still looking, haven't tested yet)
patch
Description: Binary data
Hi,
here is the next version of the per-module loglevel patch. I have followed
Jeff's suggestion and, instead of defining APLOG_MODULE_INDEX pointing to
the module_index member of the module struct, I now define AP_MODULE_VAR
pointing to the module struct directly. http_log.h will #error if
31 matches
Mail list logo
