Re: Proxy Cookie Support (Bug #10722)

2004-06-26 Thread Dirk-Willem van Gulik
On Fri, 25 Jun 2004, Nick Kew wrote: OK, that's what I needed to know. I'll still have to modify my patch slightly to work with yours, but at least it's now clear what's going on. DO make sure that it is still possible for, say, mod_perl or mod_jk to remove/kill a coppy with an expired

Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Nick Kew
I recently patched bug 10722. My patch was against 2.0.49, for a Client who needed it in a hurry. I'm just porting it to 2.1-HEAD. In doing so, I find there's an existing patch that saves and restores cookies without rewriting the Domain and Path components. AFAICS my patch would/should

Re: Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Jim Jagielski
Nick Kew wrote: I recently patched bug 10722. My patch was against 2.0.49, for a Client who needed it in a hurry. I'm just porting it to 2.1-HEAD. In doing so, I find there's an existing patch that saves and restores cookies without rewriting the Domain and Path components. AFAICS my

Re: Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Joe Schaefer
Jim Jagielski [EMAIL PROTECTED] writes: Nick Kew wrote: [...] It appears just to merge Set-Cookie headers in r-err_headers_out with those in r-headers_out. The latter have just come from the backend (the server proxied). But how/why should there be (any) cookies in r-err_headers_out

Re: Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Nick Kew
On 25 Jun 2004, Joe Schaefer wrote: Jim Jagielski [EMAIL PROTECTED] writes: Nick Kew wrote: [...] It appears just to merge Set-Cookie headers in r-err_headers_out with those in r-headers_out. The latter have just come from the backend (the server proxied). But how/why should

Re: Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Jim Jagielski
Joe Schaefer wrote: But is the err_headers_out logic in proxy_http.c HEAD really ok? It appears to put a copy of r-err_headers_out into r-headers_out, so I'm wondering why this doesn't produce duplicates in the final response (ie. doesn't httpd add r-err_headers_out itself, in

Re: Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Joe Schaefer
Jim Jagielski [EMAIL PROTECTED] writes: Joe Schaefer wrote: But is the err_headers_out logic in proxy_http.c HEAD really ok? It appears to put a copy of r-err_headers_out into r-headers_out, so I'm wondering why this doesn't produce duplicates in the final response (ie. doesn't httpd

Re: Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Jim Jagielski
Joe Schaefer wrote: Just to be sure we're on the same page- you agree here that HEAD will erroneously produce duplicates of any Set-Cookie headers in the proxy server's r-err_headers_out table. Sure looks like that :) It does not appear that err_headers_out is cleared in the proxy logic

Re: Proxy Cookie Support (Bug #10722)

2004-06-25 Thread Nick Kew
On Fri, 25 Jun 2004, Jim Jagielski wrote: So the apr_table_do(addit_dammit, save_table, r-err_headers_out, Set-Cookie, NULL); line should be removed. OK, that's what I needed to know. I'll still have to modify my patch slightly to work with