Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-25 Thread Graham Leggett
Ian Holsman wrote: The cache filter is supposed to run after all the filters for maximum caching advantage. I disagree on this. the cache filter should be able to placed where the admin wants it. In the advanced case, yes - but in the simplest turn-it-on-and-it-should-just-work case the

RE: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Bill Stoddard
Hi again :) I did a patch modifiying mod_proxy to pass the entire data (response from backend server) to output_filter, unstead of brigade per brigade. One comment (having not reviewed the patch): Proxy should stream bytes from the backend server to the client as those bytes arrive. Proxy

Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Graham Leggett
Matthieu Estrade wrote: I did a patch modifiying mod_proxy to pass the entire data (response from backend server) to output_filter, unstead of brigade per brigade. AFAIK the problem stems from a limitation in mod_cache where it can only cache stuff in a single brigade at the moment. Proxy

Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Matthieu Estrade
hi bill, I agree with you about the proxy... Do you think it's possible to force the cache filter, be runned after all the proxy filters ? Matthieu Bill Stoddard wrote: Hi again :) I did a patch modifiying mod_proxy to pass the entire data (response from backend server) to output_filter,

Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Graham Leggett
Matthieu Estrade wrote: I agree with you about the proxy... Do you think it's possible to force the cache filter, be runned after all the proxy filters ? The cache filter is supposed to run after all the filters for maximum caching advantage. Regards, Graham --

Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Matthieu Estrade
Hi graham, the problem is the filter is called between two ap_pass_brigade by the reverse proxy... like: proxy: get_brigade (data from backend) pass_brigade(pass data to outputfilter) cache_filter get_brigade(data from backend) pass_brigade(pass_data_to outputfilter) on one response by the

Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Paul J. Reder
Actually, the problem is in the fact that there is more than one brigade and the cache code can't currently handle that. Proxy is working the way it is supposed to. This allows Apache to process large responses without having to buffer the whole thing inside Apache. Apache uses less memory, and

Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Ian Holsman
Graham Leggett wrote: Matthieu Estrade wrote: I agree with you about the proxy... Do you think it's possible to force the cache filter, be runned after all the proxy filters ? The cache filter is supposed to run after all the filters for maximum caching advantage. I disagree on

Re: Patch mod_proxy: mod_proxy + mod_cache problem

2002-09-23 Thread Matthieu Estrade
Hi Paul, I know about mod_cache is only working on one brigade, but my problem is not here. My problem is i can't setup the filter cache_in_filter to be executed after mod_proxy pass his last brigade to the filter chain Actually, mod_cache_filter_in is executed only one time when mod_proxy