Re: should input filter return the exact amount of bytes asked for?

2003-11-14 Thread Stas Bekman
Justin Erenkrantz wrote: Thanks for the explanations Justin. Once I'll get some free time I'll need to revamp the filters chapter [1] to address the read mode issue. So far I was completely ignoring it :( (1) http://perl.apache.org/docs/2.0/user/handlers/filters.html Though it'd be nice to add

Re: should input filter return the exact amount of bytes asked for?

2003-11-14 Thread Justin Erenkrantz
--On Thursday, November 13, 2003 11:01 AM -0800 Stas Bekman <[EMAIL PROTECTED]> wrote: Should we add an explicit explanation to AP_MODE_READBYTES: return at most readbytes data. Can't return 0 with APR_BLOCK_READ. Can't return more than readbytes data. I'd say the first and last one are equivalen

Re: should input filter return the exact amount of bytes asked for?

2003-11-13 Thread Stas Bekman
Justin Erenkrantz wrote: --On Thursday, November 13, 2003 12:38 AM -0800 Stas Bekman <[EMAIL PROTECTED]> wrote: Great. Where this should be documented? In the ap_get_brigade .h? It's already in util_filters.h. Read the documentation for ap_input_mode_t: /** The filter should return at mos

Re: should input filter return the exact amount of bytes asked for?

2003-11-13 Thread Justin Erenkrantz
--On Thursday, November 13, 2003 12:38 AM -0800 Stas Bekman <[EMAIL PROTECTED]> wrote: Great. Where this should be documented? In the ap_get_brigade .h? It's already in util_filters.h. Read the documentation for ap_input_mode_t: /** The filter should return at most readbytes data. */ AP_M

Re: should input filter return the exact amount of bytes asked for?

2003-11-13 Thread Stas Bekman
Justin Erenkrantz wrote: On Tue, Nov 04, 2003 at 01:41:46AM -0800, Stas Bekman wrote: filter. What happens if the filter returns less bytes (while there is still more data coming?) What happens if the filter returns more bytes than requested (e.g. because it uncompressed some data). After all th

Re: should input filter return the exact amount of bytes asked for?

2003-11-11 Thread Justin Erenkrantz
--On Tuesday, November 11, 2003 11:24 AM -0600 "William A. Rowe, Jr." <[EMAIL PROTECTED]> wrote: More bytes = Not OK. (Theoretically possible though with bad filters.) Wrong. This is OK across the board, please consider; Uh, no. We changed the filter semantics some time ago to stop this insani

Re: should input filter return the exact amount of bytes asked for?

2003-11-11 Thread William A. Rowe, Jr.
At 03:31 AM 11/11/2003, Justin Erenkrantz wrote: >On Tue, Nov 04, 2003 at 01:41:46AM -0800, Stas Bekman wrote: >> filter. What happens if the filter returns less bytes (while there is still >> more data coming?) What happens if the filter returns more bytes than >> requested (e.g. because it unco

Re: should input filter return the exact amount of bytes asked for?

2003-11-11 Thread Justin Erenkrantz
On Tue, Nov 04, 2003 at 01:41:46AM -0800, Stas Bekman wrote: > filter. What happens if the filter returns less bytes (while there is still > more data coming?) What happens if the filter returns more bytes than > requested (e.g. because it uncompressed some data). After all the incoming Less by

Re: should input filter return the exact amount of bytes asked for?

2003-11-06 Thread Stas Bekman
Stas Bekman wrote: I'm trying to get rid of ap_get_client_block(), but I don't understand a few things. ap_get_client_block() asks for readbytes from the upstream filter. What happens if the filter returns less bytes (while there is still more data coming?) What happens if the filter returns mor