Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-19 Thread Daniel Lescohier
Of course, if you use "reliable piped logging" then if you also write more than PIPE_BUF bytes (4kiB on Linux) in a log line, it's not guaranteed to be atomic. I have been thinking of how to work around that limit, by logging to an Apache Flume Thrift RPC port. But to avoid the 4kiB limit you'd

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-18 Thread William A Rowe Jr
That doesn't work because it's no longer atomic, those log lines end up fanned out among all the other worker threads doing the same thing. Very hard to parse. On Mon, Apr 18, 2016 at 3:08 PM, Stefan Fritsch wrote: > On Monday 18 April 2016 10:42:23, Eric Covener wrote: > >

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-18 Thread Eric Covener
I'm won over and not tinkering with this FWIW.

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-18 Thread Daniel Lescohier
Doing this in the httpd server will prevent use-cases of programmatically parsing the log files. I think the data in the file should support both use-cases - Parsing the log file data for data analysis. - Humans reading the logs. So, the raw data should support both use-cases. For a

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-18 Thread Stefan Eissing
Would it make sense to replace \n with \n\t? > Am 18.04.2016 um 14:23 schrieb Jim Jagielski : > > No opinion :) > >> On Apr 13, 2016, at 3:43 PM, Eric Covener wrote: >> >> Currently newlines get backslash-escaped if written to the errorlog. >> This is via

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-18 Thread Jim Jagielski
No opinion :) > On Apr 13, 2016, at 3:43 PM, Eric Covener wrote: > > Currently newlines get backslash-escaped if written to the errorlog. > This is via server/gen_test_char.c and stems from an ancient vuln > about escape sequences in log files potentially affecting peoples >

RE: allow newlines in T_ESCAPE_LOGITEM?

2016-04-18 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: Yann Ylavic [mailto:ylavic@gmail.com] > Sent: Mittwoch, 13. April 2016 23:16 > To: httpd-dev > Subject: Re: allow newlines in T_ESCAPE_LOGITEM? > > On Wed, Apr 13, 2016 at 11:08 PM, Eric Covener <cove...@gmail.com> wrote: >

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-13 Thread Daniel Lescohier
It's especially important when doing log processing on Apache Hadoop, if you give uncompressed text files as input files to a Hadoop job, it'd split large log files on newlines to be processed on multiple nodes. That split should be done on a record boundary. On Wed, Apr 13, 2016 at 5:16 PM,

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-13 Thread Yann Ylavic
On Wed, Apr 13, 2016 at 11:08 PM, Eric Covener wrote: > On Wed, Apr 13, 2016 at 5:05 PM, Daniel Lescohier > wrote: >> Isn't T_ESCAPE_LOGITEM also used by mod_log_config's use of >> ap_escape_logitem? We rely on the API that data from HTTP requests

Re: allow newlines in T_ESCAPE_LOGITEM?

2016-04-13 Thread Daniel Lescohier
Isn't T_ESCAPE_LOGITEM also used by mod_log_config's use of ap_escape_logitem? We rely on the API that data from HTTP requests that are logged in our mod_log_config logfiles are newline-escaped, so that one line in the logfile is parsed as one log entry. Our parsers first split on newline to get

allow newlines in T_ESCAPE_LOGITEM?

2016-04-13 Thread Eric Covener
Currently newlines get backslash-escaped if written to the errorlog. This is via server/gen_test_char.c and stems from an ancient vuln about escape sequences in log files potentially affecting peoples terminals when cat'ed. On a few occasions I have worked with some libraries that return a