Bill Stoddard wrote:
Checkout this patch. I -know- state AP_MPMQ_RESTARTING does not exist in
ap_mpm.h (so this patch will not compile) but consider it for purposes
of discussion. The parent process always goes through master_main() and
master_main() can distinguish between stopping and grace
Jeff Trawick wrote:
Bill Stoddard wrote:
Do you know of any cases that actually require mpm_state to be updated
in ap_signal_parent()? Setting winnt_mpm_state to AP_MPMQ_STOPPING in
child main should be sufficient unless I am missing something.
the code in service.c which shuts down the serve
Bill Stoddard wrote:
Do you know of any cases that actually require mpm_state to be updated
in ap_signal_parent()? Setting winnt_mpm_state to AP_MPMQ_STOPPING in
child main should be sufficient unless I am missing something.
the code in service.c which shuts down the server for other reasons?
A
Do you know of any cases that actually require mpm_state to be updated in ap_signal_parent()? Setting
winnt_mpm_state to AP_MPMQ_STOPPING in child main should be sufficient unless I am missing something.
Bill
[EMAIL PROTECTED] wrote:
trawick 2003/12/16 18:16:44
Modified:server/mpm/w
[EMAIL PROTECTED] wrote:
stoddard2003/12/15 15:19:14
Modified:server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h
Log:
Win32: Rename WindowsSocketsWorkaround directive to Win32DisableAcceptEx.
Clean up code paths.
Index: mpm_winnt.c
-static const char *set_sockets_workaround (cm
Rather than WindowsSocketsWorkaround, why not WinUseWinsock1 or ??. It
would be better I think if the directive somehow indicated exactly what
it was doing (causing the winnt mpm to use the select/accept winsock1
calls rather than AcceptEx, a winsock2 call).
We're still usng winsock2 with this d
William A. Rowe, Jr. wrote:
At 12:57 PM 3/13/2003, Bill Stoddard wrote:
[EMAIL PROTECTED] wrote:
ake 2003/03/04 14:15:52
Modified:.CHANGES
server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h
Log:
Added the WindowsSocketsWorkaroud directive for Windows NT/2000/XP
to w
At 12:57 PM 3/13/2003, Bill Stoddard wrote:
>[EMAIL PROTECTED] wrote:
>>ake 2003/03/04 14:15:52
>> Modified:.CHANGES
>> server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h
>> Log:
>> Added the WindowsSocketsWorkaroud directive for Windows NT/2000/XP
>> to work aro
[EMAIL PROTECTED] wrote:
ake 2003/03/04 14:15:52
Modified:.CHANGES
server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h
Log:
Added the WindowsSocketsWorkaroud directive for Windows NT/2000/XP
to work around problems with certain VPN and Firewall products that
probably. My opinion in this case isn't strong either. Actually I wanted to
exclude an oversight of the INIT_FLAG macro :)
OK, point taken, thanks for the feedback Andre!
Allan
* Allan Edwards wrote:
>>> +AP_INIT_TAKE1("WindowsSocketsWorkaround", set_sockets_workaround, NULL,
>>> RSRC_CONF,
>>> + "Set \"on\" to work around buggy Winsock provider implementations of certain
>>> VPN or Firewall software"),
>>> +
>> hey, no need to double code. AP_INIT_FLAG exists ;-)
+AP_INIT_TAKE1("WindowsSocketsWorkaround", set_sockets_workaround, NULL, RSRC_CONF,
+ "Set \"on\" to work around buggy Winsock provider implementations of certain VPN or
Firewall software"),
+
hey, no need to double code. AP_INIT_FLAG exists ;-)
Well I guess that's just a matter of personal
* [EMAIL PROTECTED] wrote:
> +AP_INIT_TAKE1("WindowsSocketsWorkaround", set_sockets_workaround, NULL, RSRC_CONF,
> + "Set \"on\" to work around buggy Winsock provider implementations of certain
> VPN or Firewall software"),
> +
hey, no need to double code. AP_INIT_FLAG exists ;-)
nd
--
At 08:15 AM 7/29/2002, you wrote:
>Seperating out the routines that run only in the child (and putting them in
>child.c) is not a bad thing but this patch is difficult to review for
>several reasons:
>
>1. The commit log did not mention the biggest change. Easy to intuit looking
>at the code, but
poor.
>
> Bill
>
> > -Original Message-
> > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> > Sent: Monday, July 29, 2002 1:13 AM
> > To: [EMAIL PROTECTED]
> > Subject: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c
> > mpm_winnt.h
> >
>
TECTED]]
> Sent: Monday, July 29, 2002 1:13 AM
> To: [EMAIL PROTECTED]
> Subject: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c
> mpm_winnt.h
>
>
> wrowe 2002/07/28 22:12:50
>
> Modified:server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h
>
16 matches
Mail list logo
