Re: jumbo patch from 39380 - and moving things 'up' to mod_cache itself

2008-05-09 Thread Akins, Brian
What if Vary were much more than just HTTP Vary? It would be nice if the framework could support the external vary (ie, normal HTTP Vary) as well as any internal Vary. To use general mod_disk_cache structure, we currently have something sorta like this for vary metafiles: int cache_version

Re: jumbo patch from 39380 - and moving things 'up' to mod_cache itself

2008-05-09 Thread Graham Leggett
Dirk-Willem van Gulik wrote: There is a lot of valuable stuff in your jumbo patch - but I am not sure what the best approach is to fold it in. Could you have have a look at the rough patch I posted earlier today - and let me know if you have any thoughts as to which parts should be moved

Re: jumbo patch from 39380 - and moving things 'up' to mod_cache itself

2008-05-09 Thread Niklas Edmundsson
On Fri, 9 May 2008, Graham Leggett wrote: There is a lot of valuable stuff in your jumbo patch - but I am not sure what the best approach is to fold it in. Could you have have a look at the rough patch I posted earlier today - and let me know if you have any thoughts as to which parts should

Re: jumbo patch from 39380 - and moving things 'up' to mod_cache itself

2008-05-09 Thread Graham Leggett
Niklas Edmundsson wrote: I'm not convinced that forking the disk cache having two similar ones tuned for different usecases is a good idea in the long run, I'm pretty sure that the parts that needs tweaking can be solved with config options and documentation. For a development sprint like

Re: jumbo patch from 39380 - and moving things 'up' to mod_cache itself

2008-05-09 Thread Graham Leggett
William A. Rowe, Jr. wrote: I think the bigger idea that mod_cache must handle all rfc related issues is key. mem and disk cache should never have had substantial differences in behavior, but they do. So the more we can consolidate in mod_cache w.r.t. the requests themselves, the less the