mpm_winnt lingering close

2017-04-03 Thread Stefan Eissing
Steffen started testing and immediately found sth. Yeah! He sees many [Mon Apr 03 14:20:28.390474 2017] [http2:warn] [pid 3180:tid 2880] [client 5.80.147.209:61342] AH10020: h2_session(106,DONE,0): session cleanup triggered by pool cleanup. this should have happened earlier already. in his logs

Re: mpm_winnt lingering close

2017-04-03 Thread Eric Covener
On Mon, Apr 3, 2017 at 9:07 AM, Stefan Eissing wrote: > Question is: do we "fix" mpm_winnt or is there a better way for mod_http2 to > shutdown the connection before mod_ssl does. This would need to work in async > mpms for any connection state. I think it's okay to add the prep cal when short-

Re: mpm_winnt lingering close

2017-04-03 Thread William A Rowe Jr
On Mon, Apr 3, 2017 at 8:21 AM, Eric Covener wrote: > On Mon, Apr 3, 2017 at 9:07 AM, Stefan Eissing > wrote: >> Question is: do we "fix" mpm_winnt or is there a better way for mod_http2 to >> shutdown the connection before mod_ssl does. This would need to work in >> async mpms for any connecti

Re: mpm_winnt lingering close

2017-04-11 Thread Stefan Eissing
> Am 03.04.2017 um 21:17 schrieb William A Rowe Jr : > > On Mon, Apr 3, 2017 at 8:21 AM, Eric Covener wrote: >> On Mon, Apr 3, 2017 at 9:07 AM, Stefan Eissing >> wrote: >>> Question is: do we "fix" mpm_winnt or is there a better way for mod_http2 >>> to shutdown the connection before mod_ssl d

Re: mpm_winnt lingering close

2017-04-11 Thread Steffen
Running now with Patch on AL windows with v1.10.1-git, nghttp2 1.21.1 , no warning anymore seen. On Tuesday 11/04/2017 at 10:23, Stefan Eissing wrote: Am 03.04.2017 um 21:17 schrieb William A Rowe Jr : On Mon, Apr 3, 2017 at 8:21 AM, Eric Covener wrote: On Mon, Apr 3, 2017 at 9

Re: mpm_winnt lingering close

2017-04-11 Thread William A Rowe Jr
Great news, thanks Steffen! Stefan - if you apply to trunk and 2.4.x (I'm already +1 on inspection) I have regression testing on Windows to do today and tomorrow and can give this a little more exercise. Cheers, Bill On Tue, Apr 11, 2017 at 5:27 AM, Steffen wrote: > Running now with Patch on

Re: mpm_winnt lingering close

2017-04-11 Thread Stefan Eissing
Bill, submitted in trunk and proposed for 2.4.x. Thanks for testing. -Stefan > Am 11.04.2017 um 15:30 schrieb William A Rowe Jr : > > Great news, thanks Steffen! > > Stefan - if you apply to trunk and 2.4.x (I'm already +1 on inspection) I have > regression testing on Windows to do today and to

Re: mpm_winnt lingering close

2017-04-11 Thread William A Rowe Jr
Steffen, I think we are missing an edge case, if you could retest with http://svn.apache.org/viewvc?view=revision&revision=1790978 http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/winnt/child.c?r1=1758310&r2=1790978&view=patch is the net patch between the current 2.4.25 and now. Stefan -

Re: mpm_winnt lingering close

2017-04-11 Thread Stefan Eissing
well, your change just reverses the order of check and call. far be it from me to say what is better. just wanted to point that out. > Am 11.04.2017 um 16:14 schrieb William A Rowe Jr : > > Steffen, I think we are missing an edge case, if you could retest with > http://svn.apache.org/viewvc?vi

Re: mpm_winnt lingering close

2017-04-11 Thread Steffen

Re: mpm_winnt lingering close

2017-04-11 Thread William A Rowe Jr
On Tue, Apr 11, 2017 at 9:35 AM, Stefan Eissing wrote: > well, your change just reverses the order of check and call. far be it from > me to say what is better. just wanted to point that out. You scared me :) (I thought I had flipped fetching and testing the disconnected flag for a moment there