Re: svn commit: r1639614 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-12-02 Thread Yann Ylavic
On Fri, Nov 14, 2014 at 1:04 PM, cove...@apache.org wrote: Author: covener Date: Fri Nov 14 12:04:46 2014 New Revision: 1639614 URL: http://svn.apache.org/r1639614 Log: don't call notify_suspend() in a worker thread after start_lingering_close_common may have put the socket back into the

Re: svn commit: r1639614 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-12-02 Thread Yann Ylavic
On Fri, Nov 14, 2014 at 1:04 PM, cove...@apache.org wrote: Author: covener Date: Fri Nov 14 12:04:46 2014 New Revision: 1639614 URL: http://svn.apache.org/r1639614 Log: don't call notify_suspend() in a worker thread after start_lingering_close_common may have put the socket back into the

Re: svn commit: r1639614 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-12-02 Thread Eric Covener
Index: server/mpm/event/event.c === --- server/mpm/event/event.c(revision 1642684) +++ server/mpm/event/event.c(working copy) @@ -859,16 +859,16 @@ static int start_lingering_close_common(event_conn cs-pub.state

Re: svn commit: r1639614 - /httpd/httpd/trunk/server/mpm/event/event.c

2014-12-02 Thread Eric Covener
On Tue, Dec 2, 2014 at 5:52 AM, Yann Ylavic ylavic@gmail.com wrote: Also, the old code notified unconditionally (too late, but always), whereas now it will not should ap_start_lingering_close() fail in start_lingering_close_blocking(). Shouldn't we : Index: server/mpm/event/event.c