Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-11 Thread William A Rowe Jr
On Tue, May 10, 2016 at 11:36 PM, William A Rowe Jr wrote: > On Tue, May 10, 2016 at 7:26 PM, Yann Ylavic wrote: > >> >> The case where this happens is for keepalive/lingering-close handling. >> Suppose thread t1 handles request r1 on connection c1, and t1 is >> released after r1 (when c1 is kep

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-10 Thread William A Rowe Jr
On Tue, May 10, 2016 at 7:26 PM, Yann Ylavic wrote: > On Tue, May 10, 2016 at 5:23 PM, William A Rowe Jr > wrote: > > On Sun, May 8, 2016 at 7:29 AM, Yann Ylavic > wrote: > >> > >> ISTM that the request line has already been clobbered (blanked) by the > >> previous call to ap_update_child_statu

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-10 Thread Yann Ylavic
On Tue, May 10, 2016 at 5:23 PM, William A Rowe Jr wrote: > > On Sun, May 8, 2016 at 7:29 AM, Yann Ylavic wrote: >> >> ISTM that the request line has already been clobbered (blanked) by the >> previous call to ap_update_child_status_from_conn(SERVER_BUSY_READ) in >> ap_process_http_[a]sync_connec

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-10 Thread William A Rowe Jr
I believe this is the right patch (or close to correct) for 2.4 branch, and perhaps even trunk with additional refactoring. In the case of resuming a thread, it should be up to the event/advanced MPM to reflect the correct no-info | [connection-info [request-info]] state of the conn at the time th

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-10 Thread William A Rowe Jr
On Sun, May 8, 2016 at 7:29 AM, Yann Ylavic wrote: > > ISTM that the request line has already been clobbered (blanked) by the > previous call to ap_update_child_status_from_conn(SERVER_BUSY_READ) in > ap_process_http_[a]sync_connection(), where we already lost the > previous request's line. > Th

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-08 Thread Rainer Jung
Am 08.05.2016 um 20:06 schrieb Yann Ylavic: [top posting reodered] On Sun, May 8, 2016 at 7:21 PM, Stefan Eissing wrote: Am 08.05.2016 um 16:30 schrieb Rainer Jung : If that would be consensus, it would mean, we should only reset the request info at the start of a connection. For sync conn

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-08 Thread Yann Ylavic
[top posting reodered] On Sun, May 8, 2016 at 7:21 PM, Stefan Eissing wrote: > >> Am 08.05.2016 um 16:30 schrieb Rainer Jung : >> >> If that would be consensus, it would mean, we should only reset the request >> info at the start of a connection. For sync connections, that's exactly what >> hap

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-08 Thread Stefan Eissing
Isn't conn_rec->keepalives an indicator? /Stefan > Am 08.05.2016 um 16:30 schrieb Rainer Jung : > > If that would be consensus, it would mean, we should only reset the request > info at the start of a connection. For sync connections, that's exactly what > happens already. For http2 I'm not su

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-08 Thread Rainer Jung
Am 08.05.2016 um 16:30 schrieb Rainer Jung: Am 08.05.2016 um 14:29 schrieb Yann Ylavic: On Sun, May 8, 2016 at 12:30 PM, wrote: + * Don't globber scoreboard request info if read_request_line() fails with + a timeout. In that case there's not yet any new useful request info + availa

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-08 Thread Rainer Jung
Am 08.05.2016 um 14:29 schrieb Yann Ylavic: On Sun, May 8, 2016 at 12:30 PM, wrote: + * Don't globber scoreboard request info if read_request_line() fails with + a timeout. In that case there's not yet any new useful request info + available. + Noticed via server-status showing

Re: svn commit: r1742794 - /httpd/httpd/branches/2.4.x/STATUS

2016-05-08 Thread Yann Ylavic
On Sun, May 8, 2016 at 12:30 PM, wrote: > > + * Don't globber scoreboard request info if read_request_line() fails with > + a timeout. In that case there's not yet any new useful request info > + available. > + Noticed via server-status showing request "NULL" after keep-alive > +