Re: svn commit: r1748653 - /httpd/httpd/trunk/modules/filters/sed0.c

2016-06-16 Thread William A Rowe Jr
Sorry - false alarm, per the open spec for limits.h the patch -is- correct... {PATH_MAX}Maximum number of bytes in a pathname, including the terminating null character. Minimum Acceptable Value: {_POSIX_PATH_MAX} [XSI] [image: [Option Start]] Minimum Acceptable Value: {_XOPEN_PATH_MAX} [image: [Op

Re: svn commit: r1748653 - /httpd/httpd/trunk/modules/filters/sed0.c

2016-06-16 Thread William A Rowe Jr
ATTN Jim, I presume you didn't read the note below? On Thu, Jun 16, 2016 at 6:59 AM, William A Rowe Jr wrote: > This looks inverted. The buffer should be MAX+1. > > This logic error leads to paths valid in one context, which fail later in > the next bit of code. > On Jun 16, 2016 12:17 AM, w

Re: svn commit: r1748653 - /httpd/httpd/trunk/modules/filters/sed0.c

2016-06-16 Thread William A Rowe Jr
This looks inverted. The buffer should be MAX+1. This logic error leads to paths valid in one context, which fail later in the next bit of code. On Jun 16, 2016 12:17 AM, wrote: > Author: jailletc36 > Date: Thu Jun 16 05:17:35 2016 > New Revision: 1748653 > > URL: http://svn.apache.org/viewvc?r