Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread William A Rowe Jr
On Fri, Aug 5, 2016 at 12:50 PM, Yann Ylavic wrote: > > while adding > > the unnecessary verification of last_len != 0 from line 904, so I'd say > it's > > a > > net loss of legibility in spite of gaining us 4 characters. Just my 2c. > > The 'len' verification is necessary

Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread Yann Ylavic
On Fri, Aug 5, 2016 at 7:33 PM, William A Rowe Jr wrote: > On Fri, Aug 5, 2016 at 10:43 AM, Yann Ylavic wrote: >> >> @@ -903,8 +903,16 @@ AP_DECLARE(void) ap_get_mime_headers_core(request_ >> */ >> continue; >> } >> -

Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread William A Rowe Jr
On Fri, Aug 5, 2016 at 10:43 AM, Yann Ylavic wrote: > @@ -903,8 +903,16 @@ AP_DECLARE(void) ap_get_mime_headers_core(request_ > */ > continue; > } > -else if (last_field != NULL) { > > +if (last_field == NULL) { > +

Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread Yann Ylavic
On Thu, Aug 4, 2016 at 12:58 AM, wrote: > Author: wrowe > Date: Wed Aug 3 22:58:10 2016 > New Revision: 1755124 > > URL: http://svn.apache.org/viewvc?rev=1755124=rev > Log: > Reformat for indentation following r1755123, Whitespace Only > > Modified: >