On Wed, Jul 3, 2024 at 4:40 PM Ruediger Pluem wrote:
>
> On 7/3/24 3:23 PM, Yann Ylavic wrote:
> > On Wed, Jul 3, 2024 at 2:34 PM Ruediger Pluem wrote:
> >>
> >> Thanks for the intense review. I hope I captured all stuff in the below.
> >
> > Thanks for working on this.
>
> Committed in r1918880
On Wed, Jul 3, 2024 at 4:40 PM Ruediger Pluem wrote:
>
> On 7/3/24 3:23 PM, Yann Ylavic wrote:
> > On Wed, Jul 3, 2024 at 2:34 PM Ruediger Pluem wrote:
> >>
> >> Thanks for the intense review. I hope I captured all stuff in the below.
> >
> > Thanks for working on this.
>
> Committed in r1918880
On 7/3/24 3:23 PM, Yann Ylavic wrote:
> On Wed, Jul 3, 2024 at 2:34 PM Ruediger Pluem wrote:
>>
>> Thanks for the intense review. I hope I captured all stuff in the below.
>
> Thanks for working on this.
Committed in r1918880 considering your comments. Feel free to add the patch you
provided
On Wed, Jul 3, 2024 at 2:34 PM Ruediger Pluem wrote:
>
> Thanks for the intense review. I hope I captured all stuff in the below.
Thanks for working on this.
> I intentionally left the 'len' parameter of ssl_io_data_dump an apr_size_t in
> case we ever get to the conclusion that we want to
> ma
On 7/3/24 11:09 AM, Yann Ylavic wrote:
> On Wed, Jul 3, 2024 at 11:01 AM Yann Ylavic wrote:
>>
>> On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote:
>>>
>>> On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
On 7/3/24 2:59 AM, Yann Ylavic wrote:
> On Tue, Jul 2, 2024 at 10:57
On 7/3/24 11:01 AM, Yann Ylavic wrote:
> On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote:
>>
>> On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
>>>
>>> On 7/3/24 2:59 AM, Yann Ylavic wrote:
On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
>
> Updated patch.
>> []
On Wed, Jul 3, 2024 at 11:01 AM Yann Ylavic wrote:
>
> On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote:
> >
> > On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
> > >
> > > On 7/3/24 2:59 AM, Yann Ylavic wrote:
> > > > On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem
> > > > wrote:
> > > >
On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote:
>
> On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
> >
> > On 7/3/24 2:59 AM, Yann Ylavic wrote:
> > > On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
> > >>
> > >> Updated patch.
> []
> > >> const char *dump = "";
> > >
On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
>
> On 7/3/24 2:59 AM, Yann Ylavic wrote:
> > On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
> >>
> >> Updated patch.
[]
> >> const char *dump = "";
> >> if (APLOG_CS_IS_LEVEL(c, s, APLOG_TRACE7)) {
> >>
On 7/3/24 2:59 AM, Yann Ylavic wrote:
> On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
>>
>> On 7/1/24 3:01 PM, Ruediger Pluem wrote:
>>>
>>>
>>> On 6/27/24 3:48 PM, Ruediger Pluem wrote:
On 6/27/24 12:47 PM, Yann Ylavic wrote:
> On Thu, Jun 27, 2024 at 12:38 PM Yann Y
On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
>
> On 7/1/24 3:01 PM, Ruediger Pluem wrote:
> >
> >
> > On 6/27/24 3:48 PM, Ruediger Pluem wrote:
> >>
> >>
> >> On 6/27/24 12:47 PM, Yann Ylavic wrote:
> >>> On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote:
>
> On Thu, Jun 27, 2
On 7/1/24 3:01 PM, Ruediger Pluem wrote:
>
>
> On 6/27/24 3:48 PM, Ruediger Pluem wrote:
>>
>>
>> On 6/27/24 12:47 PM, Yann Ylavic wrote:
>>> On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote:
On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote:
>
> How about the below?
On 6/27/24 3:48 PM, Ruediger Pluem wrote:
>
>
> On 6/27/24 12:47 PM, Yann Ylavic wrote:
>> On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote:
>>>
>>> On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote:
How about the below? I am yet undecided if I should follow the below
a
On 6/27/24 12:47 PM, Yann Ylavic wrote:
> On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote:
>>
>> On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote:
>>>
>>> How about the below? I am yet undecided if I should follow the below
>>> approach to have
>>> two completely separate callbacks de
On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote:
>
> On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote:
> >
> > How about the below? I am yet undecided if I should follow the below
> > approach to have
> > two completely separate callbacks depending on the OpenSSL version or one
> > with
On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote:
>
> How about the below? I am yet undecided if I should follow the below approach
> to have
> two completely separate callbacks depending on the OpenSSL version or one
> with a lot of
> #If statements in it, but as much shared code as possib
On 6/26/24 11:33 AM, Yann Ylavic wrote:
> On Wed, Jun 26, 2024 at 10:28 AM Ruediger Pluem wrote:
>>
>> On 3/19/23 10:30 PM, yla...@apache.org wrote:
>>>
>>> --- httpd/httpd/trunk/modules/ssl/ssl_engine_io.c (original)
>>> +++ httpd/httpd/trunk/modules/ssl/ssl_engine_io.c Sun Mar 19 21:30:47 202
On Wed, Jun 26, 2024 at 10:28 AM Ruediger Pluem wrote:
>
> On 3/19/23 10:30 PM, yla...@apache.org wrote:
> >
> > --- httpd/httpd/trunk/modules/ssl/ssl_engine_io.c (original)
> > +++ httpd/httpd/trunk/modules/ssl/ssl_engine_io.c Sun Mar 19 21:30:47 2023
>
> > @@ -2402,7 +2403,7 @@ long ssl_io_data_
On 3/19/23 10:30 PM, yla...@apache.org wrote:
> Author: ylavic
> Date: Sun Mar 19 21:30:47 2023
> New Revision: 1908537
>
> URL: http://svn.apache.org/viewvc?rev=1908537&view=rev
> Log:
> mod_ssl: Fix deprecation warnings with openssl-3.
>
> * mod_ssl_openssl.h:
> Make it the first openssl t
On Sun, Mar 19, 2023 at 09:30:47PM -, yla...@apache.org wrote:
> Author: ylavic
> Date: Sun Mar 19 21:30:47 2023
> New Revision: 1908537
>
> URL: http://svn.apache.org/viewvc?rev=1908537&view=rev
> Log:
> mod_ssl: Fix deprecation warnings with openssl-3.
Great stuff, thank you Yann!
20 matches
Mail list logo
