Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-21 Thread William A. Rowe, Jr.
Roy T. Fielding wrote: So, I'm -0.9 on the patch, even though it isn't much worse than the existing code. I'd be -1 if I could be sure what it did. And I wouldn't debate it... back to the drawing board. As an improvement to the behavior I support it, in terms of style it got a -0.5 from me,

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-20 Thread Issac Goldstand
If we're in backport season, I have a quick patch that I whipped up yesterday to fix mod_disk_cache on 2.2.x on systems that have APR_SENDFILE_ENABLED but EnableSendfile Off. Issac William A. Rowe, Jr. wrote: [EMAIL PROTECTED] wrote: Votes and Notes; the first four I would like to see

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-20 Thread William A. Rowe, Jr.
William A. Rowe, Jr. wrote: next time http://issues.apache.org/bugzilla/show_bug.cgi?id=37680 would help so the fruit hangs even lower. Thanks Jim! The other fatal bug is: * mpm_winnt: Fix return values from wait_for_many_objects.

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-20 Thread Jim Jagielski
William A. Rowe, Jr. wrote: The other fatal bug is: * mpm_winnt: Fix return values from wait_for_many_objects. http://svn.apache.org/viewvc?view=revrevision=428029 2.2.x version of patch: Trunk version works +

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-20 Thread William A. Rowe, Jr.
Jim Jagielski wrote: William A. Rowe, Jr. wrote: The other fatal bug is: * mpm_winnt: Fix return values from wait_for_many_objects. http://svn.apache.org/viewvc?view=revrevision=428029 2.2.x version of patch: Trunk version works +

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-20 Thread Roy T. Fielding
On Dec 20, 2006, at 5:14 PM, William A. Rowe, Jr. wrote: * mpm_winnt: Fix return values from wait_for_many_objects. http://svn.apache.org/viewvc?view=revrevision=428029 2.2.x version of patch: Trunk version works +

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-19 Thread William A. Rowe, Jr.
[EMAIL PROTECTED] wrote: Votes and Notes; the first four I would like to see applied before tagging 1.2.4; add a better patch for the winnt mpm wait patch that makes this reviewable (sometimes -U3 just isn't enough context.) As Ruediger guessed and committed (thanks!) we are now two more

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-19 Thread Nick Kew
On Tue, 19 Dec 2006 16:34:24 -0600 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I see two final state bugs... I'm about to finish vetting niq's patch for listen reconfig which pegs httpd at 100% cpu For the record, not my patch. It's attached to the PR, and the contributor is currently

Re: svn commit: r488780 - /httpd/httpd/branches/2.2.x/STATUS

2006-12-19 Thread William A. Rowe, Jr.
Nick Kew wrote: On Tue, 19 Dec 2006 16:34:24 -0600 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I see two final state bugs... I'm about to finish vetting niq's patch for listen reconfig which pegs httpd at 100% cpu For the record, not my patch. It's attached to the PR, and the