Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-09 Thread Graham Leggett
Ruediger Pluem wrote: Why is this needed? Should this job be performed by the ap_keep_body_filter that should be in our input filter chain if we want to keep the body? Of course this depends when we call ap_parse_request_form. If we call it during the authn/z phase the filter chain hasn't been

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-07 Thread Roy T. Fielding
On May 2, 2008, at 11:28 AM, Roy T. Fielding wrote: Hah, I was reading it like an equation from my discrete math days. I guess ^ really is less readable. ;-) low & hi would be my preference. Er, duh, (hi | low) would be my preference. Or just leave it as is. Roy

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-02 Thread Roy T. Fielding
On May 2, 2008, at 11:19 AM, Ruediger Pluem wrote: On 05/02/2008 07:54 PM, Roy T. Fielding wrote: On May 2, 2008, at 4:07 AM, Plüm, Rüdiger, VF-Group wrote: +c = low ^ hi; Shouldn't this be c = low + hi ? In theory either should work, which is faster? The AND. I agre

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-02 Thread Ruediger Pluem
On 05/02/2008 07:54 PM, Roy T. Fielding wrote: On May 2, 2008, at 4:07 AM, Plüm, Rüdiger, VF-Group wrote: +c = low ^ hi; Shouldn't this be c = low + hi ? In theory either should work, which is faster? The AND. I agree that an AND (&) or an OR (|) would be also read

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-02 Thread Roy T. Fielding
On May 2, 2008, at 4:07 AM, Plüm, Rüdiger, VF-Group wrote: +c = low ^ hi; Shouldn't this be c = low + hi ? In theory either should work, which is faster? The AND. I think there is not much difference with respect to speed but using '+' seems to be easier to read. No

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-02 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Graham Leggett > Gesendet: Freitag, 2. Mai 2008 13:28 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ > docs/manual/mod/ include/ modules/aaa/ modules/filters/ > modules/http/ se

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-02 Thread Graham Leggett
Plüm wrote: What about transient buckets? Don't we need to set them aside? I don't follow - does the apr_bucket_copy not do that for us already? No, it does not. Let me look further. In theory, that would mean you could only read the kept_body once. The kept body could be delivered to mu

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-02 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Graham Leggett > Gesendet: Freitag, 2. Mai 2008 12:40 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ > docs/manual/mod/ include/ modules/aaa/ modules/filters/ > modules/http/ server

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-02 Thread Graham Leggett
Ruediger Pluem wrote: +/* all is well, set aside the buckets */ +for (bucket = APR_BRIGADE_FIRST(b); + bucket != APR_BRIGADE_SENTINEL(b); + bucket = APR_BUCKET_NEXT(bucket)) +{ +apr_bucket_copy(bucket, &e); What about transient buckets? Don't we need to set

Re: svn commit: r647263 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/aaa/ modules/filters/ modules/http/ server/

2008-05-01 Thread Ruediger Pluem
On 04/11/2008 08:41 PM, [EMAIL PROTECTED] wrote: Author: minfrin Date: Fri Apr 11 11:41:53 2008 New Revision: 647263 URL: http://svn.apache.org/viewvc?rev=647263&view=rev Log: Move the KeptBodySize directive, kept_body filters and the ap_parse_request_body function out of the http module and i