Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Christophe JAILLET
Hi, should this warning at startup be an issue, why not just remove it in 2.4.x and keep it in trunk? Having the depreciation written in doc (and in migration note for 2.4 - 2.6/3.0 one day) could be enough, no? BTW, the apr_pstrdup(ap_pglobal, 1) could be just 1. CJ Le 12/06/2015 11:07,

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Yann Ylavic
Hi Christophe, On Fri, Jun 12, 2015 at 1:26 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: should this warning at startup be an issue, why not just remove it in 2.4.x and keep it in trunk? Having the depreciation written in doc (and in migration note for 2.4 - 2.6/3.0 one day)

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Jeff Trawick
On Fri, Jun 12, 2015 at 5:07 AM, yla...@apache.org wrote: Author: ylavic Date: Fri Jun 12 09:07:34 2015 New Revision: 1685052 URL: http://svn.apache.org/r1685052 Log: mod_ssl: Warn about deprecated SSLCertificateChainFile once at startup, on first usage only. Modified:

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Yann Ylavic
On Fri, Jun 12, 2015 at 2:11 PM, Jeff Trawick traw...@gmail.com wrote: IMHO the ap_retained_data_get/create APIs make this nicer than this older pattern. Ah yes, good catch, I just did not think about it. retained = ap_retained_data_get(userdata_key); if (!retained) {

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jim Jagielski
On Jun 11, 2015, at 10:08 AM, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.4.14 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.14 GA. [X] +1: Good to go Go

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jacob Perkins
+1 to Noels comments. We have a ton of servers running Apache 2.4 with our control panel. Doing this in a point release will cause us to have to change our product instead of doing a regular Apache release. When you have a server with 10k+ SSL vhosts, this can cause massive, unexpected

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread Rainer Jung
Am 12.06.2015 um 13:49 schrieb Yann Ylavic: Hi Christophe, On Fri, Jun 12, 2015 at 1:26 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: should this warning at startup be an issue, why not just remove it in 2.4.x and keep it in trunk? Having the depreciation written in doc (and in

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Eric Covener
It doesn't make sense for us to hold up a release when that change has been in the last several releases however. (That's a high barrier for making progress.) There seems to be a 2.4.8 component and an actual 2.4.13 component. Did the 2.4.13 fix make it more frequent. (fixing my top-post)

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jeff Trawick
On Fri, Jun 12, 2015 at 1:35 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Jun 12, 2015 at 1:31 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Jun 12, 2015 at 1:25 PM, Rainer Jung rainer.j...@kippdata.de wrote: Am 12.06.2015 um 19:12 schrieb William A Rowe Jr: Revision 1678233 -

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jacob Perkins
Hi Jeff, Thanks for the response. You’re right, this does look to be in Apache 2.2.12 at this time. I was taking this from CHANGES, and it states: Changes with Apache 2.4.13 *) mod_ssl: make sure to consistently output SSLCertificateChainFile deprecation warnings, when encountered in a

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread William A Rowe Jr
Revision 1678233 - (view) (download) (annotate) - [select for diffs] Modified Thu May 7 16:26:43 2015 UTC (5 weeks, 1 day ago) by jim File length: 57106 byte(s) Diff to previous 1674655 (colored) Merge r1676085 from trunk: consistently output SSLCertificateChainFile deprecation warnings Submitted

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Rainer Jung
Am 12.06.2015 um 19:12 schrieb William A Rowe Jr: Revision 1678233 - (view) (download) (annotate) - [select for diffs] Modified Thu May 7 16:26:43 2015 UTC (5 weeks, 1 day ago) by jim File length: 57106 byte(s) Diff to previous 1674655 (colored) Merge r1676085 from trunk: consistently output

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jeff Trawick
On Fri, Jun 12, 2015 at 12:58 PM, Eric Covener cove...@gmail.com wrote: It doesn't make sense for us to hold up a release when that change has been in the last several releases however. (That's a high barrier for making progress.) There seems to be a 2.4.8 component and an actual 2.4.13

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jeff Trawick
On Fri, Jun 12, 2015 at 12:35 PM, Jacob Perkins jacob.perk...@cpanel.net wrote: +1 to Noels comments. We have a ton of servers running Apache 2.4 with our control panel. Doing this in a point release will cause us to have to change our product instead of doing a regular Apache release.

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Eric Covener
There seems to be a 2.4.8 component and an actual 2.4.13 component. Did the 2.4.13 fix make it more frequent? On Fri, Jun 12, 2015 at 12:49 PM Jeff Trawick traw...@gmail.com wrote: On Fri, Jun 12, 2015 at 12:35 PM, Jacob Perkins jacob.perk...@cpanel.net wrote: +1 to Noels comments. We have

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Rainer Jung
Am 12.06.2015 um 18:48 schrieb Jeff Trawick: On Fri, Jun 12, 2015 at 12:35 PM, Jacob Perkins jacob.perk...@cpanel.net mailto:jacob.perk...@cpanel.net wrote: +1 to Noels comments. We have a ton of servers running Apache 2.4 with our control panel. Doing this in a point release will

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jeff Trawick
On Fri, Jun 12, 2015 at 1:25 PM, Rainer Jung rainer.j...@kippdata.de wrote: Am 12.06.2015 um 19:12 schrieb William A Rowe Jr: Revision 1678233 - (view) (download) (annotate) - [select for diffs] Modified Thu May 7 16:26:43 2015 UTC (5 weeks, 1 day ago) by jim File length: 57106 byte(s) Diff

Re: [VOTE] Release Apache httpd 2.4.14 as GA

2015-06-12 Thread Jeff Trawick
On Fri, Jun 12, 2015 at 1:31 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Jun 12, 2015 at 1:25 PM, Rainer Jung rainer.j...@kippdata.de wrote: Am 12.06.2015 um 19:12 schrieb William A Rowe Jr: Revision 1678233 - (view) (download) (annotate) - [select for diffs] Modified Thu May 7

Re: svn commit: r1685052 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_config.c

2015-06-12 Thread William A Rowe Jr
On Fri, Jun 12, 2015 at 8:36 AM, Rainer Jung rainer.j...@kippdata.de wrote: Am 12.06.2015 um 13:49 schrieb Yann Ylavic: Hi Christophe, On Fri, Jun 12, 2015 at 1:26 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: should this warning at startup be an issue, why not just remove