[RESULT][VOTE] Release httpd-2.4.41

2019-08-12 Thread Daniel Ruggeri
Hi, all;    It is my pleasure to confirm that we have received enough votes to PASS the release of httpd-2.4.41! As always, I thank everyone for their diligence in testing this release and am very happy we caught the minor regression during 2.4.40 validation cycles to prevent a potentially

Re: [PATCH 63503] - Reverse proxy server - SIGSEGV

2019-08-12 Thread Eric Covener
On Mon, Aug 12, 2019 at 4:33 PM Don Poitras wrote: > > Eric, > I'm not sure what you're asking. The global mutex will cover the call to > init_conn_pool(), so there isn't a problem with worker->cp getting overlayed > if that's what you're thinking. I am thinking the opposite. Two threads

RE: [PATCH 63503] - Reverse proxy server - SIGSEGV

2019-08-12 Thread Don Poitras
Eric, I'm not sure what you're asking. The global mutex will cover the call to init_conn_pool(), so there isn't a problem with worker->cp getting overlayed if that's what you're thinking. The problem is that ap_proxy_initialize_worker() gets called repeatedly with the same worker pointer. The

Re: [PATCH 63503] - Reverse proxy server - SIGSEGV

2019-08-12 Thread Jim Jagielski
Via inspection this looks quite sane. > On Aug 12, 2019, at 3:24 PM, Eric Covener wrote: > > Hi Don, can you try this very similar patch? I applied yours to my > sandbox to get more context and made a few minor changes (including > pre-existing stuff that looked misleading) > >

Re: [PATCH 63503] - Reverse proxy server - SIGSEGV

2019-08-12 Thread Eric Covener
Hi Don, can you try this very similar patch? I applied yours to my sandbox to get more context and made a few minor changes (including pre-existing stuff that looked misleading) http://people.apache.org/~covener/trunk-proxy-segv.diff On Mon, Aug 12, 2019 at 2:43 PM Eric Covener wrote: > > On

Re: [PATCH 63503] - Reverse proxy server - SIGSEGV

2019-08-12 Thread Eric Covener
On Mon, Aug 12, 2019 at 2:37 PM Eric Covener wrote: > > On Mon, Aug 12, 2019 at 12:32 PM Don Poitras wrote: > > > > Eric, > > The global mutex only serializes concurrent calls to > > ap_proxy_initialize_worker(). The worker pool is also used when the > > proxy_handler() is called from a

Re: [PATCH 63503] - Reverse proxy server - SIGSEGV

2019-08-12 Thread Eric Covener
On Mon, Aug 12, 2019 at 12:32 PM Don Poitras wrote: > > Eric, > The global mutex only serializes concurrent calls to > ap_proxy_initialize_worker(). The worker pool is also used when the > proxy_handler() is called from a thread kicked off from a _previous_ call to >

Re: [VOTE] Release httpd-2.4.41

2019-08-12 Thread Rainer Jung
Am 09.08.2019 um 15:40 schrieb Daniel Ruggeri: Hi, all; Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.41: [X] +1: It's not just good, it's

RE: [PATCH 63503] - Reverse proxy server - SIGSEGV

2019-08-12 Thread Don Poitras
Eric, The global mutex only serializes concurrent calls to ap_proxy_initialize_worker(). The worker pool is also used when the proxy_handler() is called from a thread kicked off from a _previous_ call to ap_proxy_initialize_worker() . Turning on the pool concurrency check shows this

Re: [VOTE] Release httpd-2.4.41

2019-08-12 Thread Joe Orton
On Fri, Aug 09, 2019 at 08:40:38AM -0500, Daniel Ruggeri wrote: > Hi, all; > Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.41: >

Re: svn commit: r1864868 - /httpd/httpd/trunk/server/core_filters.c

2019-08-12 Thread Joe Orton
On Sat, Aug 10, 2019 at 11:58:44AM +0200, Marion & Christophe JAILLET wrote: > Hi all, > > I would appreciate some other eyes on the patch below. > I guess that that the fix is correct, but I don't know the possible > implication of the fix. > > As said in the commit description, -1 seems to be