On Wed, 2008-06-04 at 21:35 -0700, Joe Schaefer wrote:
Needs a comment in the source about why we're using
volatile here, but otherwise +1.
Done on both the trunk and v2_10 branch.
Any comment regarding my other patch about strict aliasing warnings?
--
Bojan
I propose we fix this as attached. I tested this on Fedora 9 and it
works OK. Opinions?
--
Bojan
Index: library/parser_multipart.c
===
--- library/parser_multipart.c (revision 663420)
+++ library/parser_multipart.c (working copy)
@@
--- Bojan Smojver [EMAIL PROTECTED] wrote:
I propose we fix this as attached. I tested this on
Fedora 9 and it
works OK. Opinions?
Needs a comment in the source about why we're using
volatile here, but otherwise +1.
On Wed, 2008-06-04 at 21:35 -0700, Joe Schaefer wrote:
Needs a comment in the source about why we're using
volatile here, but otherwise +1.
Ah, yes... Sorry. I also need to fix up the comment in the CHANGES file.
--
Bojan
Quoting Bojan Smojver [EMAIL PROTECTED]:
Looks like the offsetof() provided by the platform isn't being used.
Which in turn causes a lot of casting all over the place, which
creates the aliasing problem? Maybe?
Nah, it isn't that... Fails just the same with native offsetof() :-(
--
Bojan
On Sun, 2006-06-11 at 20:31 -0400, Joe Schaefer wrote:
APR_RING_UNSPLICE(f, l, link);
APR_RING_SPLICE_TAIL(out-list, f, l, apr_bucket, link);
This is the right approach, I think. But the person who'd be
in the best place to test/commit it is Bojan. Just be sure
to
Quoting Philip M. Gollucci [EMAIL PROTECTED]:
Seems to be Fedora Core X specific.
Happens on x84_64 as well and with 2.07. Rebuilding the package in
Fedora Extras 5 now.
--
Bojan
Bojan Smojver wrote:
Quoting Joe Schaefer [EMAIL PROTECTED]:
At least now it's a bit clearer why the no-strict-aliasing
optimization is getting confused ;-)
Hey, speak for yourself ;-)
FreeBSD 6.1-RELEASE
gcc version 4.1.2 20060526 (prerelease)
gcc version 3.4.4 20050518
default
On Thu, 2006-06-01 at 02:34 -0700, Philip M. Gollucci wrote:
Seems to be Fedora Core X specific.
Yeah, very possible.
Should we figure out how to re-write the loop so it doesn't matter,
add a prereq check in build/version_check.pl, or just leave it ?
I maintain Fedora Extras libapreq2
Quoting Joe Schaefer [EMAIL PROTECTED]:
At least now it's a bit clearer why the no-strict-aliasing
optimization is getting confused ;-)
Hey, speak for yourself ;-)
--
Bojan
10 matches
Mail list logo
