Re: mod_python 3.2.8 available for testing
Yup. Much better with that one: ## Ran 6 tests in 91.047s OK ## You have my +1 (even though you weren't waiting for it) And my merged util.py also passes the test suite, which is what I really wanted to know. -- Mike Looijmans Philips Natlab / Topic Automation Nicolas Lehuen wrote: Yup, the SVN trunk currently contains tests that fail on 3.2.8 (Graham added some features and their unit test in the trunk), but you can test the 3.2.8 release against the 3.2.8 test suite (available from https://svn.apache.org/repos/asf/httpd/mod_python/tags/release-3-2-8 ) and you won't see any problems. Regards, Nicolas 2006/2/22, Mike Looijmans [EMAIL PROTECTED]: I get failing tests on WinXP-sp2, apache 2.0.54, python 2.4.2. This may be because the test suite is looking for things not there yet. Put the 3.2.8 binary distribution on my system and did a svn update to get the latest test suite. When running the tests, I got the following failures (can we do something about the readability of the output): == FAIL: test_req_auth_type (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 661, in test_req_auth_type self.fail(`rsp`) AssertionError: '\npre\nMod_python error: PythonAuthenHandler tests::req_auth_type\n\nTraceback (most recent call last):\n\n File C:\\Python24\\Lib\\site- packages\\mod_python\\apache.py, line 299, in HandlerDispatch\n result = object(req)\n\n File C:/source/mod_python/test/htdocs/tests.py, line 609, in req _auth_type\nif req.auth_type() != dummy:\n\nAttributeError: \'mp_request\' object has no attribute \'auth_type\'\n\n/pre\n' == FAIL: test_req_construct_url (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 753, in test_req_construct_url self.fail(construct_url) AssertionError: construct_url == FAIL: test_req_handler (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 1009, in test_req_handler self.fail(`rsp`) AssertionError: '\npre\nMod_python error: PythonFixupHandler tests::req_handler\n\nTraceback (most recent call last):\n\n File C:\\Python24\\Lib\\site-pac kages\\mod_python\\apache.py, line 299, in HandlerDispatch\nresult = object(req)\n\n File C:/source/mod_python/test/htdocs/tests.py, line 770, in req_ha ndler\nreq.handler = mod_python\n\nTypeError: attribute \'handler\' of \'mp_request\' objects is not writable\n\n/pre\n' == FAIL: test_trans (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 1402, in test_trans self.fail(`rsp`) AssertionError: ' #\r\n # \r\n # Licensed under the Apache License, Version 2.0 (the License); you\r\n # may not use this file except in compliance with the L icense. You\r\n # may obtain a copy of the License at\r\n #\r\n # http://www.apache.org/licenses/LICENSE-2.0\r\n #\r\n # Unless required by applicable law or agreed to in writing, software\r\n # distributed under the License is distributed on an AS IS BASIS,\r\n # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, e ither express or\r\n # implied. See the License for the specific language governing\r\n # permissions and limitations under the License.\r\n #\r\n #\r\n # $Id: tests.py 379638 2006-02-22 00:41:51Z jgallacher $\r\n #\r\n\r\n# mod_python tests\r\n\r\nfrom __future__ import generators\r\nfrom mod_python.python22 import * \r\n\r\nfrom mod_python import apache\r\nimport unittest\r\nimport re\r\nimport time\r\nimport os\r\nimport cStringIO\r\n\r\n# This is used for mod_python.publi sher security tests\r\n_SECRET_PASSWORD = \'root\'\r\n__ANSWER = 42\r\n\r\nclass SimpleTestCase(unittest.TestCase):\r\n\r\ndef __init__(self, methodName, re q):\r\nunittest.TestCase.__init__(self, methodName)\r\n self.req = req\r\n\r\ndef test_apache_log_error(self):\r\n\r\n s = self.req.se rver\r\napache.log_error(Testing apache.log_error():, apache.APLOG_INFO, s)\r\napache.log_error(xEMERGx, apache.APLOG_EMERG, s)\r\na pache.log_error(xALERTx, apache.APLOG_ALERT, s)\r\n apache.log_error(xCRITx, apache.APLOG_CRIT, s)\r\n apache.log_error(xERRx, apache.APLOG_ ERR, s)\r\napache.log_error(xWARNINGx, apache.APLOG_WARNING, s)\r\napache.log_error(xNOTICEx, apache.APLOG_NOTICE, s)\r\n apache.log_ error(xINFOx, apache.APLOG_INFO, s)\r\n apache.log_error(xDEBUGx, apache.APLOG_DEBUG, s)\r\n\r\n# see what\'s in the log now\r\nf =
Re: mod_python 3.2.8 available for testing
Oh crap. I changed the License information in htdocs/tests.py and thought, Gee this is a simple change. No need to run the unit tests before I commit the changes. Wrong. As it happens one of the unit tests looks at the first line of htdocs/tests.py, which of course is now different. I've fixed it. As penance I shall wear the Dunce Cap and stand in the corner for the rest of the day. Mike Looijmans wrote: I get failing tests on WinXP-sp2, apache 2.0.54, python 2.4.2. This may be because the test suite is looking for things not there yet. Put the 3.2.8 binary distribution on my system and did a svn update to get the latest test suite. When running the tests, I got the following failures (can we do something about the readability of the output): It's ugly because it's dumping all of htdocs/tests.py in the traceback. Best way to get a clean output is to make sure the test passes. ;) Jim
Re: mod_python 3.2.8 available for testing
Indeed :) 2006/2/22, Ron Reisor [EMAIL PROTECTED]: I know you're going ahead with 3.2.8 already, but I thought this would be interesting: +1 Mac OS X 10.4.5 Intel Core Duo, apache 2.0.55 mpm-prefork, python 2.4.2 cheers, Ron Ron Reisor [EMAIL PROTECTED] (RWR3) University of Delaware Information Technologies/Network and Systems Services Computing Center/192 South Chapel Street/Newark DE, 19716 pgp finger print: 0D 73 06 6F D3 6A 99 D3 F5 D5 6E FF 3B B9 7C 2C
Re: mod_python 3.2.8 available for testing
On 21/02/2006, at 7:08 AM, Jim Gallacher wrote: The Apache 2.2 support will likely go into the 3.2.9 bugfix release. We just wanted to get the security problem out of the way first. Jim, if we are again going to aim for a bug rollup release for 3.2.9 do I need to stop or hold off on doing any substantial changes to trunk, or are you going to selectively backport changes from trunk which would be appropriate, meaning that I can keep going for it. Got about half a dozen reasonably major changes sitting in my old play source directory that I was starting to look at pushing into the repository before I loose where I was up to. This includes support for dynamic filters, setting of req.handler, mod_include/ssi, fixes for server.get_config () and new server.get_options(), plus other fixes. Graham
Re: mod_python 3.2.8 available for testing
Graham Dumpleton wrote: On 21/02/2006, at 7:08 AM, Jim Gallacher wrote: The Apache 2.2 support will likely go into the 3.2.9 bugfix release. We just wanted to get the security problem out of the way first. Jim, if we are again going to aim for a bug rollup release for 3.2.9 do I need to stop or hold off on doing any substantial changes to trunk, or are you going to selectively backport changes from trunk which would be appropriate, meaning that I can keep going for it. Keep going. My understanding of svn is that we can merge a particular revision in one branch into another branch. In the worst case we can always grab a diff between 2 revisions, before and after a particular fix, and use that to patch the 3.2.x branch. Either way should work fairly well as long as each commit is specific to a particular issue. I'm sure it's obvious that we don't want to make a bulk change that affects a large number of issues at the same time anyway, so I don't think we need to change anything in the way we've been working. Got about half a dozen reasonably major changes sitting in my old play source directory that I was starting to look at pushing into the repository before I loose where I was up to. This includes support for dynamic filters, setting of req.handler, mod_include/ssi, fixes for server.get_config () and new server.get_options(), plus other fixes. We have our stable branch, we know the issues we want to fix in a 3.2.9 bug release, and so there shouldn't be any problems committing new stuff into trunk. Jim
Re: mod_python 3.2.8 available for testing
I get failing tests on WinXP-sp2, apache 2.0.54, python 2.4.2. This may be because the test suite is looking for things not there yet. Put the 3.2.8 binary distribution on my system and did a svn update to get the latest test suite. When running the tests, I got the following failures (can we do something about the readability of the output): == FAIL: test_req_auth_type (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 661, in test_req_auth_type self.fail(`rsp`) AssertionError: '\npre\nMod_python error: PythonAuthenHandler tests::req_auth_type\n\nTraceback (most recent call last):\n\n File C:\\Python24\\Lib\\site- packages\\mod_python\\apache.py, line 299, in HandlerDispatch\n result = object(req)\n\n File C:/source/mod_python/test/htdocs/tests.py, line 609, in req _auth_type\nif req.auth_type() != dummy:\n\nAttributeError: \'mp_request\' object has no attribute \'auth_type\'\n\n/pre\n' == FAIL: test_req_construct_url (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 753, in test_req_construct_url self.fail(construct_url) AssertionError: construct_url == FAIL: test_req_handler (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 1009, in test_req_handler self.fail(`rsp`) AssertionError: '\npre\nMod_python error: PythonFixupHandler tests::req_handler\n\nTraceback (most recent call last):\n\n File C:\\Python24\\Lib\\site-pac kages\\mod_python\\apache.py, line 299, in HandlerDispatch\nresult = object(req)\n\n File C:/source/mod_python/test/htdocs/tests.py, line 770, in req_ha ndler\nreq.handler = mod_python\n\nTypeError: attribute \'handler\' of \'mp_request\' objects is not writable\n\n/pre\n' == FAIL: test_trans (__main__.PerRequestTestCase) -- Traceback (most recent call last): File test.py, line 1402, in test_trans self.fail(`rsp`) AssertionError: ' #\r\n # \r\n # Licensed under the Apache License, Version 2.0 (the License); you\r\n # may not use this file except in compliance with the L icense. You\r\n # may obtain a copy of the License at\r\n #\r\n # http://www.apache.org/licenses/LICENSE-2.0\r\n #\r\n # Unless required by applicable law or agreed to in writing, software\r\n # distributed under the License is distributed on an AS IS BASIS,\r\n # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, e ither express or\r\n # implied. See the License for the specific language governing\r\n # permissions and limitations under the License.\r\n #\r\n #\r\n # $Id: tests.py 379638 2006-02-22 00:41:51Z jgallacher $\r\n #\r\n\r\n# mod_python tests\r\n\r\nfrom __future__ import generators\r\nfrom mod_python.python22 import * \r\n\r\nfrom mod_python import apache\r\nimport unittest\r\nimport re\r\nimport time\r\nimport os\r\nimport cStringIO\r\n\r\n# This is used for mod_python.publi sher security tests\r\n_SECRET_PASSWORD = \'root\'\r\n__ANSWER = 42\r\n\r\nclass SimpleTestCase(unittest.TestCase):\r\n\r\ndef __init__(self, methodName, re q):\r\nunittest.TestCase.__init__(self, methodName)\r\n self.req = req\r\n\r\ndef test_apache_log_error(self):\r\n\r\n s = self.req.se rver\r\napache.log_error(Testing apache.log_error():, apache.APLOG_INFO, s)\r\napache.log_error(xEMERGx, apache.APLOG_EMERG, s)\r\na pache.log_error(xALERTx, apache.APLOG_ALERT, s)\r\n apache.log_error(xCRITx, apache.APLOG_CRIT, s)\r\n apache.log_error(xERRx, apache.APLOG_ ERR, s)\r\napache.log_error(xWARNINGx, apache.APLOG_WARNING, s)\r\napache.log_error(xNOTICEx, apache.APLOG_NOTICE, s)\r\n apache.log_ error(xINFOx, apache.APLOG_INFO, s)\r\n apache.log_error(xDEBUGx, apache.APLOG_DEBUG, s)\r\n\r\n# see what\'s in the log now\r\nf = o pen(%s/logs/error_log % apache.server_root())\r\n# for some reason re doesn\'t like \\n, why?\r\nimport string\r\n log = .join(map(st ring.strip, f.readlines()))\r\nf.close()\r\n\r\nif not re.search(xEMERGx.*xALERTx.*xCRITx.*xERRx.*xWARNINGx.*xNOTICEx.*xINFOx.*xDEBUGx, log):\ r\nself.fail(Could not find test messages in error_log)\r\n\r\n\r\ndef test_apache_table(self):\r\n\r\nlog = self.req.log_ error\r\n\r\nlog(Testing table object.)\r\n\r\n# tests borrowed from Python test suite for dict\r\n _test_table()\r\n\r\n#
Re: mod_python 3.2.8 available for testing
Oops, I've sent this mail a bit too fast... As usual, all three binary versions are available here : http://nicolas.lehuen.com/download/mod_python/ Regards, Nicolas 2006/2/20, Nicolas Lehuen [EMAIL PROTECTED]: +1 mod_python 3.2.8 + Apache/2.0.55 + Python/2.2.3 + Windows 2000 SP4 +1 mod_python 3.2.8 + Apache/2.0.55 + ActivePython/2.3.5 + Windows 2000 SP4 +1 mod_python 3.2.8 + Apache/2.0.55 + ActivePython/2.4.2 + Windows XP SP2
Re: mod_python 3.2.8 available for testing
Hi Oden, The Apache 2.2 support will likely go into the 3.2.9 bugfix release. We just wanted to get the security problem out of the way first. Jim Oden Eriksson wrote: +1 Mandriva Linux Cooker (x86_64), apache 2.2.0 mpm-prefork, python-2.4.2 Note that I applied this change: http://issues.apache.org/jira/browse/MODPYTHON-78
Re: mod_python 3.2.8 available for testing
+1 Mac OS X 10.4, apache 2.0.55 mpm-worker, python 2.3.5 I used the 3.2.x branch out of SVN rather than the tar ball though. Graham
Re: mod_python 3.2.8 available for testing
+1 Mandriva Linux Cooker (x86_64), apache 2.2.0 mpm-prefork, python-2.4.2 Note that I applied this change: http://issues.apache.org/jira/browse/MODPYTHON-78 -- Regards // Oden Eriksson Mandriva: http://www.mandriva.com NUX: http://li.nux.se
Re: mod_python 3.2.8 available for testing
+1 Debian sid, apache 2.0.55 mpm-prefork, python 2.3.5
Re: mod_python 3.2.8 available for testing
+1 FreeBSD 6.0, apache 2.0.55 mpm-prefork, python 2.4.2
