Re: IDE setup for code formatting

2019-12-22 Thread Vinoth Chandar
+1 on 1/3 and improving the contributing guide. But on 2, IMO it would be overloading PULL_REQUEST_TEMPLATE. Bigger point here is: We need a fully automated way of formatting code either using IDE or using something like spotless. I pulled the checkstyle rules into intellij and even then I notice

Re:IDE setup for code formatting

2019-12-22 Thread lamberken
Hi Vinoth, Here are some of my points: 1, When developers are not familiar with checkstyle rules, they feel uncomfortable. I think its a good idea to make the instructions on contributing guide work with the checkstyle rules we already have. 2, We can also prompt users in the PULL_REQUEST_

IDE setup for code formatting

2019-12-22 Thread Vinoth Chandar
Hello all, I know a bunch of work has happened to format the code base, closer to what other project are doing.. While working through some checkstyle violations today, I noticed that the IDE formatting is now out of date with the checkstyle enforced? Manually fixing these checkstyle issues are n

Re: Any one can help to add me to the project contributor group?

2019-12-22 Thread Vinoth Chandar
Hello, You should have perms now to claim JIRAs or create a new RFC say. Welcome aboard! On Sun, Dec 22, 2019 at 7:21 AM zhenyuan wei wrote: > Hello, > I've read most src code&docs, and very happy to make some contributions > to code&docs. Any one can help to add me to the project contribu

Any one can help to add me to the project contributor group?

2019-12-22 Thread zhenyuan wei
Hello, I've read most src code&docs, and very happy to make some contributions to code&docs. Any one can help to add me to the project contributor group? I've been working in the big data industry for many years.I've recently become interested in incremental data frameworks, here is my acco