[RESULT] [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread Bhavani Sudha
Hello all, I'm happy to announce that we have unanimously approved this release. There are 9 approving votes, 5 of which are binding: * Vino Yang (Binding) * Leesf (Binding) * Vinoth (Binding) * Balaji (Binding) * Sudha (Binding) * Trevor Zhang * Sivabalan * Gary Li * Raymond There are no disa

Re: [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread Bhavani Sudha
Thank you all. Closing the voting as we have got sufficient votes. Will send out tally in a separate email. On Sat, Aug 22, 2020 at 8:34 PM Shiyan Xu wrote: > Submitted the PR to update testing commands > https://github.com/apache/hudi/pull/2010 > > +1 (non-binding) > > - packaging ok > - local

Re: [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread Shiyan Xu
Submitted the PR to update testing commands https://github.com/apache/hudi/pull/2010 +1 (non-binding) - packaging ok - local tests ok On Sat, Aug 22, 2020 at 5:07 PM Udit Mehrotra wrote: > +1 (non-binding) > > - Compiles successfully > - Ran tests on EMR with bunch of upserts/delete commits,

Re: [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread Udit Mehrotra
+1 (non-binding) - Compiles successfully - Ran tests on EMR with bunch of upserts/delete commits, and verified query results through spark datasource, spark-sql, hive and presto for COW/MOR tables - Ran insert/bulk insert/upserts on 100GB tpcds table - Ran release validation scripts successfully -

Re: [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread Bhavani Sudha
+1 (binding) Downloaded tar and verified compile [OK] Run integration test locally. [OK] Run a few tests in IDE. [OK] Run quickstart [OK] Verify NOTICE and LICENSE exists [OK] Check Checksum [OK] Check no Binary files in source release [OK] Rat Check Passed [OK] On Sat, Aug 22, 2020 at 1:4

Re: [DISCUSS] Codestyle: force multiline indentation

2020-08-22 Thread Shiyan Xu
It can be up to the individual to use the IDE formatter or not, as long as there is a tool to help enforce Checkstyle rules. For people who use IDE formatter, importing Checkstyle.xml as a format scheme does not fully control the formatter's behavior, that's why IDE sometimes gets in the way. But m

Re: [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread Balaji Varadarajan
+1(binding) 1. Ran long running structured streaming writes on fake data and verified compactions and ingestion is happening without errors. 2. Ran both scala and python based quickstart without any errors. There was an issue in the documented quickstart steps (not in hudi) for python example. Will

Re: [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread Vinoth Chandar
+1 (binding) - Ran the rc checks, I typically do - Tested a smoke test on both cow, mor tables - by running lot commits over longer period of time, - verifying the state of the dataset - count validation match. On Sat, Aug 22, 2020 at 6:08 AM leesf wrote: > +1 (binding) > - mvn clean

Re: [DISCUSS] Support for `_hoodie_record_key` as a virtual column

2020-08-22 Thread Sivabalan
Aah, yes. That’s right. On Sat, Aug 22, 2020 at 2:43 AM Vinoth Chandar wrote: > All of the remaining meta fields compress very very nicely. They have > > almost no overhead. > > > > On Fri, Aug 21, 2020 at 12:00 PM Abhishek Modi > > wrote: > > > > > @sivabalan the current plan is to only add th

Re: [VOTE] Release 0.6.0, release candidate #1

2020-08-22 Thread leesf
+1 (binding) - mvn clean package -DskipTests OK - ran quickstart guide OK (still get the exception ERROR view.PriorityBasedFileSystemView: Got error running preferred function. Trying secondary org.apache.hudi.exception.HoodieRemoteException: 192.168.1.102:56544 failed to respond at org.apache.hudi

Re: [DISCUSS] Codestyle: force multiline indentation

2020-08-22 Thread vino yang
Hi vc, Yes, this part of the practice may have different preferences for different developers. I have never opened the IDE's automatic formatting, nor have I used the IDE's formatting functions artificially. Because I have participated in multiple open source communities, each open source communit

Re: Incremental query on partition column

2020-08-22 Thread David Rosalia
Good moring Balaji, Vinoth, Thank you both for your replies. I agree that this is a topic that should come up more often and I am surprised that so little is said about this. The option B in your mail (writing the delete marker also in the historical records) sounds like a good option, but th