Re: FIX?: protected static ThreadLocal localSqlMapSession = new ThreadLocal();

2008-07-11 Thread Clinton Begin
Here's a quick summary that we could add to the docs, and maybe offer a simpler config for... LOCAL_READ_WRITE (serializable=false, readOnly=false) SHARED_READ_ONLY (serializable=false, readOnly=true) SHARED_READ_WRITE (serializable=true, readOnly=false) Sorry for the dip-switch like interface...

Re: FIX?: protected static ThreadLocal localSqlMapSession = new ThreadLocal();

2008-07-11 Thread Vic Cekvenich
(read-only=false does not cache). So serialize="true" works, but not all the time. I spent a few hours and could not find a pattern of when/why it works sometimes and sometimes not. The code patch works 100% of time for those that want that effect. I propose that in addition to docs, the code

Re: FIX?: protected static ThreadLocal localSqlMapSession = new ThreadLocal();

2008-07-11 Thread Vic Cekvenich
Docs I think say make read-only false, not leave true. So this is what I have: which works in most cases, but sometimes it does not. So what is it read-only=false as per docs or what you said? tia, .V Larry Meadors wrote: Make the cache read-only and serializable, and it will be container wi

Re: FIX?: protected static ThreadLocal localSqlMapSession = new ThreadLocal();

2008-07-11 Thread Vic Cekvenich
I just tried that and it seems to work, I will do further testing. (It be nice to use main trunk and not my fork). I propose a documentation patch (pg45 bottom): Before: Read-Only cache will not be serilized(ther's no benefit) After (words to the effect). iBatis caching defaults to user se

Re: FIX?: protected static ThreadLocal localSqlMapSession = new ThreadLocal();

2008-07-11 Thread Clinton Begin
This is not the right fix for this problem (I suggest changing back those other deployments). Make the cache read-only or serializable... either will work. Note that simply making it read-only and then modifying the data (i.e. lying to the framework) will get you into trouble. The two settings a

Re: FIX?: protected static ThreadLocal localSqlMapSession = new ThreadLocal();

2008-07-11 Thread Larry Meadors
Make the cache read-only and serializable, and it will be container wide. Larry On Fri, Jul 11, 2008 at 9:56 AM, Vic Cekvenich <[EMAIL PROTECTED]> wrote: > Before: > protected ThreadLocal localSqlMapSession = new ThreadLocal(); > After: > protected static ThreadLocal localSqlMapSession = new Thre

FIX?: protected static ThreadLocal localSqlMapSession = new ThreadLocal();

2008-07-11 Thread Vic Cekvenich
Before: protected ThreadLocal localSqlMapSession = new ThreadLocal(); After: protected static ThreadLocal localSqlMapSession = new ThreadLocal(); in SqlMapClientImpl Rationale: People(me) expect the cache to be "container"(war) wide, and not "session" based. Ex: I have user1 pull put client 101,