Re: Open a new branch for row-delete feature ?

2020-03-30 Thread OpenInx
Hi Ryan The reason I suggest to open a new dev branch for row-delete development is: we will split the whole feature into many small issues and each issue will have a pull request with appropriate length of code so the contributors/reviewers can discuss one point each time and make this feature

Re: Open a new branch for row-delete feature ?

2020-03-30 Thread Ryan Blue
Sorry, I didn't address the suggestion to add a Flink branch as well. The work needed for the Flink sink is to remove parts that are specific to Netflix, so I'm not sure what the rationale for a branch would be. Is there a reason why this can't be done in master, but requires a shared branch? If

Re: Open a new branch for row-delete feature ?

2020-03-30 Thread Ryan Blue
I think we will eventually may want a branch, but I think it is too early to create one now. Branches are expensive. They require maintenance to stay in sync with master, usually copying changes from master into the branch with updates. Updating the changes to master for the branch is more

Re: Open a new branch for row-delete feature ?

2020-03-30 Thread Gautam
Thanks for bringing this up OpenInx. That's a great idea: to open a separate branch for row-level deletes. I would like to help support/contribute/review this as well. If there are sub-tasks you guys have identified that can be added to https://github.com/apache/incubator-iceberg/milestone/4 we

Re: Open a new branch for row-delete feature ?

2020-03-30 Thread Junjie Chen
+1 to create the branch. Some row-level delete subtasks must be based on the sequence number as well as end to end tests. On Fri, Mar 27, 2020 at 4:42 PM OpenInx wrote: > Dear Dev: > > Tuesday, we had a sync meeting. and discussed about the things: > 1. cut the 0.8.0 release; >