Re: Code inspection

2019-03-15 Thread Nikolay Izhikov
+1 to enable code style checks in compile time. We can add option to disable maven codestyle profile with some environment variable. Anyone who want violate common project rules in their local branch can set this variable and write some nasty code before push :) пт, 15 марта 2019 г., 9:40 Maxim

[jira] [Created] (IGNITE-11549) Replace array of AtomicLongs with AtomicLongArray

2019-03-15 Thread Eduard Shangareev (JIRA)
Eduard Shangareev created IGNITE-11549: -- Summary: Replace array of AtomicLongs with AtomicLongArray Key: IGNITE-11549 URL: https://issues.apache.org/jira/browse/IGNITE-11549 Project: Ignite

[jira] [Created] (IGNITE-11550) Destroy cache in shared cache group could leave garbage in partitions

2019-03-15 Thread Eduard Shangareev (JIRA)
Eduard Shangareev created IGNITE-11550: -- Summary: Destroy cache in shared cache group could leave garbage in partitions Key: IGNITE-11550 URL: https://issues.apache.org/jira/browse/IGNITE-11550 P

Re: Consistent ID specification from previous random UUID

2019-03-15 Thread Павлухин Иван
Hi Dmitriy, It looks like that case with only one node in working directory is covered. But what is problem is solved? As I understand before fix in such case node after restart uses proper folder and proper consistentId. After fix we can specify automatically generated UUID in configuration and e

[jira] [Created] (IGNITE-11551) SQL: Document LOCAL_SQL_QUERY_HISTORY

2019-03-15 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-11551: Summary: SQL: Document LOCAL_SQL_QUERY_HISTORY Key: IGNITE-11551 URL: https://issues.apache.org/jira/browse/IGNITE-11551 Project: Ignite Issue Type:

Re: Code inspection

2019-03-15 Thread Павлухин Иван
Maxim, > As far as I understand your case, you want to fix all code styles issues right before getting the final TC results. Right? ... Actually, I mostly worry about accidental failures. For simple tasks my workflow looks like: 1. Create a branch. 2. Write some code lines and tests. 3. Run the m

Re: Code inspection

2019-03-15 Thread Павлухин Иван
I agree to gather some votes according to Maxim's proposal. Personally, I will not put my vote here. Both options will work for me today. But I would like to say a bit about agility. As I said both options sounds fine for me today. And I believe that we can switch from one to another easily in fu

Re: [MTCGA]: new failures in builds [3218097] needs to be handled

2019-03-15 Thread Dmitriy Pavlov
Igniters, who knows why package name (last subpackage) is added to test name by TeamCity? It makes Bot crazy cause it thinks 'near.IgniteCacheDistributedPartitionQueryNodeRestartsSelfTest' is new test, but actual test name is IgniteCacheDistributedPar titionQueryNodeRestartsSelfTest. How can we fi

Re: [MTCGA]: new failures in builds [3218097] needs to be handled

2019-03-15 Thread Павлухин Иван
Dmitry, I already saw such names. My bet here is that such name occurs when whole test class failed to start. Test class is IgniteCacheDistributedPartitionQueryNodeRestartsSelfTest. And no test methods were started. It seems that TC simply takes 2 last parts of fully qualified name as a test name.

[jira] [Created] (IGNITE-11552) ODBC: Error while trying to get params meta for request with ODBC escape symbols

2019-03-15 Thread Igor Sapego (JIRA)
Igor Sapego created IGNITE-11552: Summary: ODBC: Error while trying to get params meta for request with ODBC escape symbols Key: IGNITE-11552 URL: https://issues.apache.org/jira/browse/IGNITE-11552 Pr

Re: Ignite 2.8 Release: Time & Scope & Release manager

2019-03-15 Thread Dmitriy Pavlov
Hi everybody, I had a private talk with Denis, Vladimir, and Alex G. As far I understood the problem with the master based release is not only 2 or more faulty commits, but 1040 commits we have since 2.7. All of these commits need to be tested (unfortunately not all QA steps are visible to the com

Re: Consistent ID specification from previous random UUID

2019-03-15 Thread Dmitriy Pavlov
Hi Ivan, yes, after the restart we need to re-use both folder name and UUID as consistent ID. About returning exact directory name: I'm just guessing here, but the persistent store is not the only folder, there are several more folders, e.g. binary-meta, etc. About several nodes reusing same root

Re: Code inspection

2019-03-15 Thread Dmitriy Pavlov
Hi Igniters, I see that a new TeamCity is released: Version: 2018.2.3. Probably it could solve recently introduced problem related to: Unexpected error during build messages processing in TeamCity; Peter I., could you please check? Sincerely, Dmitriy Pavlov пт, 15 мар. 2019 г. в 12:04, Павлухи

[jira] [Created] (IGNITE-11553) Ignite metrics to Prometheus.io

2019-03-15 Thread Stephen Darlington (JIRA)
Stephen Darlington created IGNITE-11553: --- Summary: Ignite metrics to Prometheus.io Key: IGNITE-11553 URL: https://issues.apache.org/jira/browse/IGNITE-11553 Project: Ignite Issue Type:

Re: Peer review: Victory over Patch Available debt

2019-03-15 Thread Dmitriy Pavlov
Hi Igniters, sorry for the late reply. Because this process time to time causes questions, I decided to add a couple of words to our wiki. I've added topics about peer review to HTC https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-PeerReviewandLGTM Actually, i

[jira] [Created] (IGNITE-11554) Create detailed documentation for peerClassLoading with places where and how it can be used

2019-03-15 Thread Evgenii Zhuravlev (JIRA)
Evgenii Zhuravlev created IGNITE-11554: -- Summary: Create detailed documentation for peerClassLoading with places where and how it can be used Key: IGNITE-11554 URL: https://issues.apache.org/jira/browse/IGNIT

Re: Ignite 2.8 Release: Time & Scope & Release manager

2019-03-15 Thread Denis Magda
Dmitriy, Thanks for putting this together and sharing the results of our conversation in a smaller group. Igniters, if there are no major objections I would suggest us kicking off release related procedures early next week. - Denis On Fri, Mar 15, 2019 at 6:05 AM Dmitriy Pavlov wrote: > Hi ev

[MTCGA]: new failures in builds [3322121] needs to be handled

2019-03-15 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. If your changes can lead to this failure(s): We're grateful that you were a volunteer to make the contribution to this project, but things change and you may no longer be able to finalize

DataRegionConfiguration is a FINAL class but could we make it not final?

2019-03-15 Thread hlopez
Is there a very good reason why the DataRegionConfiguration is a *FINAL* class? I would like to be able to extend the DataRegionConfiguration. In my extended class I would like to add a new method for the *setMaxSize()* and *setInitialSize()* for example where the input is of the type *org.spri

[MTCGA]: new failures in builds [3324578] needs to be handled

2019-03-15 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. If your changes can lead to this failure(s): We're grateful that you were a volunteer to make the contribution to this project, but things change and you may no longer be able to finalize