Re: [MTCGA]: new failures in builds [5994077, 5994075] needs to be handled

2021-05-19 Thread Данилов Семён
Hi! The fix was merged yesterday and the JDBC driver suite https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_JdbcDriver?branch=%3Cdefault%3E=overview=builds#all-projects is stable again. Semyon. 19.05.2021, 14:07, "Ilya Kasnacheev" : > Hello! > > I suggest that you may revert

Re: AggregateUnionTransposeRule fails when some inputs have unique grouping key

2021-05-19 Thread Vladimir Ozerov
Hi Pavel, Yes, I missed the list, sorry. ср, 19 мая 2021 г. в 14:40, Pavel Tupitsyn : > Hi Vladimir, > > Looks like this message is for d...@calcite.apache.org, not > dev@ignite.apache.org, > or am I mistaken? > > On Wed, May 19, 2021 at 2:25 PM Vladimir Ozerov > wrote: > > > Hi, > > > > The

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Ilya Kasnacheev
Hello! We don't have to do it in toBinary() - we may preserve its behavior if you like, and only do that transition for Cache API, where additional support may be added to e.g. org.apache.ignite.internal.processors.cache.binary.CacheObjectBinaryProcessorImpl Regards, -- Ilya Kasnacheev ср,

Re: [VOTE][EXTENSION] Release Apache Ignite spring-data-all-ext extensions 1.0.0 RC3

2021-05-19 Thread Nikita Amelchev
Hello, Ilya. Thank you for feedback. Yes, the vote was cancelled. I have published results. I will create issues and prepare RC4 after fixing them. ср, 19 мая 2021 г., 12:58 Ilya Kasnacheev : > Hello! > > Do I understand correctly that voting did not succeed due to insufficient >

Re: AggregateUnionTransposeRule fails when some inputs have unique grouping key

2021-05-19 Thread Pavel Tupitsyn
Hi Vladimir, Looks like this message is for d...@calcite.apache.org, not dev@ignite.apache.org, or am I mistaken? On Wed, May 19, 2021 at 2:25 PM Vladimir Ozerov wrote: > Hi, > > The AggregateUnionTransposeRule attempts to push the Aggregate below the > Union. > > Before: > Aggregate[group=$0,

[CANCEL] [VOTE] Release Apache Ignite performance-statistics-ext extension 1.0.0 RC3

2021-05-19 Thread Nikita Amelchev
Folks, Canceling due to insufficient participation. The release source package and maven building will be revisited. I will prepare RC4 after fixing issues.

[CANCEL] [VOTE] Release Apache Ignite spring-data-all-ext extensions 1.0.0 RC3

2021-05-19 Thread Nikita Amelchev
Folks, Canceling due to insufficient participation. The release source package and maven building will be revisited. Spring examples will be copied to the Spring 2.2 module. I will prepare RC4 after fixing issues.

AggregateUnionTransposeRule fails when some inputs have unique grouping key

2021-05-19 Thread Vladimir Ozerov
Hi, The AggregateUnionTransposeRule attempts to push the Aggregate below the Union. Before: Aggregate[group=$0, agg=SUM($1] Union[all] Input1 Input2 After: Aggregate[group=$0, agg=SUM($1] Union[all] Aggregate[group=$0, agg=SUM($1] Input1 Aggregate[group=$0, agg=SUM($1]

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Nikolay Izhikov
Ilya. Actually, current behaviour described even in documentation [1] > Note that not all objects are converted to the binary object format. The > following classes are never converted (e.g., the toBinary(Object) method > returns the original object, and instances of these classes are stored

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Ilya Kasnacheev
Hello! Why do you need to take compatibility into account here at all? You can start writing entries to cache in new format while reading both old and new format. I consider returning Object[] instead of ConcreteType[] a bug so it's totally OK to start returning the "better" ConcreteType[]

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Nikolay Izhikov
Ilya, > Maybe we should just automate that, e.g., whenever user stores Type[], always > store one-field ArrayWrapper object, and automatically unwrap it on get() Yes, I’m talking about this opportunity from the beginning of the thread. > 1. Implement binary serialization that correctly Ser

Re: [MTCGA]: new failures in builds [5994077, 5994075] needs to be handled

2021-05-19 Thread Ilya Kasnacheev
Hello! I suggest that you may revert this change right away, and reopen the ticket. Then patch author (Semyon) can take a look. Regards, -- Ilya Kasnacheev пн, 17 мая 2021 г. в 14:16, Maxim Muzafarov : > Folks, > > All tests passed successfully in the branch with reverted commit [1]: > >

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Ilya Kasnacheev
Hello! Yes, it does not look pretty, I agree. But I'm saying that I've not encountered this issue on the user list before, and it can probably be easily countered by storing some one-field ArrayWrapper object in the cache as value. Maybe we should just automate that, e.g., whenever user stores

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Nikolay Izhikov
Igniters. Just to clarify the issue: ``` public class BinaryObjectTest extends GridCommonAbstractTest { /** */ @Test public void testArray() throws Exception { Ignite ign = startGrid(); IgniteCache cache = ign.createCache("my-cache"); cache.put(1, new

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Nikolay Izhikov
Thanks, Ilya. Can you put more context on this? I don’t familiar with these issues. > 19 мая 2021 г., в 13:02, Ilya Kasnacheev > написал(а): > > Hello! > > Obvious issues are Lazy SQL, Event Driven Services, Sort Binary Object > Fields. > > Regards, > -- > Ilya Kasnacheev > > > ср, 19

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Ilya Kasnacheev
Hello! Obvious issues are Lazy SQL, Event Driven Services, Sort Binary Object Fields. Regards, -- Ilya Kasnacheev ср, 19 мая 2021 г. в 12:56, Nikolay Izhikov : > Hello, > > > However, for internal platform and services implementations we should > fix the root cause: > > avoid extra

Re: [VOTE][EXTENSION] Release Apache Ignite spring-data-all-ext extensions 1.0.0 RC3

2021-05-19 Thread Ilya Kasnacheev
Hello! Do I understand correctly that voting did not succeed due to insufficient participation? Can you post the vote results? I have checked examples and it indeed works. I have a list of things to do before the RC4: Please copy over examples directory and pom.xml to spring module 2.2. There's

Re: [DISCUSSION] Array to BinaryObject serialization

2021-05-19 Thread Nikolay Izhikov
Hello, > However, for internal platform and services implementations we should fix the > root cause: > avoid extra deserialization->serialization pass completely. > This will also improve performance. Pavel, thanks for the feedback. If I understand correctly, your suggestion is to know data

Re: Obsolete classnames.properties

2021-05-19 Thread Ilya Kasnacheev
Hello! Makes sense calling it during every build, if it can be made reliably. Regards, -- Ilya Kasnacheev вт, 18 мая 2021 г. в 01:51, Данилов Семён : > Hello, Igniters! > > I've recently stumbled across an issue where some tests can't be run > locally due to the absence of some entries in