[MTCGA]: new failures in builds [6093884] needs to be handled

2021-07-20 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. *New test failure in master GridCommandHandlerTest.testSuccessStopWarmUp https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=4363338353725121117&branch=%3

Re: [Discussion] Race on heartbeat update in checkpoint thread

2021-07-20 Thread Ilya Kazakov
1. I mean calling listeners in CheckpointWorkflow.markCheckpointBegin(): This -- for (CheckpointListener lsnr : dbLsnrs) lsnr.beforeCheckpointBegin(ctx0); ctx0.awaitPendingTasksFinished(); -- And this: -

[MTCGA]: new failures in builds [6095041] needs to be handled

2021-07-20 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. *New Critical Failure in master Thin client: Node.js https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ThinClientNodeJs?branch=%3Cdefault%3E No changes in the build

[MTCGA]: new failures in builds [6094100] needs to be handled

2021-07-20 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. *New Critical Failure in master Control Utility (Zookeeper) https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ControlUtilityZookeeper?branch=%3Cdefault%3E No changes

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Юрий
I totally agree. Let's get rid of them. вт, 20 июл. 2021 г. в 18:11, Konstantin Orlov : > + for both > > -- > Regards, > Konstantin Orlov > > > > On 20 Jul 2021, at 16:32, Pavel Tupitsyn wrote: > > > > Agree with for both points > > > > On Tue, Jul 20, 2021 at 3:14 PM Alexander Polovtcev < > ale

Re: [MEETUP] Join Apache Ignite 3.0 Alpha 2 Build Demo on July 20

2021-07-20 Thread Kseniya Romanova
Many thanks to all who attended the gathering and shared the feedback! Some of the questions I hope to see on the dev list soon. Here's the video: https://youtu.be/C3vfFWhKX-M пн, 19 июл. 2021 г. в 13:18, Kseniya Romanova : > Hi Igniters, if you'd like to get an update on Ignite 3.0 progress and

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Konstantin Orlov
+ for both -- Regards, Konstantin Orlov > On 20 Jul 2021, at 16:32, Pavel Tupitsyn wrote: > > Agree with for both points > > On Tue, Jul 20, 2021 at 3:14 PM Alexander Polovtcev > wrote: > >> this is a very welcome change for me >> >> On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin >> wro

Re: [Discussion] Race on heartbeat update in checkpoint thread

2021-07-20 Thread Ivan Daschinsky
+1 For current fix. Code is clean and understandable. I suppose that the current fix is a correct variant to update heartbeatTs. вт, 20 июл. 2021 г. в 16:13, Alex Plehanov : > Hello, Ilya > > > But anyway, I propose to remove the update of the heartbeat from other > threads altogether and wrap th

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Pavel Tupitsyn
Agree with for both points On Tue, Jul 20, 2021 at 3:14 PM Alexander Polovtcev wrote: > this is a very welcome change for me > > On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin > wrote: > > > + for both points. > > > > 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky : > > > Hi! > > > > > > Firstly,

Re: [Discussion] Race on heartbeat update in checkpoint thread

2021-07-20 Thread Alex Plehanov
Hello, Ilya > But anyway, I propose to remove the update of the heartbeat from other threads altogether and wrap the call to listeners in a blockingSection. I don't quite understand your proposal. Which call to listeners do you mean? If we wrap the listener into the blocking section the result wil

[Discussion] Race on heartbeat update in checkpoint thread

2021-07-20 Thread Ilya Kazakov
Hi Igniters, hi Alexey. I want to discuss this issue: https://issues.apache.org/jira/browse/IGNITE-15099. I have caught it too. I was able to determine where there is a race. The update of the heartbeat happens asynchronously into the listener code. But we always wait in the checkpoint thread fo

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Alexander Polovtcev
this is a very welcome change for me On Tue, Jul 20, 2021 at 10:13 AM Ivan Pavlukhin wrote: > + for both points. > > 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky : > > Hi! > > > > Firstly, lets talk about interfaces. > > > > 1. First of all, do we have an automatic inspection for it? AFAIK we > do

Re: [Announcement] Apache Ignite 2.11 Code Freeze started

2021-07-20 Thread Maxim Muzafarov
Folks, Since the release branch was created some time ago, should we bump up the master branch version to the next one? On Thu, 1 Jul 2021 at 17:15, Alexey Gidaspov wrote: > > Hi, Pavel. > > I think, it looks like blocker. Please cherry-pick it to 2.11 release branch > > On 2021/07/01 09:29:57,

Re: Not enough permissions to run RC build

2021-07-20 Thread Alexey Gidaspov
It's OK now. Thank you. On 2021/07/20 07:44:19, Petr Ivanov wrote: > Check you permissions now, please. > > > > > On 20 Jul 2021, at 10:24, Alexey Gidaspov wrote: > > > > Petr, my login is agidaspov > > > > On 2021/07/20 07:22:26, Petr Ivanov wrote: > >> Aleksey — what is your login / e

Re: Not enough permissions to run RC build

2021-07-20 Thread Petr Ivanov
Check you permissions now, please. > On 20 Jul 2021, at 10:24, Alexey Gidaspov wrote: > > Petr, my login is agidaspov > > On 2021/07/20 07:22:26, Petr Ivanov wrote: >> Aleksey — what is your login / email in TC? >> >> >>> On 19 Jul 2021, at 16:10, Alexey Gidaspov wrote: >>> >>> No, but

Re: Not enough permissions to run RC build

2021-07-20 Thread Alexey Gidaspov
Petr, my login is agidaspov On 2021/07/20 07:22:26, Petr Ivanov wrote: > Aleksey — what is your login / email in TC? > > > > On 19 Jul 2021, at 16:10, Alexey Gidaspov wrote: > > > > No, but I'm release manager for 2.11 release and I think I should be able > > to run RC build. > > > > On 2

Re: Not enough permissions to run RC build

2021-07-20 Thread Petr Ivanov
Aleksey — what is your login / email in TC? > On 19 Jul 2021, at 16:10, Alexey Gidaspov wrote: > > No, but I'm release manager for 2.11 release and I think I should be able to > run RC build. > > On 2021/07/19 12:47:46, Petr Ivanov wrote: >> Hi! >> >> >> Are you committer or PMC on Apach

Re: [DISCUSS] Confuse default inspections.

2021-07-20 Thread Ivan Pavlukhin
+ for both points. 2021-07-20 9:56 GMT+03:00, Ivan Daschinsky : > Hi! > > Firstly, lets talk about interfaces. > > 1. First of all, do we have an automatic inspection for it? AFAIK we don't > 2. I am for consistency. At least for production code. Nothing worse is > when someone mixes both approach