Re: Ignite-spring dependency on ignite-indexing

2022-12-23 Thread Alex Plehanov
Hello, Looks reasonable. Also, it looks like the 'ignite-direct-io' module has redundant 'ignite-indexing' dependency too (perhaps it's required for tests, but dependency scope should be 'test' in this case). I will remove redundant 'ignite-indexing' dependencies from 'ignite-spring' and

Re: Naming style for configuration properties defining durations in Ignite 3

2022-12-23 Thread Pavel Tupitsyn
Agree with the proposal. Those properties go into config files (json/hocon), and it is difficult to navigate to relevant docs from there. I would go with point 3 - longer suffixes like Millis - to make it unambiguous. On Fri, Dec 23, 2022 at 10:06 AM Roman Puchkovskiy <

Naming style for configuration properties defining durations in Ignite 3

2022-12-23 Thread Roman Puchkovskiy
Hi Igniters! In Ignite 3, in configuration schemas, we have some properties that define durations/intervals (usually, these are timeout durations). Almost always they are defined without mentioning the duration unit, like this: /** Node join timeout. */ @Value(hasDefault = true) public int