Re: Code duplicates in ssh tests

2018-07-20 Thread Иван Федотов
t; > пт, 20 июл. 2018 г. в 15:01, Иван Федотов : > > > Hi, Igniters! > > > > I’m working on ssh module and found some code duplicates in > > IgniteProjectionStartStopRestartSelfTest. > > > > 1. Tests testRestartNodesByIds and testRestartNodesByIdsC are fully

Code duplicates in ssh tests

2018-07-20 Thread Иван Федотов
Hi, Igniters! I’m working on ssh module and found some code duplicates in IgniteProjectionStartStopRestartSelfTest. 1. Tests testRestartNodesByIds and testRestartNodesByIdsC are fully duplicate themself [1]. I tried to found what differences should they have and looked at similar tests: testStopN

IGNITE-1025 is ready for review (Need to print out warning if IP finder has a lot of addresses on Windows)

2017-12-13 Thread Иван Федотов
Hi, Igniters! I've prepared PR [1] for the issue IGNITE-1025 "Need to print out warning if IP finder has a lot of addresses on Windows" [2] . TeamCity tests look good [3]. Could someone review it? Thanks in advance! [1]https://github.com/apache/ignite/pull/2966 [2]https://issues.apache.org/jira/br

IGNITE-6612 is ready for review (Wrap ack methods in their own class)

2017-11-30 Thread Иван Федотов
Hi, Igniters! I've prepared PR [1] for the issue IGNITE-6612 "Wrap ack methods in their own class" [2] . TeamCity tests look good [3]. Could someone review it? Thanks in advance! [1]https://github.com/apache/ignite/pull/3046 [2]https://issues.apache.org/jira/browse/IGNITE-6612 [3] https://ci.ignite

IGNITE-1025 is ready for review (Need to print out warning if IP finder has a lot of addresses on Windows)

2017-11-10 Thread Иван Федотов
Hi, Igniters! I've prepared PR [1] for the issue IGNITE-1025 "Need to print out warning if IP finder has a lot of addresses on Windows" [2] . TeamCity tests look good [3]. Could someone review it? Thanks in advance! [1]https://github.com/apache/ignite/pull/2966 [2]https://issues.apache.org/jira/b

IGNITE-5798 is ready for review

2017-11-01 Thread Иван Федотов
Hi, PR for ticket IGNITE-5798 <*https://issues.apache.org/jira/browse/IGNITE-5798 *> "Logging Ignite configuration at startup" is ready for review. Please find all information about this ticket in Jira. -- Ivan Fedotov. ivanan...@gmail.com

Wrong SQL statement

2017-10-17 Thread Иван Федотов
Hello, Igniters! Currently, if one try to execute `INSERT INTO t1 VALUES(...);` it will be “IgniteSQLException: Failed to parse query: INSERT INTO Person VALUES(?,?) … Caused by: class org.apache.ignite.internal.processors.query.IgniteSQLException: Failed to parse query: INSERT INTO Person VALU

Refactoring of IgniteKernal ack methods

2017-10-11 Thread Иван Федотов
Hello, Igniters! I found, that in several places of IgniteKernal class code blocks are huge and hard to understand and in other places methods have the same context and could be placed in their own class. For example methods: “ackAsciiLogo”, “ackConfigUrl”, “ackDaemon”, “ackOsInfo”, “ackLanguageRu

Re: IGNITE-5798 - Logging Ignite configuration at startup

2017-09-22 Thread Иван Федотов
IgniteConfiguration is not logged even when -DIGNITE_QUIET=false”. Does it mean that I should log IgniteConfiguration when log.isQuiet = false to the file and terminal? [1] https://issues.apache.org/jira/browse/IGNITE-5798 2017-09-22 17:23 GMT+03:00 Иван Федотов : > > > > > > *Hello, Ignite

IGNITE-5798 - Logging Ignite configuration at startup

2017-09-22 Thread Иван Федотов
*Hello, Igniters!Now I’m working at ticket #5798[1] “Logging Ignite configuration at startup” and have the following questions: 1. Should I get fields and their values only from IgniteConfiguration or I should also get them from inherited classes? If second variant is correct , what level of inheri

Re: IGNITE-1025

2017-09-19 Thread Иван Федотов
Anton, Thanks, I'll start it. 2017-09-19 14:54 GMT+03:00 Anton Vinogradov : > Ivan, > > Issue is still actual. > > On Tue, Sep 19, 2017 at 2:10 PM, Иван Федотов wrote: > > > Hi, Igniters! > > I've picked up task https://issues.apache.org/jira/brows

IGNITE-1025

2017-09-19 Thread Иван Федотов
Hi, Igniters! I've picked up task https://issues.apache.org/jira/browse/IGNITE-1025 "Need to print out warning if IP finder has a lot of addresses on Windows", but this task was created in June 2015. Is this task still relevant? Thanks in advance. -- Ivan Fedotov. ivanan...@gmail.com

Hello

2017-09-04 Thread Иван Федотов
Hello everyone! My name is Ivan Fedotov, I'm new in Apache Ignite project and i want to contribute to Apache Ignite. So, please give me the rights to do this. This is my username in Jira: "ivanan".