Folks,
Thank you for not being indifferent to the topic of coding style.
I've temporary excluded `scala` related modules from the [Check Code
Style] suite configuration (checkstyle is not working for the `scala`
source code) until we come to an agreement to a way to solve the
problem mentioned ab
Petr, Nikolay,
Running some kind of smoke test might be a good idea. But I think it
should be discussed separately in another thread.
чт, 13 июн. 2019 г. в 11:43, Petr Ivanov :
>
> I do not know, some basic tests (running single instance of Ignite,
> activation, simple cluster topology, etc.)
>
I do not know, some basic tests (running single instance of Ignite, activation,
simple cluster topology, etc.)
It seems that it is more critical than stylecheck, that can be fixed in several
lines of code, but will steal a day (night) of tests.
> On 13 Jun 2019, at 11:42, Nikolay Izhikov wrote
Hello, Petr.
I think we should be specific here.
For me: "code style" fail should be equal to "compilation fail".
Can you clarify, what fundamental tests you are written about?
В Чт, 13/06/2019 в 11:26 +0300, Petr Ivanov пишет:
> How about including basic set of tests (sanity checks) into ~Build
How about including basic set of tests (sanity checks) into ~Build Apache
Ignite~?
Or may be we can go even further and use cascade system of tests — run them
group by group, stopping the whole run if more fundamental tests are failing?
> On 12 Jun 2019, at 21:54, Nikolay Izhikov wrote:
>
> +
+1 for including checkstyl to "Build Apache Ignite".
В Ср, 12/06/2019 в 21:29 +0300, Павлухин Иван пишет:
> Maxim,
>
> Options 1 and 3 sounds fine to me. And taking into account current
> state I tend to think that option 1 is even better.
>
> вт, 11 июн. 2019 г. в 14:19, Maxim Muzafarov :
> >
Maxim,
Options 1 and 3 sounds fine to me. And taking into account current
state I tend to think that option 1 is even better.
вт, 11 июн. 2019 г. в 14:19, Maxim Muzafarov :
>
> Dmitry,
>
> Thank you.
> Sure, I'll not change anything on TC without discussion with all the
> community.
>
> On Tue,
Dmitry,
Thank you.
Sure, I'll not change anything on TC without discussion with all the community.
On Tue, 11 Jun 2019 at 13:30, Dmitriy Pavlov wrote:
>
> Hi Maxim,
>
> I've granted role Ignite Tests Admins to your account. Please check.
>
> Please notify community on any significant changes you
Hi Maxim,
I've granted role Ignite Tests Admins to your account. Please check.
Please notify community on any significant changes you do. Unfortunately,
TC parameters audit is not so convenient as VCS-based configuration/code.
Sincerely
Dmitriy Pavlov
пн, 10 июн. 2019 г. в 17:03, Maxim Muzafaro
Igniters,
It seems to me that building [ignite-scalar] module under JDK9+ have
been successfully solved for the ~Build Apache Ignite~ suite [1] [2]
[3], but it was not configured for the [Check Code Style] suite. We
should configure it the same way (but it sounds to me very odd). I
see, that we ha
Hello, Petr.
> at least Scala does not compile
How cat I reproduce it?
Do we have ticket?
В Пт, 07/06/2019 в 15:28 +0300, Petr Ivanov пишет:
> Suite fails because Apache Ignite compilation is not supported under JDK 9+
> (at least Scala does not compile).
> Your build from [3] was triggered wit
Petr,
Yes, I see thanks. How can we force the suite to use the only JDK8?
I see the configuration parameter: JDK home path: %env.JDK_ORA_18%,
but probably it works not well enough.
On Fri, 7 Jun 2019 at 15:28, Petr Ivanov wrote:
>
> Suite fails because Apache Ignite compilation is not supported
Suite fails because Apache Ignite compilation is not supported under JDK 9+ (at
least Scala does not compile).
Your build from [3] was triggered with JDK 11.
> On 7 Jun 2019, at 14:57, Maxim Muzafarov wrote:
>
> Igniters,
>
> I've noticed a few problems with Code Style Check Suite on TC in the
Igniters,
I've noticed a few problems with Code Style Check Suite on TC in the
master branch.
1. Some of the rules have been violated by previous commits to the
master branch. I've created ticket [1] and have prepared PR [2] which
is fixing it.
Dmitry, or maybe someone else, can you take a look,
14 matches
Mail list logo
