Re: [IEP-35] GridJobProcessorMetrics migration

2019-06-25 Thread Alex Plehanov
Hi, Nickolay Yes, sure. I've left some comments on GitHub. пн, 24 июн. 2019 г. в 19:15, Nikolay Izhikov : > Hello, Alex. > > Based on our private discussion I've additionally migrated > `totalExecutionTime` and `totalWaitingTime` counters. > Can you review the PR [1]? > > [1] https://github.com/

Re: [IEP-35] GridJobProcessorMetrics migration

2019-06-24 Thread Nikolay Izhikov
Hello, Alex. Based on our private discussion I've additionally migrated `totalExecutionTime` and `totalWaitingTime` counters. Can you review the PR [1]? [1] https://github.com/apache/ignite/pull/6622 В Пн, 24/06/2019 в 15:14 +0300, Nikolay Izhikov пишет: > Hello, Alex. > > Thanks for the answe

Re: [IEP-35] GridJobProcessorMetrics migration

2019-06-24 Thread Nikolay Izhikov
Hello, Ivan. > Ignite is a cluster which almost every > time assumes an external monitoring for a production use. +1. > 1. Are we going to preserve a compatibility with metrics present > before? Or are we going to keep only those making sense today? 1. Backward compatibility preserved. 2. Depr

Re: [IEP-35] GridJobProcessorMetrics migration

2019-06-24 Thread Nikolay Izhikov
Hello, Alex. Thanks for the answer. 1. I, actually, don't understand your proposal :) Can you write it down? What numbers should be additionally migrated in this PR? Or it's OK for now? > I think "idle time" is a useful metric I think "usefulness" or "uselessness" of specific metrics depends

Re: [IEP-35] GridJobProcessorMetrics migration

2019-06-24 Thread Павлухин Иван
Hi Nikolay, Alex, A couple of my humble comments > Aggregation should be done with the metric collect system(Prometheus, > Graphite, etc.). I like that statement very much! > But, what if a user doesn't use any external monitoring system and wants to > know the health of Ignite instance? I thin

Re: [IEP-35] GridJobProcessorMetrics migration

2019-06-24 Thread Alex Plehanov
Hi Nikolay, I think "idle time" is a useful metric, but it can be calculated outside of Ignite using external monitoring system. About execution and waiting time, it's not the right way to calculate it using a jobs list. Will jobs list contain only active jobs? In this case, you can't calculate t

[IEP-35] GridJobProcessorMetrics migration

2019-06-20 Thread Nikolay Izhikov
Hello, Igniters. Especially, Ignite veterans. I've prepared PR [1] for the ticket IGNITE-11926 [2]. I found that we don't have any tests for the current GridJobMetrics implementation. So I added basic tests for the current implementation in the PR. Guys, do we have real-world usages of numbers