Ok, thank you, I've missed the start of the discussion
пн, 14 окт. 2019 г. в 11:13, Ivan Pavlukhin :
> Alexey, Petr,
>
> Please read first message in this thread. Now checkstyle is a part of
> [Build
> Apache Ignite].
>
> If you still have any questions after that please write back.
> Sincerely,
Alexey, Petr,
Please read first message in this thread. Now checkstyle is a part of [Build
Apache Ignite].
If you still have any questions after that please write back.
Sincerely, I do not want us to repeat the discussion as it was
detailed enough and in my opinion Maxim did the change gracefully
Maksim, why have you removed Checkstyle from Run All?
> On 13 Oct 2019, at 18:52, Maxim Muzafarov wrote:
>
> Igniters,
>
> The `checkstyle` profile has been enabled for the Apache Ignite build
> procedure.
> Unused imports in the spark module have been fixed [1].
> The `[Check Code Style]` su
Please, return checkstyle to run Ml, I use this feature
вс, 13 окт. 2019 г., 18:52 Maxim Muzafarov :
> Igniters,
>
> The `checkstyle` profile has been enabled for the Apache Ignite build
> procedure.
> Unused imports in the spark module have been fixed [1].
> The `[Check Code Style]` suite has be
Igniters,
The `checkstyle` profile has been enabled for the Apache Ignite build procedure.
Unused imports in the spark module have been fixed [1].
The `[Check Code Style]` suite has been excluded from `Run :: All`,
`Run :: ML`.
[1] https://issues.apache.org/jira/browse/IGNITE-12287
On Tue, 8 Oct
Let's give it a try.
пн, 7 окт. 2019 г. в 13:21, Nikolay Izhikov :
>
> +1
>
> В Пн, 07/10/2019 в 13:18 +0300, Maxim Muzafarov пишет:
> > Igniters,
> >
> >
> > I'm planning October 11 (Friday) 22-00 MSK enable `checkstyle` profile
> > on the [Build
> > Apache Ignite] suite by the end of the next we
+1
В Пн, 07/10/2019 в 13:18 +0300, Maxim Muzafarov пишет:
> Igniters,
>
>
> I'm planning October 11 (Friday) 22-00 MSK enable `checkstyle` profile
> on the [Build
> Apache Ignite] suite by the end of the next weekend (one week test
> period). Such an option discussed many times before (e.g. [1])
Igniters,
I'm planning October 11 (Friday) 22-00 MSK enable `checkstyle` profile
on the [Build
Apache Ignite] suite by the end of the next weekend (one week test
period). Such an option discussed many times before (e.g. [1]).
Here are the reasons:
- any code style violations in a PR lead to sou
