Re: Let's remove ignite-schedule module and IgniteScheduler interface

> > My Vote was for 3.0 > > > > > >> > > > > > > > > >> > > > On Thu, Dec 19, 2019 at 10:44 AM Valentin Kulichenko < > > > > > >> > > > valentin.kuliche...@gmail.com> wrote: > > > > > >> > > > > > >

Re: Let's remove ignite-schedule module and IgniteScheduler interface

ibility should be > > > > preserved > > > > >> > > > within > > > > >> > > > > a major version. I would oppose doing such a change in > 2.x. > > > > >> > > > > > > > > >> > > > > If

Re: Let's remove ignite-schedule module and IgniteScheduler interface

Alexey Kuznetsov < > > >> > akuznet...@apache.org > > >> > > > > > > >> > > > > wrote: > > >> > > > > > > >> > > > > > Hi! > > >> > > > > &

Re: Let's remove ignite-schedule module and IgniteScheduler interface

gt; > > > > Hi! > >> > > > > > > >> > > > > > What if some users already using this module? > >> > > > > > What they should do? Rewrite code? > >> > > > > > I do not think it is a good idea. > >> > &g

Re: Let's remove ignite-schedule module and IgniteScheduler interface

>> > > > > > What they should do? Rewrite code? >> > > > > > I do not think it is a good idea. >> > > > > > >> > > > > > My "-1" here. >> > > > > > >> > > > > >

Re: Let's remove ignite-schedule module and IgniteScheduler interface

gt; > > > > > > > > > > On Thu, Dec 19, 2019 at 8:53 AM Anton Vinogradov > > > > wrote: > > > > > > > > > > > > > ignite-schedule does not look to be properly located or useful. > > > > > > > My +1 here. > > > > > > > >

Re: Let's remove ignite-schedule module and IgniteScheduler interface

; > > > > > > > ignite-schedule does not look to be properly located or useful. > > > > > > My +1 here. > > > > > > > > > > > > On Thu, Dec 19, 2019 at 8:35 AM Ivan Pavlukhin < > vololo...@gmail.com> > > > > > &g

Re: Let's remove ignite-schedule module and IgniteScheduler interface

e. > > > > > > > > > > > > On Thu, Dec 19, 2019 at 8:35 AM Ivan Pavlukhin < > vololo...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > Ilya, > > > > > > > > > >

Re: Let's remove ignite-schedule module and IgniteScheduler interface

gt; > > > wrote: > > > > > > > > > > > Ilya, > > > > > > > > > > > > I think it is a good initiative! Do we really need to keep > > > > > > run/callLocall methods at all? > > > > > > > > > > > &g

Re: Let's remove ignite-schedule module and IgniteScheduler interface

19, 2019 at 8:35 AM Ivan Pavlukhin > > > > wrote: > > > > > > > > > Ilya, > > > > > > > > > > I think it is a good initiative! Do we really need to keep > > > > > run/callLocall methods at all? > > > > > &

Re: Let's remove ignite-schedule module and IgniteScheduler interface

t; > > On Thu, Dec 19, 2019 at 8:35 AM Ivan Pavlukhin > > > wrote: > > > > > > > Ilya, > > > > > > > > I think it is a good initiative! Do we really need to keep > > > > run/callLocall methods at all? > > &g

Re: Let's remove ignite-schedule module and IgniteScheduler interface

all? > > > > > > ср, 18 дек. 2019 г. в 17:59, Ilya Kasnacheev : > > > > > > > > Hello! > > > > > > > > Since 2.8 is branched, I want to initiate the discussion about > removal > > of > > > > ignite-schedule modu

Re: Let's remove ignite-schedule module and IgniteScheduler interface

Hello! > > > > > > Since 2.8 is branched, I want to initiate the discussion about removal > of > > > ignite-schedule module. > > > > > > My plan as follows: > > > > > > Remove ignite-schedule module entirely. > > > Move ru

Re: Let's remove ignite-schedule module and IgniteScheduler interface

9, Ilya Kasnacheev : > > > > Hello! > > > > Since 2.8 is branched, I want to initiate the discussion about removal of > > ignite-schedule module. > > > > My plan as follows: > > > > Remove ignite-schedule module entirely. > > Move runLocal and callLoc

Re: Let's remove ignite-schedule module and IgniteScheduler interface

Ilya, I think it is a good initiative! Do we really need to keep run/callLocall methods at all? ср, 18 дек. 2019 г. в 17:59, Ilya Kasnacheev : > > Hello! > > Since 2.8 is branched, I want to initiate the discussion about removal of > ignite-schedule module. > > My plan a

Let's remove ignite-schedule module and IgniteScheduler interface

Hello! Since 2.8 is branched, I want to initiate the discussion about removal of ignite-schedule module. My plan as follows: Remove ignite-schedule module entirely. Move runLocal and callLocal methods from IgniteScheduler to IgniteCompute. Delete IgniteScheduler interface with its remaining

Re: Replace Cron4J with Quartz for ignite-schedule module.

Hello! In any case I don't see why we would keep ignite-schedule module. We could merge this change if you moved this functionality into ignite-spring (while also fixing single thread problem). The sole reason of existence of ignite-schedule module was the extra dependency, if we don't have

Re: Replace Cron4J with Quartz for ignite-schedule module.

llo! > > I've spent considerable amount of time working on your patch yesterday, but > eventually I have come to conclusion that we should Deprecate > IgniteScheduler and ignite-schedule module, and Remove it in 3.0. > > The reason for this: IgnoteScheduler interface has 5 methods,

Re: Replace Cron4J with Quartz for ignite-schedule module.

Hi, Ilya! It looks like Spring *ThreadPoolTaskScheduler* is bounded to JDK's *ScheduledThreadPoolExecutor*, so to launch scheduled tasks on public pool we need provide *ScheduledThreadPoolExecutor* for Public pool. Currently I see we create Public pool executor as *IgniteThreadPoolExecutor* and it

Re: Replace Cron4J with Quartz for ignite-schedule module.

Hello! I have started reviewing your pull request. I will expect that scheduled tasks are executed on Public pool. Is it possible that tasks are launched on Public pool? If Spring Scheduler insists on its own thread pool, we can have single-thread pool which will execute put of tasks to public

Re: Replace Cron4J with Quartz for ignite-schedule module.

Hi, Sergey! I think we should keep compatibility as much as possible for Ignite 2.x. And we can do breaking changes in Ignite 3.x What do you think? On Mon, Dec 24, 2018 at 11:58 PM Sergey wrote: > HI, Igniters! > > I've updated and rebased implementation to master branch and made some >

Re: Replace Cron4J with Quartz for ignite-schedule module.

HI, Igniters! I've updated and rebased implementation to master branch and made some fixes. Also I have a question regarding current implementation. As I found Cron4J source code this implementation checks schedule every minute (seconds not supported) but spawns a thread for every task which

Re: Ignite schedule module

Regards, > > > > > > -- > > > Ilya Kasnacheev > > > > > > 2018-06-06 19:05 GMT+03:00 Dmitry Pavlov : > > > > > > > Hi Igniters, > > > > > > > > I've tried to use > > > > > > > > ignite.scheduler()

Re: Ignite schedule module

; > > > I've tried to use > > > > > > ignite.scheduler().scheduleLocal(this::checkFailures, "? * * * * *"); > > > > > > Result is > > > class org.apache.ignite.IgniteException: Current Ignite configuration > > does > >

Re: Ignite schedule module

v : > > > Hi Igniters, > > > > I've tried to use > > > > ignite.scheduler().scheduleLocal(this::checkFailures, "? * * * * *"); > > > > Result is > > class org.apache.ignite.IgniteException: Current Ignite configura

Ignite schedule module

Hi Igniters, I've tried to use ignite.scheduler().scheduleLocal(this::checkFailures, "? * * * * *"); Result is class org.apache.ignite.IgniteException: Current Ignite configuration does not support schedule functionality (consider adding ignite-schedule module to

Re: Replace Cron4J with Quartz for ignite-schedule module.

Hi Anton, Thank you for joining and review. I hope all proposals will be applied. Sincerely, Dmitriy Pavlov пт, 4 мая 2018 г. в 16:04, Anton Vinogradov : > Folks, > > How can it be at PATCH AVAILABLE since *none* of my latest comments (made > Feb 8) are resolved at Upsource? >

Re: Replace Cron4J with Quartz for ignite-schedule module.

Folks, How can it be at PATCH AVAILABLE since *none* of my latest comments (made Feb 8) are resolved at Upsource? Changed state to IP. пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov : > Hi Andrey, > > Could you please pick up review? > > Sincerely, > Dmitriy Pavlov > > пн, 23

Re: Replace Cron4J with Quartz for ignite-schedule module.

Hi Andrey, Could you please pick up review? Sincerely, Dmitriy Pavlov пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan : > Dmitriy, who is a good candidate within the community to review this > ticket? > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov

Re: Replace Cron4J with Quartz for ignite-schedule module.

Dmitriy, who is a good candidate within the community to review this ticket? On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov wrote: > Hi Igniters, > > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is still > in PA state. What are our next steps? > > Who

Re: Replace Cron4J with Quartz for ignite-schedule module.

Hi Igniters, it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is still in PA state. What are our next steps? Who did review of this patch? Sincerely, Dmitriy Pavlov ср, 28 июн. 2017 г. в 1:40, Denis Magda : > Yakov, > > No, the mentioned discussion didn’t

Re: Replace Cron4J with Quartz for ignite-schedule module.

Yakov, No, the mentioned discussion didn’t turn into a JIRA ticket. Alex K., please follow to some thoughts from there and wrap them up in a form of the ticket. — Denis > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov wrote: > > Guys, I remember we discussed this some time

Re: Replace Cron4J with Quartz for ignite-schedule module.

Guys, I remember we discussed this some time ago. http://apache-ignite-developers.2346864.n4.nabble.com/Tasks-Scheduling-and-Chaining-td14293.html Denis, do you have any ticket or SoW? --Yakov

Re: Replace Cron4J with Quartz for ignite-schedule module.

gt; > >> standard CRON; > > >> 5.spring's code quality is very good, maintainability is good, and the > > >> quality of quartz code is not very good. > > >> On 06/21/2017 13:26，Alexey Kuznetsov<akuznet...@apache.org> wrote： > > >> Hi! &

Re: Replace Cron4J with Quartz for ignite-schedule module.

ality of quartz code is not very good. > >> On 06/21/2017 13:26，Alexey Kuznetsov<akuznet...@apache.org> wrote： > >> Hi! > >> > >> 1) Cron4J is very old: > >> Latest Cron4j 2.2.5 released: *28-Dec-2011 * > >> Latest Quarz 2.3.0 released: *

Re: Replace Cron4J with Quartz for ignite-schedule module.

6，Alexey Kuznetsov<akuznet...@apache.org> wrote： >> Hi! >> >> 1) Cron4J is very old: >> Latest Cron4j 2.2.5 released: *28-Dec-2011 * >> Latest Quarz 2.3.0 released: *20-Apr-2017* >> >> 2) Not very friendly license: >> CronJ4 licensed under GNU LES

Re: Replace Cron4J with Quartz for ignite-schedule module.

: *28-Dec-2011 * > Latest Quarz 2.3.0 released: *20-Apr-2017* > > 2) Not very friendly license: > CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE > Quartz is freely usable, licensed under the *Apache 2.0* license. > > So, if we replace Cron4J with Quartz we can m

Re: Replace Cron4J with Quartz for ignite-schedule module.

he 2.0* license. So, if we replace Cron4J with Quartz we can move *ignite-schedule* module from lgpl profile to main distribution. Any objections? If no, I will create JIRA issue and implement this change. -- Alexey Kuznetsov

Re: Replace Cron4J with Quartz for ignite-schedule module.

emind what we use the schedule module in Ignite for? >> > > >> > > D. >> > > >> > > On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov < >> akuznet...@apache.org >> > > >> > > wrote: >> > > >> > >

Re: Replace Cron4J with Quartz for ignite-schedule module.

; > > D. > > > > > > On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov < > akuznet...@apache.org > > > > > > wrote: > > > > > > > Hi! > > > > > > > > 1) Cron4J is very old: > > > > Latest Cron4j

Re: Replace Cron4J with Quartz for ignite-schedule module.

: *20-Apr-2017* > > 2) Not very friendly license: > CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE > Quartz is freely usable, licensed under the *Apache 2.0* license. > > So, if we replace Cron4J with Quartz we can move *ignite-schedule* module > from lgpl profil

Replace Cron4J with Quartz for ignite-schedule module.

Cron4J with Quartz we can move *ignite-schedule* module from lgpl profile to main distribution. Any objections? If no, I will create JIRA issue and implement this change. -- Alexey Kuznetsov