Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-09-24 Thread Dmitrii Ryabov
Юрий, can you take a look? JIRA - https://issues.apache.org/jira/browse/IGNITE-13450 PR - https://github.com/apache/ignite/pull/8252 вт, 15 сент. 2020 г. в 08:59, Dmitrii Ryabov : > > Ok, I created a ticket [1]. > > [1] https://issues.apache.org/jira/browse/IGNITE-13450 > > пн, 14 сент. 2020 г. в

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-09-15 Thread Dmitrii Ryabov
Ok, I created a ticket [1]. [1] https://issues.apache.org/jira/browse/IGNITE-13450 пн, 14 сент. 2020 г. в 14:59, Юрий : > > Dmitrii, seems you are right and we can go with new separate event > > пн, 7 сент. 2020 г. в 23:53, Dmitrii Ryabov : > > > Any objections to create a separate event, which

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-09-14 Thread Юрий
Dmitrii, seems you are right and we can go with new separate event пн, 7 сент. 2020 г. в 23:53, Dmitrii Ryabov : > Any objections to create a separate event, which will be fired before > executing a query? > > ср, 2 сент. 2020 г. в 22:33, Dmitrii Ryabov : > > > > I agree with Max, we need to add

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-09-09 Thread Denis Magda
Ignite SQL experts, could you please step in? - Denis On Mon, Sep 7, 2020 at 1:53 PM Dmitrii Ryabov wrote: > Any objections to create a separate event, which will be fired before > executing a query? > > ср, 2 сент. 2020 г. в 22:33, Dmitrii Ryabov : > > > > I agree with Max, we need to add a

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-09-07 Thread Dmitrii Ryabov
Any objections to create a separate event, which will be fired before executing a query? ср, 2 сент. 2020 г. в 22:33, Dmitrii Ryabov : > > I agree with Max, we need to add a separate event for starting query > execution, and EVT_CACHE_QUERY_EXECUTED shouldn't be deprecated, > because it is

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-09-02 Thread Dmitrii Ryabov
I agree with Max, we need to add a separate event for starting query execution, and EVT_CACHE_QUERY_EXECUTED shouldn't be deprecated, because it is another case - it is fired when cache query was successfully finished. > Would the event notification be synchronous? In which thread? As Max said,

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-20 Thread Max Timonin
Looks like EVT_CACHE_QUERY_EXECUTED just works for different use cases: 1. it relates to a specific cache (Event for SQL queries looks different as it could contain multiple caches or none of them); 2. Also the EVT_CACHE_QUERY_EXECUTED event fires multiple times for distributed queries, see

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-20 Thread Юрий
In my opinion existing events EVT_CACHE_QUERY_EXECUTION_STARTED should be deprecated and added two new for start and for end of queries which should cover all SQL query types. I have some doubts about provide text of a query even with hidden arguments, probably it should be configured due to it

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-20 Thread Stanislav Lukyanov
Maksim, Can we change the EVT_CACHE_QUERY_EXECUTED to fire earlier? Or should there be an EVT_CACHE_QUERY_EXECUTION_STARTED for the query start, while the old event would continue to work for query finish? I think the new event needs to either reuse the old one, or be its mirror for the query

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-16 Thread Denis Magda
Taras, Yury, Ivan, Could you please join this thread and share your thoughts? Do we already have any plans on tracking of the DDL and DML queries? - Denis On Wed, Jul 15, 2020 at 12:09 AM Max Timonin wrote: > Hi Denis, thanks for the answer! > > We already checked EVT_CACHE_QUERY_EXECUTED

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-15 Thread Max Timonin
Hi Denis, thanks for the answer! We already checked EVT_CACHE_QUERY_EXECUTED and found that it works only in cases: 1. Scan queries and Select queries (common pattern is access to cache data); 2. This event triggers only if query execution succeeds, in case of failure while execution this event

Re: Proposal of new event QUERY_EXECUTION_EVENT

2020-07-14 Thread Denis Magda
Hi Max, Could you check if the EVT_CACHE_QUERY_EXECUTED event is what you're looking for? https://www.gridgain.com/docs/latest/developers-guide/events/events#cache-query-events - Denis On Fri, Jul 10, 2020 at 3:54 AM Max Timonin wrote: > Hi Igniters! > > We're going to protocol all input SQL

Proposal of new event QUERY_EXECUTION_EVENT

2020-07-10 Thread Max Timonin
Hi Igniters! We're going to protocol all input SQL queries from our users. Currently there is no such mechanism in Ignite to use for it. So we're proposing to add a new event: QUERY_EXECUITION_EVENT. Requirements for the event: 1. If this event fires it means that a query is correct and will be