Hi, Igniters.
Could someone review my changes, please? [1] [2]
I have removed the method from the internal interface
(DiscoveryCustomMessage) and marked deprecated in the public interface
(DiscoverySpiCustomMessage).
[1] https://issues.apache.org/jira/browse/IGNITE-12400
[2]
Hi, Igniters.
I have created the issue [1] and prepared PR [2] to remove the
stopProcess method from interfaces.
I have removed the method from the internal interface
(DiscoveryCustomMessage) and marked deprecated in the public interface
(DiscoverySpiCustomMessage).
Could anyone review my
Nikita, please, feel free:
1. To create a ticket to remove `stopProcess` method from the interface.
This improvement looks obvious to me.
Seems we can implement it easily.
2. To make all Discovery messages immutable.
This one more complex.
I think we should discuss every single mutable message
There are at least a couple more mutable messages:
StartRoutineDiscoveryMessage and SchemaProposeDiscoveryMessage.
I agree that here that making all messages immutable are highly
desired (e.g. it will allow implementation of new discovery
protocols). But so far I do not understand why marker
Hi Nikita,
1. As I can understand, this functionality is needed if a custom message is
needed to be processed only on the coordinator node. I'm not following for
what purposes it was implemented and I see the real usage only in tests.
As far as this functionality is not used in production code, I
Hi, Igniters.
The discovery custom message interface has two methods the use of
which is not clear to developers:
1. The stopProcess() method. Currently, it works only if the zookeeper
discovery configured. It doesn't work in TcpDiscoverySpi. I did not
find any usages of this method except
