Re: IGNITE-1217 TC triggering by github pull-requests

On Fri, Aug 14, 2015 at 03:23PM, Valentin Kulichenko wrote: > Artem, > > Why do we need a requirement about one commit per pull request? I > understand that we should should avoid garbage in history and properly deal > with merges from master. But I don't see anything wrong with 2-3 commits in > a

Re: IGNITE-1217 TC triggering by github pull-requests

Guys, I updated the section about pull requests on Wiki. Please take a look and provide your comments if you have any. -Val On Fri, Aug 14, 2015 at 3:46 PM, Raul Kripalani wrote: > On 14 Aug 2015 23:41, "Valentin Kulichenko" > > wrote: > > > > Agree. Actually, it's up to a committer, I think.

Re: IGNITE-1217 TC triggering by github pull-requests

On 14 Aug 2015 23:41, "Valentin Kulichenko" wrote: > > Agree. Actually, it's up to a committer, I think. I just don't see a reason > to have one-commit-per-pull-request requirement. From my understanding, > this is not how pull requests work. Yeah, in reality it depends on the quality of the hist

Re: IGNITE-1217 TC triggering by github pull-requests

Agree. Actually, it's up to a committer, I think. I just don't see a reason to have one-commit-per-pull-request requirement. From my understanding, this is not how pull requests work. BTW, I just tested the process and it works like a charm. I like it! And I'm about to merge your contributions, Ra

Re: IGNITE-1217 TC triggering by github pull-requests

Although you can, I don't recommend merging the pull request directly from the contributor's Github repo into the ASF Git, as you will preserve their commit history. Normally you wouldn't be interested in doing so, as it might have taken them 2, 5 or 10 commits to implement the contribution, and k

Re: IGNITE-1217 TC triggering by github pull-requests

Although you can, I don't recommend merging the pull request directly from the contributor's repo into the ASF Git. Normally you wouldn't be interested in preserving their commit history. It might have taken them 2, 5 or 10 commits to implement the contribution, and keeping that history on our sid

Re: IGNITE-1217 TC triggering by github pull-requests

And a minor question. On TC in branches dropdown I see 'pull/xx/head' and 'pull/xx/merge'. What is the difference? -Val On Fri, Aug 14, 2015 at 3:23 PM, Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Artem, > > Why do we need a requirement about one commit per pull request? I > u

Re: IGNITE-1217 TC triggering by github pull-requests

Artem, Why do we need a requirement about one commit per pull request? I understand that we should should avoid garbage in history and properly deal with merges from master. But I don't see anything wrong with 2-3 commits in a PR if they are meaningful. E.g., "implemented initial version" -> "fixe

Re: IGNITE-1217 TC triggering by github pull-requests

Artem, Seems that TC doesn't write down comments into a corresponding JIRA issue for branches that have 'dev' suffix (like 'ignite-xxx-dev'). I've created a pull-request to merge from 'ignite-1241-dev': https://github.com/apache/incubator-ignite/pull/19 I've received an e-mail saying that the

Re: IGNITE-1217 TC triggering by github pull-requests

Alexey, You are right and big thanks for the diagram on the wiki! In bounds of IGNITE-1217 I've created a script for commiters (see patch). You need to point to the script a contributor_github_user_name and a branch_name_with_contribution. The s

Re: IGNITE-1217 TC triggering by github pull-requests

I forgot that the mailing list takes out all formatting, the diagram meant to be in a monospaced font :) I added it to Ignite wiki: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute 2015-08-13 19:22 GMT-07:00 Alexey Goncharuk : > While the process of a pull-request creation an

Re: IGNITE-1217 TC triggering by github pull-requests

While the process of a pull-request creation and CI run is clear for, the whole cycle from start to end is still fuzzy. Let me summarize my understanding and correct me if I got something wrong. For any committer/contributor John Doe we will have the following structure: ++

Re: IGNITE-1217 TC triggering by github pull-requests

On Thu, Aug 13, 2015 at 05:54PM, Dmitriy Setrakyan wrote: > On Thu, Aug 13, 2015 at 5:51 PM, Konstantin Boudnik wrote: > > > On Thu, Aug 13, 2015 at 05:40PM, Alexey Goncharuk wrote: > > > Maybe I miss a good piece of information about how Git works, but I > > always > > > thought that if a pull r

Re: IGNITE-1217 TC triggering by github pull-requests

On Thu, Aug 13, 2015 at 5:51 PM, Konstantin Boudnik wrote: > On Thu, Aug 13, 2015 at 05:40PM, Alexey Goncharuk wrote: > > Maybe I miss a good piece of information about how Git works, but I > always > > thought that if a pull request is accepted, it will be merged to the > GitHub > > mirror of Ap

Re: IGNITE-1217 TC triggering by github pull-requests

On Thu, Aug 13, 2015 at 05:40PM, Alexey Goncharuk wrote: > Maybe I miss a good piece of information about how Git works, but I always > thought that if a pull request is accepted, it will be merged to the GitHub > mirror of Apache Ignite. How will this change get to the original Apache > git reposi

Re: IGNITE-1217 TC triggering by github pull-requests

Maybe I miss a good piece of information about how Git works, but I always thought that if a pull request is accepted, it will be merged to the GitHub mirror of Apache Ignite. How will this change get to the original Apache git repository? Can somebody explain to me the merge procedure? 2015-08-1

Re: IGNITE-1217 TC triggering by github pull-requests

Inline. On Wed, Aug 12, 2015 at 10:19 AM, Dmitriy Setrakyan wrote: > On Tue, Aug 11, 2015 at 6:28 AM, Artem Shutak > wrote: > > > And one more question. Is it mandatory to have possibility works via > > patches if we will have pull-request way for contributions? > > > > I'd like to have only on

Re: IGNITE-1217 TC triggering by github pull-requests

On Tue, Aug 11, 2015 at 6:28 AM, Artem Shutak wrote: > And one more question. Is it mandatory to have possibility works via > patches if we will have pull-request way for contributions? > > I'd like to have only one approach. > Artem, if possible I would allow 2 approaches and document the 2 app

Re: IGNITE-1217 TC triggering by github pull-requests

And one more question. Is it mandatory to have possibility works via patches if we will have pull-request way for contributions? I'd like to have only one approach. -- Artem -- On Tue, Aug 11, 2015 at 4:15 PM, Artem Shutak wrote: > Igniters, > > I'm working on https://issues.apache.org/jira/br