Re: Add a parameter in Jenkins job cherrypick-2.x-and-test

Thanks, Lars! On Tue, Jun 25, 2019 at 12:08 AM Lars Volker wrote: > Hi Quanlong, > > I added a parameter to the jenkins job. This test run looks like it works > ok: https://jenkins.impala.io/job/cherrypick-2.x-and-test/681/console > > Please have a look and let me know if you require any further

Re: Add a parameter in Jenkins job cherrypick-2.x-and-test

Hi Quanlong, I added a parameter to the jenkins job. This test run looks like it works ok: https://jenkins.impala.io/job/cherrypick-2.x-and-test/681/console Please have a look and let me know if you require any further changes. Cheers, Lars On Sat, Jun 15, 2019 at 11:36 PM Quanlong Huang wrote

Re: Add a parameter in Jenkins job cherrypick-2.x-and-test

It happens again that a clean pick introduces build failure: - Jenkins run: https://jenkins.impala.io/job/cherrypick-2.x-and-test/678/ - Commit required some fix: https://github.com/apache/impala/commit/c333b5526 Now the HEAD of 2.x branch is e6c1eb85eb31264eaf5ed92782bf181225ce9581. The

Re: Add a parameter in Jenkins job cherrypick-2.x-and-test

Sure. I just uploaded and published a batch of patches: remote: New Changes: remote: http://gerrit.cloudera.org:8080/12798 IMPALA-6642 (Part 2): clean up start-impala-cluster.py [DRAFT] remote: http://gerrit.cloudera.org:8080/12799 IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER [DRAFT] r

Re: Add a parameter in Jenkins job cherrypick-2.x-and-test

Yes, you could have a local branch, cherry pick all the changes that you know are working plus the last one that causes issues. Then you can send the whole branch for review, which will open a new review for each of the changes and then submit them manually. Cheers, Lars On Fri, Mar 15, 2019 at 6

Re: Add a parameter in Jenkins job cherrypick-2.x-and-test

I thought all the submits to 2.x and master branch should be done in Gerrit. Do you mean I can create a new branch manually with the next 10 patches, and then merge it *manually* to branch 2.x after parallel-all-tests run successfully on it? -- Quanlong On Sat, Mar 16, 2019 at 12:17 AM Lars Volke

Re: Add a parameter in Jenkins job cherrypick-2.x-and-test

The Jenkins job uses compare_branches.py to do the cherry picking. That script takes source_branch and target_branch parameters, but they need to be valid keys into the ignored commits file. You'd probably want to amend that script